garbage collection

RE: garbage collection

Simonr — Tue, 28 May 2019 13:02:33 GMT

Hi Bar

Sorry, but I'll need you to describe what exactly your project is supposed to do and how to set it up correctly, as it will take an immense amount of time to get into it as is. Step by step would be best. And still, tell me if you want this case set to private!

Best regards,

Simon

RE: garbage collection

Bar — Tue, 28 May 2019 12:57:53 GMT

I did anther test.

Every time before and after fds_gc I active fds_stat(&stat); , and compare the statistic in state.

I actrive the function in this way:

rc = fds_stat(&stat); // TEST TEST TEST to see if gc work

rc = fds_gc();

rc = fds_stat(&stat); // TEST TEST TEST to see if gc work

When it wasn't on the limit of the FLASH the gc work fine and if there was dirty record it remove them.

But when I get to rc == FDS_ERR_NO_SPACE_IN_FLASH and try the same I get before the gc this statistic:

pages_available= 0x3

open_records= 0x0

valid_records= 0x56

dirty_records=0x55

words_used= 0x07FA

largest_contig=0x4

freeable_words=0x03F5

corruption=false

But there it go to hardfault.

The number looks logical because for ease record I update it in the past, and there is still free words.

Is this give any clue?

Bar.

RE: garbage collection

Bar — Tue, 28 May 2019 09:35:51 GMT

I play with the FDS_VIRTUAL_PAGE_SIZE (1024/2048)and FDS_VIRTUAL_PAGES(3/6) but it just expend the write area before get to the gc. The gc crass when get to the execute.

I attach a link to the whole project

https://drive.google.com/open?id=1wMrGyR6BABrZEiQG8R0lDPVpJIehySsT

The fail get around written list 85. Then when go to fds_gc

Bar

RE: garbage collection

Simonr — Tue, 28 May 2019 07:42:13 GMT

Hello Bar

Then, what have you set FDS_VIRTUAL_PAGE_SIZE and FDS_VIRTUAL_PAGES as? Remember that these values should add up with the actual amount of needed flash pages and flash page size.

If you'd like, you can send me your project so that I can try to debug it from my side, as I'm still unsure what exactly is causing this hard fault of yours. If you don't want to share your project publicly on DevZone I can set this case to private so that only Nordic engineers will be able to see it.

Best regards,

Simon

RE: garbage collection

Bar — Mon, 27 May 2019 13:52:21 GMT

I do all of this on the DK PCA10056.

FDS_VIRTUAL_PAGE_SIZE tand FDS_VIRTUAL_PAGES

I read it on this post https://devzone.nordicsemi.com/f/nordic-q-a/25923/fds-gc-seems-not-to-work

RE: garbage collection

Bar — Mon, 27 May 2019 13:27:22 GMT

O.K.

I do today a lot of fine tuning and adapt to do the FDS_gc() exactly as run in ble_app_gatts_c example.

But the some result. It send the full FLASH event and trigger the FDS_gc() but on the queue handling it fail to hardfault. From my previous experience I know it concern to memory leakage because to small "room" for one of the operation. maybe the gc need more space (each file I made is 2K) to make the job. Which defines I can "play" with and there meaning?

RE: garbage collection

Simonr — Mon, 27 May 2019 13:25:33 GMT

Hi Bar

Are you using a development kit or a custom board? And would it be possible to recreate on a development kit? Also, what do you mean by virtual flash?

Best regards,

Simon

RE: garbage collection

Bar — Mon, 27 May 2019 10:09:54 GMT

Hello Simon.

I trigger the gc when I get FDS_ERR_NO_SPACE_IN_FLASH.

I don't get any error when go into the gc itself until I get to gc_execute(uint32_t prev_ret) and then with no ERROR it go to hardfault.

Maybe it concern the size of the virtual FLASH I give? I read some issue about it and I see all use peer management also it must use for the ble. I take an example of using peer management, and I try to implement it in my work also I need to add a lot of files because I don't use it for ble purpose. Do you see it will help use the peer or I can do it without this? I will look aty the example you take about and see if I can find something I forget.

Bar.

RE: garbage collection

Simonr — Mon, 27 May 2019 07:57:49 GMT

Hi Bar

How exactly do you trigger the gc? Do you get any kind of error code so we can see what exactly goes wrong? The fds_gc() function is implemented in the ble_app_gatts_c example, so you could look at that and see if you understand more. You also have to make sure that fds.c and fds.h is included in your project.

Best regards,

Simon

RE: garbage collection

Bar — Sun, 26 May 2019 09:42:42 GMT

I use this part

err_code = fds_gc();
if (err_code == FDS_ERR_BUSY || err_code == FDS_ERR_NO_SPACE_IN_QUEUES)
{
// Retry.
}
else
{
APP_ERROR_CHECK(err_code);
}

But still go to hard fault when use it .

Is there a stack size or any pre init for the gc that I miss?

Bar.

RE: garbage collection

Bar — Sun, 26 May 2019 05:42:54 GMT

thanks Simon.

But what active it?

I1. which action trigger this case?

If written to the FLASH trigger this function it will be too late, because I can't make the writing again.

2. Where I include (init) this handler in my program ?

3. What is the difference, between my written and this one?

4. What can I do with the retry? if I still do fds_gc(); I can endup with endless loop?

Bar.

RE: garbage collection

Simonr — Fri, 24 May 2019 06:43:10 GMT

Hi Bar

Something like this function should suffice (This function uses the peer manager):

 case PM_EVT_STORAGE_FULL:
        {
            // Run garbage collection on the flash.
            err_code = fds_gc();
            if (err_code == FDS_ERR_BUSY || err_code == FDS_ERR_NO_SPACE_IN_QUEUES)
            {
                // Retry.
            }
            else
            {
                APP_ERROR_CHECK(err_code);
            }

Best regards,

Simon