pc-ble-driver suffix is messed up when compiling 4.1.1

RE: pc-ble-driver suffix is messed up when compiling 4.1.1

jpo38 — Thu, 20 Jun 2019 06:28:04 GMT

OK, that makes sense. Now when you build from sources, would be nice to have documentation mention that NRF_BLE_DRIVER_VERSION should be set. Or, eaxh branch should have it be fixed, to prevent builds generating 0.0.0 tagged files.

RE: pc-ble-driver suffix is messed up when compiling 4.1.1

Jørgen Holmefjord — Wed, 19 Jun 2019 13:30:55 GMT

This is the feedback I got from the developers:

If you are using vcpkg, the version number will be set and associated with checksum/tag of the source code: https://github.com/NordicPlayground/vcpkg/blob/master/ports/nrf-ble-driver/portfile.cmake .

When downloading the precompiled releases, the version number is set.

RE: pc-ble-driver suffix is messed up when compiling 4.1.1

jpo38 — Tue, 11 Jun 2019 15:10:38 GMT

Looks like adding -DNRF_BLE_DRIVER_VERSION=4.1.1 on CMake command line is the way to fix that. But it should not be required when building a release picked up from the release branch, it should be automatic/frozen.

RE: pc-ble-driver suffix is messed up when compiling 4.1.1

Jørgen Holmefjord — Tue, 11 Jun 2019 14:36:53 GMT

It looks like these should be set by the variables ${PROJECT_VERSION_MAJOR}, ${PROJECT_VERSION_MINOR}, and ${PROJECT_VERSION_PATCH}.

I will check with the developer if you are supposed to set these manually, or if something is missing from the script.

RE: pc-ble-driver suffix is messed up when compiling 4.1.1

jpo38 — Tue, 11 Jun 2019 12:47:57 GMT

Hello again ;-)

Project name is not an issue. But binaries being tagged 0_0_0 instead of 4_1_1 is an issue.

Jean

RE: pc-ble-driver suffix is messed up when compiling 4.1.1

Jørgen Holmefjord — Tue, 11 Jun 2019 12:45:20 GMT

Hi,

The renaming of the project was mentioned in release notes for v4.1.0. Is this causing any issues?

Best regards,
Jørgen