How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

AndreasF — Tue, 30 Jul 2019 07:11:51 GMT

Hi.

I've been on holiday.

When ble_nus_data_send() returns NRF_ERROR_NOT_FOUND it is because the connection handle is wrong or the client context is NULL, you have to fix that.

Best regards,

Andreas

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Fri, 12 Jul 2019 14:16:16 GMT

i have tried your code but when program is at

err_code = ble_nus_data_send(&m_nus, data_array, &length, m_conn_handle);

the error code is '5' that means NRF_ERROR_NOT_FOUND and how can i solve that?

or can you please kindly do some modification such that peripheral will transmit continuously and central will receive the data?

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Sat, 06 Jul 2019 03:27:33 GMT

k cool let me try that

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Jimmy Wong — Sat, 06 Jul 2019 01:40:30 GMT

you can send the data through uart either central or peripheral.

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Jimmy Wong — Sat, 06 Jul 2019 01:39:27 GMT

This demo is mainly to show the long range connection and send the long MTU up to 244 bytes.

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Sat, 06 Jul 2019 00:33:39 GMT

i am using nrf52840 DK and i can able to receive data whenever i reset the central only one data i am getting. your demo code will receive packets continuously or only once?

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Jimmy Wong — Sat, 06 Jul 2019 00:29:25 GMT

Hi,

May i know which HW do you use?

Please make sure that the long range should be tested on the NRF52840 DK instead of PDK (preview DK).

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Fri, 05 Jul 2019 17:14:29 GMT

I am using now demo code which is jimmy wang git hub repo for testing the long range in 15.3.0 sdk and i didn't merge into my code. In his code i am facing the above mentioned issue like receiving packet whenever i reset the central.

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

AndreasF — Fri, 05 Jul 2019 10:24:10 GMT

Hi.

Are you running the demo code? Or have you combined the demo code with your code?

Best regards,

Andreas

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Thu, 04 Jul 2019 14:57:53 GMT

Yeah Thanks for you help! AndreasF.

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Thu, 04 Jul 2019 14:56:39 GMT

i have tried your code now what is happening is peripheral is transmitting and central is powered but it is not receiving any packet from peripheral. It receives only one packet whenever i hit reset button in central and stops. can you tell me how to receive packets continue?

i added RSSI print in BLE_GAP_EVT_ADV_REPORT switch case in ble_evt_handler() function to check the packets are receiving are not.

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

AndreasF — Thu, 04 Jul 2019 11:01:05 GMT

Hi.

You really should not modify source files inside the SDK, this can have unwelcome consequences.

I suggest that you revert the modifications you have made in ble_advertisng.c, and take a look at how Jimmy Wong have implemented BLE_GAP_PHY_CODED in the GitHub link he attached in his reply, you should only have to modify advertising_init in order to configure coded phy.

Best regards,

Andreas

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Thu, 04 Jul 2019 10:08:44 GMT

i have attached the main.c file and copy of ble_advertisng.c where i made changes for coded mode testing.is there any changes need to be done in sdk_config.h also?

// ble_advertising.c 

#define BLE_APP_UART_CODED_ENABLED 1

uint32_t ble_advertising_init(ble_advertising_t            * const p_advertising,
                              ble_advertising_init_t const * const p_init)
{
    uint32_t ret;
    if ((p_init == NULL) || (p_advertising == NULL))
    {
        return NRF_ERROR_NULL;
    }
    if (!config_is_valid(&p_init->config))
    {
        return NRF_ERROR_INVALID_PARAM;
    }
    p_advertising->adv_mode_current               = BLE_ADV_MODE_FAST;
    p_advertising->adv_modes_config               = p_init->config;
    p_advertising->conn_cfg_tag                   = BLE_CONN_CFG_TAG_DEFAULT;
    p_advertising->evt_handler                    = p_init->evt_handler;
    p_advertising->error_handler                  = p_init->error_handler;
    p_advertising->current_slave_link_conn_handle = BLE_CONN_HANDLE_INVALID;
    p_advertising->p_adv_data                     = &p_advertising->adv_data;
    //p_advertising->adv_modes_config.ble_adv_extended_enabled = true;

    memset(&p_advertising->peer_address, 0, sizeof(p_advertising->peer_address));

    // Copy advertising data.
    if (!p_advertising->initialized)
    {
        p_advertising->adv_handle = BLE_GAP_ADV_SET_HANDLE_NOT_SET;
    }
    p_advertising->adv_data.adv_data.p_data = p_advertising->enc_advdata;

    if (p_advertising->adv_modes_config.ble_adv_extended_enabled == true)
    {
#ifdef BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED
        p_advertising->adv_data.adv_data.len = BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED;
#else
    p_advertising->adv_data.adv_data.len = BLE_GAP_ADV_SET_DATA_SIZE_MAX;
#endif // BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED
    }
    else
    {
        p_advertising->adv_data.adv_data.len = BLE_GAP_ADV_SET_DATA_SIZE_MAX;
    }

    ret = ble_advdata_encode(&p_init->advdata, p_advertising->enc_advdata, &p_advertising->adv_data.adv_data.len);
    VERIFY_SUCCESS(ret);

    p_advertising->adv_data.scan_rsp_data.p_data = p_advertising->enc_scan_rsp_data;
    if (p_advertising->adv_modes_config.ble_adv_extended_enabled == true)
    {
#ifdef BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED
        p_advertising->adv_data.scan_rsp_data.len = BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED;
#else
        p_advertising->adv_data.scan_rsp_data.len = BLE_GAP_ADV_SET_DATA_SIZE_MAX;
#endif // BLE_GAP_ADV_SET_DATA_SIZE_EXTENDED_CONNECTABLE_MAX_SUPPORTED
    }
    else
    {
        p_advertising->adv_data.scan_rsp_data.len = BLE_GAP_ADV_SET_DATA_SIZE_MAX;
    }
    ret = ble_advdata_encode(&p_init->srdata,
                              p_advertising->adv_data.scan_rsp_data.p_data,
                             &p_advertising->adv_data.scan_rsp_data.len);
    VERIFY_SUCCESS(ret);

    // Configure a initial advertising configuration. The advertising data and and advertising
    // parameters will be changed later when we call @ref ble_advertising_start, but must be set
    // to legal values here to define an advertising handle.
    p_advertising->adv_params.primary_phy     = BLE_GAP_PHY_1MBPS;
    #ifdef BLE_APP_UART_CODED
    p_advertising->adv_params.primary_phy     = BLE_GAP_PHY_CODED;
    p_advertising->adv_params.secondary_phy   = BLE_GAP_PHY_CODED;
    #endif
    p_advertising->adv_params.duration        = p_advertising->adv_modes_config.ble_adv_fast_timeout;
    p_advertising->adv_params.properties.type = BLE_GAP_ADV_TYPE_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
    #ifdef BLE_APP_UART_CODED
    p_advertising->adv_params.properties.type = BLE_GAP_ADV_TYPE_EXTENDED_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
    #endif
    p_advertising->adv_params.p_peer_addr     = NULL;
    p_advertising->adv_params.filter_policy   = BLE_GAP_ADV_FP_ANY;
    p_advertising->adv_params.interval        = p_advertising->adv_modes_config.ble_adv_fast_interval;

    ret = sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, &p_advertising->adv_data, &p_advertising->adv_params);
    VERIFY_SUCCESS(ret);

    p_advertising->initialized = true;
    return ret;
}

uint32_t ble_advertising_start(ble_advertising_t * const p_advertising,
                               ble_adv_mode_t            advertising_mode)
{
    uint32_t ret;

    if (p_advertising->initialized == false)
    {
        return NRF_ERROR_INVALID_STATE;
    }

    p_advertising->adv_mode_current = advertising_mode;

    memset(&p_advertising->peer_address, 0, sizeof(p_advertising->peer_address));

    if (  ((p_advertising->adv_modes_config.ble_adv_directed_high_duty_enabled) && (p_advertising->adv_mode_current == BLE_ADV_MODE_DIRECTED_HIGH_DUTY))
        ||((p_advertising->adv_modes_config.ble_adv_directed_enabled)           && (p_advertising->adv_mode_current == BLE_ADV_MODE_DIRECTED_HIGH_DUTY))
        ||((p_advertising->adv_modes_config.ble_adv_directed_enabled)           && (p_advertising->adv_mode_current == BLE_ADV_MODE_DIRECTED))
       )
    {
        if (p_advertising->evt_handler != NULL)
        {
            p_advertising->peer_addr_reply_expected = true;
            p_advertising->evt_handler(BLE_ADV_EVT_PEER_ADDR_REQUEST);
        }
        else
        {
            p_advertising->peer_addr_reply_expected = false;
        }
    }

    p_advertising->adv_mode_current = adv_mode_next_avail_get(p_advertising, advertising_mode);

    // Fetch the whitelist.
    if ((p_advertising->evt_handler != NULL) &&
        (p_advertising->adv_mode_current == BLE_ADV_MODE_FAST || p_advertising->adv_mode_current == BLE_ADV_MODE_SLOW) &&
        (p_advertising->adv_modes_config.ble_adv_whitelist_enabled) &&
        (!p_advertising->whitelist_temporarily_disabled))
    {
        p_advertising->whitelist_in_use         = false;
        p_advertising->whitelist_reply_expected = true;
        p_advertising->evt_handler(BLE_ADV_EVT_WHITELIST_REQUEST);
    }
    else
    {
        p_advertising->whitelist_reply_expected = false;
    }

    // Initialize advertising parameters with default values.
    memset(&p_advertising->adv_params, 0, sizeof(p_advertising->adv_params));
    p_advertising->adv_params.properties.type = BLE_GAP_ADV_TYPE_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
    #ifdef BLE_APP_UART_CODED
    p_advertising->adv_params.properties.type = BLE_GAP_ADV_TYPE_EXTENDED_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
    #endif

    // Use 1MBIT as primary phy if no phy was selected.
    if (phy_is_valid(&p_advertising->adv_modes_config.ble_adv_primary_phy))
    {
        p_advertising->adv_params.primary_phy = p_advertising->adv_modes_config.ble_adv_primary_phy;
 
    }
    else
    {
        p_advertising->adv_params.primary_phy = BLE_GAP_PHY_1MBPS;
        #ifdef BLE_APP_UART_CODED
        p_advertising->adv_params.primary_phy = BLE_GAP_PHY_CODED;
        #endif

    }

    if (p_advertising->adv_modes_config.ble_adv_extended_enabled)
    {
        // Use 1MBIT as secondary phy if no phy was selected.
        if (phy_is_valid(&p_advertising->adv_modes_config.ble_adv_primary_phy))
        {
            p_advertising->adv_params.secondary_phy = p_advertising->adv_modes_config.ble_adv_secondary_phy;

        }
        else
        {
            p_advertising->adv_params.secondary_phy = BLE_GAP_PHY_1MBPS;
            #ifdef BLE_APP_UART_CODED
            p_advertising->adv_params.secondary_phy = BLE_GAP_PHY_CODED;
            #endif
        }
    }
     p_advertising->adv_params.filter_policy = BLE_GAP_ADV_FP_ANY;

    // Set advertising parameters and events according to selected advertising mode.
    switch (p_advertising->adv_mode_current)
    {
        case BLE_ADV_MODE_DIRECTED_HIGH_DUTY:
            ret = set_adv_mode_directed_high_duty(p_advertising, &p_advertising->adv_params);
            break;

        case BLE_ADV_MODE_DIRECTED:
            ret = set_adv_mode_directed(p_advertising, &p_advertising->adv_params);
            break;

        case BLE_ADV_MODE_FAST:
            ret = set_adv_mode_fast(p_advertising, &p_advertising->adv_params);
            break;

        case BLE_ADV_MODE_SLOW:
            ret = set_adv_mode_slow(p_advertising, &p_advertising->adv_params);
            break;

        case BLE_ADV_MODE_IDLE:
            p_advertising->adv_evt = BLE_ADV_EVT_IDLE;
            break;

        default:
            break;
    }

    if (p_advertising->adv_mode_current != BLE_ADV_MODE_IDLE)
    {
        //#ifndef BLE_APP_UART_CODED
        uint8_t *p_data_test = p_advertising->p_adv_data->adv_data.p_data;
        for(int d=0;d<31;d++){
        printf("\n value %d = %X",d,*p_data_test);
        p_data_test++;
        nrf_delay_ms(10);
        }
        ret = sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, &p_advertising->adv_data, &p_advertising->adv_params);
        if (ret != NRF_SUCCESS)
        {
            return ret;
        }
        //#endif
        ret = sd_ble_gap_adv_start(p_advertising->adv_handle, p_advertising->conn_cfg_tag);

        if (ret != NRF_SUCCESS)
        {
            return ret;
        }
    }

    if (p_advertising->evt_handler != NULL)
    {
        p_advertising->evt_handler(p_advertising->adv_evt);
    }

    return NRF_SUCCESS;
}

devzone.nordicsemi.com/.../3113.main.cwhenever code is at sd_ble_gap_adv_set_configure() device resets and if i comment it then it is advertising in legacy mode even if the primary_phy i made as coded phy in ble_advertisng_init().

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Thu, 04 Jul 2019 08:36:34 GMT

yeah sure i can share

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Jimmy Wong — Thu, 04 Jul 2019 08:27:37 GMT

Hi,

you can find the demo code at https://github.com/jimmywong2003/nrf52-ble5-long-range-demo. this demo is only long range advertising.

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

AndreasF — Thu, 04 Jul 2019 07:51:20 GMT

Hi.

I'm not quite sure what you are talking about here, could you share your main.c file?

I can make the case private if you like.

Best regards,

Andreas

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

Yogeshwaran — Wed, 03 Jul 2019 16:58:30 GMT

I have did this already in my code. so whenever ble advertising is starting the device is resetting. Legacy mode is working perfectly without any issue in the same code. The point where it is 'sd_ble_cfg_set()' function, so if i do the above change and comment out this part then it is advertising in legacy mode and once if i un comment the above function(already primary_phy and propertise.type are change to coded and extended respectively) then device resetting.

What could be the issue?

RE: How to implement CODED_PHY in ble_app_uart in SDK 15.3.0

AndreasF — Tue, 02 Jul 2019 09:03:08 GMT

Hi.

You have to set the adv_params.primary_phy to BLE_GAP_PHY_CODED.and check that the adv_params.properties.type is a EXTENDED option.

Best regards,

Andreas