Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Hadi Deknache — Thu, 29 Aug 2019 08:32:17 GMT

Hi Vidar,

After checking the makefile, it seems to be the case. The build_rules are compiled with other preprocessor flags and therefore result in enabling the log, causing the application to fail. Thanks for your time and help!

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Wed, 28 Aug 2019 06:00:35 GMT

Looking at the old case linked to in the OP I see you are building a "sdk" library of common files first. Is it rebuilt with the same flags? It seems clear that this has something to do with the build system at least.

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Hadi Deknache — Tue, 27 Aug 2019 12:17:26 GMT

NRF_LOG_ENABLED is defined below as following:

#ifndef NRF_LOG_ENABLED
#define NRF_LOG_ENABLED ENABLE_LOGGING
#endif

We have only changed the defined value with the defined variable ENABLE_LOGGING

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Tue, 27 Aug 2019 12:14:46 GMT

Is NRF_LOG_ENABLED defined somewhere, or have you renamed it to ENABLE_LOGGING?

[quote userid="68658" url="~/f/nordic-q-a/51289/buttonless-dfu-service-does-not-start-when-nrf_log_enabled-is-set-0/206361"]Also, I have noticed that if we do not init dfu service, then the application works perfectly. Shouldn't the application crash elsewhere in the code if that was the case?[/quote]

I agree, and I'm not sure I can't explain why. I have tried to replicate the problem here by enabling logging while having all backends disabled, etc but with no luck so far.

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Hadi Deknache — Tue, 27 Aug 2019 12:03:29 GMT

Enable_logging shouldn't be redefined elsewhere since it is only defined in sdk_config.h and the makefile when compiling it as release. This is how the application is written currently:

/*******Makefile******/

build_release: _app
	ENABLE_LOGGING=0 BUILD_TYPE=app TARGET=nrf52 ...
	
ifeq ($(ENABLE_LOGGING),)
$(info ENABLE_LOGGING not defined, using default ENABLE_LOGGING=1.)
else
$(info ENABLE_LOGGING=$(ENABLE_LOGGING))
CFLAGS += -DENABLE_LOGGING=$(ENABLE_LOGGING)
endif

/******Makefile*******/

/******sdk_config.h*******/

#ifndef ENABLE_LOGGING
#define ENABLE_LOGGING 1
#endif

/*****sdk_config.h*******/

Also, I have noticed that if we do not init dfu service, then the application works perfectly. Shouldn't the application crash elsewhere in the code if that was the case?

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Tue, 27 Aug 2019 07:14:41 GMT

Could it possible that Enable_logging gets redefined in your code? log_skip() will not be built if NRF_LOG_ENABLED==0

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Hadi Deknache — Tue, 27 Aug 2019 06:44:08 GMT

We are currently using SDK version 15.0. I have noticed that when we hard code the Enable_logging=0 flag in the sdk_config.h file, the application works fine, however, the application get stuck in log_skip() when changing the flag in the makefile.

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Tue, 27 Aug 2019 06:41:53 GMT

There's no hardfault, but the stack trace confirms that the program starts executing log_skip() as you said, and log_skip() should not be invoked as long as NRF_LOG_ENABLED==0. What SDK version are you on?

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Hadi Deknache — Mon, 26 Aug 2019 11:50:08 GMT

Hi again,

I have run the commands you asked me to and got the following output:

r0             0x1	1
r1             0x2000fe58	536936024
r2             0x200055dc	536892892
r3             0x2000fe58	536936024
r4             0x2000ffd0	536936400
r5             0x3a030	237616
r6             0x7e000	516096
r7             0x2000fe48	536936008
r8             0x0	0
r9             0x0	0
r10            0x20000000	536870912
r11            0x0	0
r12            0x20006da4	536898980
sp             0x2000fe48	0x2000fe48
lr             0x32d7d	208253
pc             0x32d76	0x32d76 <log_skip+58>
xpsr           0x1000000	16777216
msp            0x2000fe48	536936008
psp            0x0	0
primask        0x0	0
basepri        0x0	0
faultmask      0x0	0
control        0x0	0
(gdb) bt
#0  0x00032d76 in log_skip ()
    at /xx/xx/xx/xx/sdk_files/components/libraries/experimental_log/src/nrf_log_frontend.c:360
#1  0x00032f52 in buf_prealloc (content_len=1, p_wr_idx=0x2000fec8, std=true)
    at /xx/xx/xx/xx/sdk_files/components/libraries/experimental_log/src/nrf_log_frontend.c:464
#2  0x0003303a in std_n (severity_mid=3, 
    p_str=0x3a3ec "Setting vector table to bootloader: 0x%08x", 
    args=0x2000fef4, nargs=1)
    at /xx/xx/xx/xx/sdk_files/components/libraries/experimental_log/src/nrf_log_frontend.c:585
#3  0x000330e8 in nrf_log_frontend_std_1 (severity_mid=3, 
    p_str=0x3a3ec "Setting vector table to bootloader: 0x%08x", val0=466944)
    at /xx/xx/xx/xx/sdk_files/components/libraries/experimental_log/src/nrf_log_frontend.c:615
#4  0x00032b4c in nrf_dfu_svci_vector_table_set ()
    at /xx/xx/xx/xx/sdk_files/components/libraries/bootloader/dfu/nrf_dfu_svci.c:56
#5  0x0002c26e in ble_dfu_buttonless_async_svci_init ()
    at /xx/xx/xx/xx/sdk_files/components/ble/ble_services/ble_dfu/ble_dfu_bonded.c:210
#6  0x00026b9e in dfu_service_init () at dfu.c:125
#7  0x00026798 in main () at main.c:319

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Mon, 26 Aug 2019 10:49:52 GMT

Hi Hadi,

Do you do any logging in the hardfault handler? Can you run "info registers" and "bt" in GDB to check where the program is stuck?

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Hadi Deknache — Mon, 26 Aug 2019 10:29:38 GMT

Hi Vidar,

I am Anton's colleague, I have tried to debug the application through gdb and notice that the application seems to be stuck in a function that is called log_skip().

I get the following message when I halt the application to check: Program received signal SIGTRAP, Trace, breakpoint trap. Log_skip().

I have set a breakpoint in main but seem that it never reaches main when nrf_log is disabled, however, when I enable nrf_log this error never occurs.

Any idea why the application is stuck in log_skip, is it triggered by a Hardfault?

/Hadi

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

AntonHellbe — Fri, 23 Aug 2019 11:07:48 GMT

Hi Vidar,

Thanks for the tips. I disabled logging in the "debug" build and it kept working. So there is something in our release build that causes the application not function properly. From what I can see all we do in our release build is that we set an additional preprocessor flag that removes the logs, see below:

ifeq ($(ENABLE_LOGGING),)
$(info ENABLE_LOGGING not defined, using default ENABLE_LOGGING=1.)
else
$(info ENABLE_LOGGING=$(ENABLE_LOGGING))
CFLAGS += -DENABLE_LOGGING=$(ENABLE_LOGGING)
endif

Anyways, I think we will have to investigate further our side. Thank you so far.

Edit: the preprocessor flag which you can see above being set is then being used in the sdk_config.h file.

/ Anton

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Fri, 23 Aug 2019 05:45:59 GMT

Thanks for the clarification. It sounds like we would need to debug the application to figure out why the program hangs when you select DFU mode. Have you tried to disable logging in the 'debug' target to see if it has the same effect? I guess it could be related to other differences such as compiler optimization as well.

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

AntonHellbe — Thu, 22 Aug 2019 13:55:00 GMT

Here is the log from the bootloader:

<info> app: Inside main
<debug> app: In nrf_bootloader_init
<debug> nrf_dfu_settings: Calling nrf_dfu_settings_init()...
<debug> nrf_dfu_flash: Initializing nrf_fstorage_nvmc backend.
<debug> app: Enter nrf_bootloader_fw_activate
<info> app: No firmware to activate.
<debug> app: Enter nrf_dfu_app_is_valid
<debug> app: Return true. App was valid
<debug> app: Running nrf_bootloader_app_start with address: 0x00001000
<debug> app: Disabling interrupts. NVIC->ICER[0]: 0x0
<debug> app: running irq table set
<debug> app: After running irq table set

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

AntonHellbe — Thu, 22 Aug 2019 13:00:00 GMT

Hi Vidar,

Yes everytime we flash we re-generate the settings page.

I know that the bootloader starts the application because we have different "modes" in the application, 2 of them does not use the DFU service. When I put the nRF52832 in one of the two other modes that does not use the DFU service I can see the advertisement and I can connect.

/ Anton

RE: Buttonless DFU service does not start when NRF_LOG_ENABLED is set 0

Vidar Berg — Thu, 22 Aug 2019 12:54:55 GMT

Hi,

Maybe I'm way off but I wonder if it could be caused by an invalid CRC value in your bl settings page which would cause the bootloader to enter DFU mode. Is this page being re-generated each time you compile the app? As you may know, the settings page includes a CRC checksum value of the app image which must match the CRC of the actual app image stored in flash. The bootloader will not "jump" to the application if there's a mismatch. Does your device appear to be stuck in DFU mode?