non-connectable advertising while connected on SDK15.3

RE: non-connectable advertising while connected on SDK15.3

testsweng — Thu, 03 Oct 2019 18:59:37 GMT

what is your peripheral_link count set to in sdk_config.h?

RE: non-connectable advertising while connected on SDK15.3

awneil — Tue, 10 Sep 2019 09:01:26 GMT

RE: non-connectable advertising while connected on SDK15.3

kreis — Tue, 10 Sep 2019 08:56:31 GMT

Hi,

I tested here and it worked! In that case I changed the advertising type to a scannable one and that passed.

I needed to update the other part of the code as well so for reference I'm posting the updated code here.

static void advertising_init(bool connectable)
{
    ret_code_t    err_code;
    ble_advdata_t advdata;
    ble_advdata_t srdata;

    ble_uuid_t adv_uuids[] = {{LBS_UUID_SERVICE, m_lbs.uuid_type}};

    // Build and set advertising data.
    memset(&advdata, 0, sizeof(advdata));

    advdata.name_type          = BLE_ADVDATA_FULL_NAME;
    advdata.include_appearance = true;
    advdata.flags              = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;


    memset(&srdata, 0, sizeof(srdata));
    srdata.uuids_complete.uuid_cnt = sizeof(adv_uuids) / sizeof(adv_uuids[0]);
    srdata.uuids_complete.p_uuids  = adv_uuids;

    err_code = ble_advdata_encode(&advdata, m_adv_data.adv_data.p_data, &m_adv_data.adv_data.len);
    APP_ERROR_CHECK(err_code);

    err_code = ble_advdata_encode(&srdata, m_adv_data.scan_rsp_data.p_data, &m_adv_data.scan_rsp_data.len);
    APP_ERROR_CHECK(err_code);

    ble_gap_adv_params_t adv_params;

    // Set advertising parameters.
    memset(&adv_params, 0, sizeof(adv_params));

    if(connectable)
    {
      adv_params.properties.type = BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED;
      adv_params.interval        = APP_ADV_INTERVAL;
    }
    else
    {
      adv_params.properties.type = BLE_GAP_ADV_TYPE_NONCONNECTABLE_SCANNABLE_UNDIRECTED;
      adv_params.interval        = 320;
    }
    adv_params.primary_phy     = BLE_GAP_PHY_1MBPS;
    adv_params.duration        = APP_ADV_DURATION;
    adv_params.p_peer_addr     = NULL;
    adv_params.filter_policy   = BLE_GAP_ADV_FP_ANY;
    
    err_code = sd_ble_gap_adv_set_configure(&m_adv_handle, &m_adv_data, &adv_params);
    NRF_LOG_INFO("error code: %x", err_code);
    APP_ERROR_CHECK(err_code);
}

//---------------------------------

case BLE_GAP_EVT_CONNECTED:
    NRF_LOG_INFO("Connected");
    bsp_board_led_on(CONNECTED_LED);
    bsp_board_led_off(ADVERTISING_LED);
    m_conn_handle = p_ble_evt->evt.gap_evt.conn_handle;
    err_code = nrf_ble_qwr_conn_handle_assign(&m_qwr, m_conn_handle);
    APP_ERROR_CHECK(err_code);
    err_code = app_button_enable();
    APP_ERROR_CHECK(err_code);

    advertising_init(false);
    advertising_start();
    break;

case BLE_GAP_EVT_DISCONNECTED:
    NRF_LOG_INFO("Disconnected");
    bsp_board_led_off(CONNECTED_LED);
    m_conn_handle = BLE_CONN_HANDLE_INVALID;
    err_code = app_button_disable();
    APP_ERROR_CHECK(err_code);

    advertising_stop();
    advertising_init(true);
    advertising_start();
    break;

Thank you all for your help!

RE: non-connectable advertising while connected on SDK15.3

awneil — Mon, 09 Sep 2019 15:40:33 GMT

[quote userid="8164" url="~/f/nordic-q-a/51808/non-connectable-advertising-while-connected-on-sdk15-3/208749"] I do not have time to test now, but I suspect that might give invalid parameter error.[/quote]

Yes, I think this error code includes, "this particular combination of parameters is not allowed" ?

RE: non-connectable advertising while connected on SDK15.3

tesc — Mon, 09 Sep 2019 15:34:07 GMT

Hi,

You still prepare and send in scan response data (see the srdata variable), which is not needed when you do non-scannable advertising. I do not have time to test now, but I suspect that might give invalid parameter error.

Edit: Removed paragraph mentioning static memory for advertising data, as I realized you used static memory for that.

Regards,
Terje

RE: non-connectable advertising while connected on SDK15.3

Jimmy Wong — Mon, 09 Sep 2019 14:58:48 GMT

Hi,

i did the demo at https://github.com/jimmywong2003/nrf5-modify-device-parameter-through-host.

the device can do the connectable adv with mobile for parameter change. Also it does the non-connectable adv as beacon adv.

RE: non-connectable advertising while connected on SDK15.3

kreis — Mon, 09 Sep 2019 14:27:26 GMT

Hi,

I'm using the SDK15.3 softdevice s140 6.1.1

to illustrate better I did the following. Used the example ble_app_blinky and modified just the parts I'm posting here, the rest of the code I didn't change anything.

Firstly for the function advertising_init() I just created a parameter to tell if the advertising is of the type connectable or not if it's connectable there's no change related to the original function, otherwise, it changes the type to non-connectable. As follows:

static void advertising_init(bool connectable)
{
    ret_code_t    err_code;
    ble_advdata_t advdata;
    ble_advdata_t srdata;

    ble_uuid_t adv_uuids[] = {{LBS_UUID_SERVICE, m_lbs.uuid_type}};

    // Build and set advertising data.
    memset(&advdata, 0, sizeof(advdata));

    advdata.name_type          = BLE_ADVDATA_FULL_NAME;
    advdata.include_appearance = true;
    advdata.flags              = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;


    memset(&srdata, 0, sizeof(srdata));
    srdata.uuids_complete.uuid_cnt = sizeof(adv_uuids) / sizeof(adv_uuids[0]);
    srdata.uuids_complete.p_uuids  = adv_uuids;

    err_code = ble_advdata_encode(&advdata, m_adv_data.adv_data.p_data, &m_adv_data.adv_data.len);
    APP_ERROR_CHECK(err_code);

    err_code = ble_advdata_encode(&srdata, m_adv_data.scan_rsp_data.p_data, &m_adv_data.scan_rsp_data.len);
    APP_ERROR_CHECK(err_code);

    ble_gap_adv_params_t adv_params;

    // Set advertising parameters.
    memset(&adv_params, 0, sizeof(adv_params));

    if(connectable)
    {
      adv_params.properties.type = BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED;
      adv_params.interval        = APP_ADV_INTERVAL;
    }
    else
    {
      adv_params.properties.type = BLE_GAP_ADV_TYPE_NONCONNECTABLE_NONSCANNABLE_UNDIRECTED;
      adv_params.interval        = 320;
    }
    adv_params.primary_phy     = BLE_GAP_PHY_1MBPS;
    adv_params.duration        = APP_ADV_DURATION;
    adv_params.p_peer_addr     = NULL;
    adv_params.filter_policy   = BLE_GAP_ADV_FP_ANY;
    
    err_code = sd_ble_gap_adv_set_configure(&m_adv_handle, &m_adv_data, &adv_params);
    NRF_LOG_INFO("error code: %x", err_code);
    APP_ERROR_CHECK(err_code);
}

Later I called the advertisig_init with the corresponding parameter of non-connectable in the BLE_GAT_EVT_CONNECTED as bellow.

        case BLE_GAP_EVT_CONNECTED:
            NRF_LOG_INFO("Connected");
            bsp_board_led_on(CONNECTED_LED);
            bsp_board_led_off(ADVERTISING_LED);
            m_conn_handle = p_ble_evt->evt.gap_evt.conn_handle;
            err_code = nrf_ble_qwr_conn_handle_assign(&m_qwr, m_conn_handle);
            APP_ERROR_CHECK(err_code);
            err_code = app_button_enable();
            APP_ERROR_CHECK(err_code);

            advertising_init(false);
            advertising_start();
            break;

When I run the code and try to connect it returns an error 7 in the function

sd_ble_gap_adv_set_configure(&m_adv_handle, &m_adv_data, &adv_params);

Thank you all for the help.

RE: non-connectable advertising while connected on SDK15.3

tesc — Mon, 09 Sep 2019 11:07:13 GMT

Hi,

What exact SoftDevice are you using? S140 v6.1.1?

Unfortunately NRF_ERROR_INVALID_PARAM from sd_ble_gap_adv_set_configure() may mean several things, but if you share here how and what you fill into the structs used for p_adv_data and p_adv_params I will try to help figure this out.

Regards,
Terje

RE: non-connectable advertising while connected on SDK15.3

awneil — Mon, 09 Sep 2019 10:00:43 GMT

You will have seen my comments about how unhelpful that error message is!

😞

RE: non-connectable advertising while connected on SDK15.3

kreis — Mon, 09 Sep 2019 09:52:54 GMT

As for the error code 7 it means NRF_ERROR_INVALID_PARAM though the only modification I made in the example advertising_init function was to change the BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED to BLE_GAP_ADV_TYPE_NONCONNECTABLE_NONSCANNABLE_UNDIRECTED as suggested. I also tried increasing the advertising period to 200ms but the error persists.

RE: non-connectable advertising while connected on SDK15.3

kreis — Mon, 09 Sep 2019 09:43:05 GMT

This is the workaround, but it works to update only the manufacture data:

https://devzone.nordicsemi.com/f/nordic-q-a/33606/updating-advertising-data-manuf-spec-data-in-sdk15/144853#144853

RE: non-connectable advertising while connected on SDK15.3

awneil — Mon, 09 Sep 2019 09:06:45 GMT

[quote userid="12962" url="~/f/nordic-q-a/51808/non-connectable-advertising-while-connected-on-sdk15-3/208608"]it returns the error code 7.[/quote]

Have you looked up what that code means?

[quote userid="12962" url="~/f/nordic-q-a/51808/non-connectable-advertising-while-connected-on-sdk15-3/208608"] I found a workaround in the forum[/quote]

Link?

RE: non-connectable advertising while connected on SDK15.3

kreis — Mon, 09 Sep 2019 08:53:23 GMT

Hi awneil!

Thank you very much for your prompt help.

I spent some time trying to make it work but it didn't. Actually this is the approach I was trying to before.

As far as I understood the SDK15 returns an error when I call the function sd_ble_gap_adv_set_configure, which is necessary to change the advertising to non-connectable, inside the BLE_GAP_EVT_CONNECTED it returns the error code 7.

I've gone through this same problem when trying to update the contents of the advertising package, but in that case, I found a workaround in the forum where there was no need to call the function sd_ble_gap_adv_set_configure. For the current problem it does not work.

Thank you.

RE: non-connectable advertising while connected on SDK15.3

awneil — Thu, 05 Sep 2019 14:38:58 GMT

https://devzone.nordicsemi.com/f/nordic-q-a/49872/advertise-connected-when-connected/198912#198912