Incorrect custom service being updated by ble_cus_custom_value_update()

RE: Incorrect custom service being updated by ble_cus_custom_value_update()

bjorn-spockeli — Thu, 26 Sep 2019 14:27:01 GMT

No, just call BLE_CUS_DEF once with _name set to mcus and the _cnt to 2.
Then refer to mcus[0] and mcus[1] as the two instances

RE: Incorrect custom service being updated by ble_cus_custom_value_update()

thoric_fish — Thu, 26 Sep 2019 12:45:25 GMT

Hi Bjørn,

So when I call BLE_CUS_DEF in main.c, I should now pass mcus into the first parameter of the BLE_CUS_DEF(mcus, 2) call? Then I can use mcus[0] and mcus[1] as the two instances

RE: Incorrect custom service being updated by ble_cus_custom_value_update()

bjorn-spockeli — Wed, 25 Sep 2019 13:16:27 GMT

Call BLE_CUS_DEF once with cnt set to 2 ( which ever number of custom services youre populating the gatt table with) so that it defines an array of ble_cus_s structures. Then refer to the first instance as &mcus[0] and the second as &mcus[2] etc.

RE: Incorrect custom service being updated by ble_cus_custom_value_update()

thoric_fish — Mon, 23 Sep 2019 13:28:08 GMT

Hi Bjørn,

I am using SDK v15. I will try to find the handle for ble_cus_custom_value_update().

[quote userid="7571" url="~/f/nordic-q-a/52344/incorrect-custom-service-being-updated-by-ble_cus_custom_value_update/211283"]

I would argue that there is no need to add BLE_CUS_DEF twice in main.c when you're using NRF_SDH_BLE_OBSERVERS and not NRF_SDH_BLE_OBSERVER. Now, you're infact declaring 4 ble_cus structs as well as registering 4 observers instead of two.

[/quote]

So what is the proper way to declare and register 'mcus2' (the second instance of the custom service ble_cus_s struct), if there is no need to call BLE_CUS_DEF twice in main.c?

RE: Incorrect custom service being updated by ble_cus_custom_value_update()

bjorn-spockeli — Mon, 23 Sep 2019 13:18:13 GMT

Hi Thoric_fish,

Firstly which SDK version are you using?

I see that you have defined BLE_CUS_DEF the following way

#define BLE_CUS_DEF(_name, _cnt)                                                                      \
static ble_cus_t _name[_cnt];                          \
NRF_SDH_BLE_OBSERVERS(_name ## _obs,                                                                 \
                     BLE_HRS_BLE_OBSERVER_PRIO,                                                     \
                     ble_cus_on_ble_evt, &_name, _cnt)

[quote user=""]However, right now the most confusing issue is why m_cus2 is getting its custom characteristic value incremented after notifications are turned on, when this behavior was supposed to be for m_cus only. Any suggestions? [/quote]

I agree that since ble_cus_custom_value_update(ble_cus_t * p_cus, uint8_t custom_value) takes a pointer to a ble_cus_t structure, then the sd_ble_gatts_value_set() and sd_ble_gatts_hvx() calls should refer to the handle passed with the p_cus pointer.

Which handle is used when you're calling ble_cus_custom_value_update()? Just add a NRF_LOG_INFO() line that prints the p_cus->custom_value_handles.value_handle.

Best regards

Bjørn