pstorage update problem-call back is not getting called

RE: pstorage update problem-call back is not getting called

Morten Kristiansen — Fri, 18 Dec 2015 14:28:32 GMT

I know this is a bit late; but you might experience the same problem as we do. We use SDK 7.1.0 since we use nRF51 V2.

In pstorage_sys_event_handler it clears m_cmd_queue.flash_access = false regardless of what message it receives. This makes pstorage.c go kawonga and you don't receive your callback.

We solved the problem by only invoking pstorage_sys_event_handler for flash events.

Also, just a stupid thought... Did you remember to declare pstorage_wait_flag volatile?

static void sys_evt_dispatch(uint32_t sys_evt)
{
    switch (sys_evt)
    {
    case NRF_EVT_FLASH_OPERATION_SUCCESS:
    case NRF_EVT_FLASH_OPERATION_ERROR:
        pstorage_sys_event_handler(sys_evt);

        break;

    default:
        // No implementation needed.
        break;
    }
}

RE: pstorage update problem-call back is not getting called

Bill Siever — Fri, 13 Feb 2015 05:00:33 GMT

One approach:

You could remove the delay loop from pstorage_update_block(). You could change on_write_mode_handler() so it starts a recurring timer with a short delay. When the timer is completed, it's callback checks to see that all pending writes are done. If so, it does therapy_parameters_write(), pstorage_update_block(), and cancels the timer. Otherwise it just delays and checks again.

There are a lot of variations on this approach. I just tried to describe a technique that takes minimal code.

On a related note, it might be worth looking into the time required for a flash update. You might be able to show that events will always be far enough apart that all writes will be completed before the next could possibly be requested.

RE: pstorage update problem-call back is not getting called

asma — Fri, 13 Feb 2015 04:07:38 GMT

Thanks bill for your reply. according to your 3rd point i shud wait for update or store to complete. is there any other way to know if this operation is complete or not , one way i know is callback handler which is i am using , but its not working as i mentioned . is there any other way out.

Thanks & Regards Asma

RE: pstorage update problem-call back is not getting called

Bill Siever — Thu, 12 Feb 2015 12:46:39 GMT

I'm not sure, but I think there's a chance you're seeing "starvation" of a shared resource. (Perhaps Petter can quickly confirm/deny).

From a soft radio callback (on_write_mode_handler()) you're calling:

void pstorage_update_block(void)
{
    retval = pstorage_block_identifier_get(&handle, 0, &block_0_handle);

    pstorage_wait_handle = block_0_handle.block_id;            //Specify which pstorage handle to wait for 
    pstorage_wait_flag = 1;                                    //Set the wait flag. Cleared in the example_cb_handler
    retval = pstorage_update(&block_0_handle, source_data_0, 16, 0);    //update flash block 0

    while(pstorage_wait_flag) { power_manage();}               //Sleep until update operation is finished.
 }

Essentially it is stuck in the callback until pstorage_wait_flag is cleared. But the pstorage_wait_flag is cleared in another callback (example_cb_handler()). If the initial callback (on_write_mode_handler()) has a higher priority or even if they are resolved in first-come-first-serve order, the example_cb_handler() callback will never get a chance to run and never be able to update the flag that pstorage_update_block() is waiting on.

I don't think there's any need to do the "while(pstorage_wait_flag) { power_manage();}" in pstorage_update_block(). I think the only reasons you would need to wait are:

If you want to read data and there are pending operations on the same block.
If the pstorage command queue is full.
If you want to modify the data buffer that you passed to pstorage_update() or pstorage_store(), you should wait for the update or store to complete.

RE: pstorage update problem-call back is not getting called

Petter Myhre — Thu, 12 Feb 2015 11:16:31 GMT

Could you upload your complete project so I can test it here?