Enabling 2MBPS and CODED PHYs

RE: Enabling 2MBPS and CODED PHYs

Hung Bui — Tue, 10 Mar 2020 17:16:18 GMT

Hi Usman,

Please try to debug. The debug guide is here: devzone.nordicsemi.com/.../

RE: Enabling 2MBPS and CODED PHYs

usman — Mon, 09 Mar 2020 16:43:37 GMT

Hi Hung

I tried this advertising code in blinky example. on my device it is not working and I am getting this error

¨00> <info> app_timer: RTC: initialized.
00>
00> <error> app: Fatal error
00>

¨¨

Led 1 that turn on normally when i am using 1 Mbps is not turning on using above mentioned code.

I shall be very thankful to you if you will help me to sort out this isuue

thanks

Usman

RE: Enabling 2MBPS and CODED PHYs

Hung Bui — Mon, 06 Jan 2020 10:15:44 GMT

You mentioned that you were using blinky example as the base. I assume it's the ble_app_blinky. The code I posted should work with the ble_app_blinky as the base so you can modify it to your needs.

If you want to have your own service UUID/data in the advertising packet. Just use advdata instead of srdata:

advdata.uuids_complete.uuid_cnt = sizeof(adv_uuids) / sizeof(adv_uuids[0]);
advdata.uuids_complete.p_uuids = adv_uuids;

As long as you set m_adv_data.scan_rsp_data.len=0; the code should work with just the .phys and the .type change.

RE: Enabling 2MBPS and CODED PHYs

Adam Gerken — Fri, 03 Jan 2020 16:27:12 GMT

Your code is for the lbs service, I'm not using that. You also didn't include what you used for the m_adv_data values. It looks like you just changed the .phys and .type which doesn't work for me.

RE: Enabling 2MBPS and CODED PHYs

Hung Bui — Fri, 03 Jan 2020 16:23:55 GMT

Hmm, not sure why but in my case it didn't complain. Have you tried my code?

RE: Enabling 2MBPS and CODED PHYs

Adam Gerken — Fri, 03 Jan 2020 14:19:37 GMT

What does that mean? I thought I set the length to 0 but I still get the error.

RE: Enabling 2MBPS and CODED PHYs

Hung Bui — Fri, 03 Jan 2020 08:48:15 GMT

Just remove the srdata, or set the length to 0, it's fine. As I mentioned when advertising in coded phy the data is sent via data channel, not the advertising channel so there is no scan response packet. All data can go into the advertising packet.

RE: Enabling 2MBPS and CODED PHYs

Adam Gerken — Thu, 02 Jan 2020 20:48:28 GMT

Hung, this runs for me if I comment out lines 24 and 25, (53/54 below) but I'm not sure if it'll actually work... I don't have a coded phy peer right now. Is it acceptable to remove these lines?

If I uncomment them I get a DATA_LENGTH error.

/**@brief Struct that contains pointers to the encoded advertising data. */
static ble_gap_adv_data_t m_adv_data =
{
    .adv_data =
    {
        .p_data = m_enc_advdata,
        .len    = BLE_GAP_ADV_SET_DATA_SIZE_MAX
    },
    .scan_rsp_data =
    {
        .p_data = m_enc_scan_response_data,
        .len    = BLE_GAP_ADV_SET_DATA_SIZE_MAX

    }
};
/**@brief Struct that contains pointers to the encoded advertising data for extended advertising types. */
static ble_gap_adv_data_t m_adv_data_ext =
{
    .adv_data =
    {
        .p_data = m_enc_advdata,
        .len    = BLE_GAP_ADV_SET_DATA_SIZE_MAX
    },
    .scan_rsp_data =
    {
        .p_data = NULL,//m_enc_scan_response_data,
        .len    = 0//BLE_GAP_ADV_SET_DATA_SIZE_MAX

    }
};

static void advertising_init(void){

    ret_code_t    err_code;
    ble_advdata_t advdata;
    ble_advdata_t srdata;

    ble_uuid_t adv_uuids[] = {{CTCWS_UUID_CONFIG_SERVICE, m_ctcws.uuid_type}};

    // Build and set advertising data.
    memset(&advdata, 0, sizeof(advdata));

    advdata.name_type          = BLE_ADVDATA_FULL_NAME;
    advdata.include_appearance = true;
    advdata.flags              = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;


    memset(&srdata, 0, sizeof(srdata));
    srdata.uuids_complete.uuid_cnt = sizeof(adv_uuids) / sizeof(adv_uuids[0]);
    srdata.uuids_complete.p_uuids  = adv_uuids;

    err_code = ble_advdata_encode(&advdata, m_adv_data.adv_data.p_data, &m_adv_data.adv_data.len);
    APP_ERROR_CHECK(err_code);

    if (tx_rate != BLE_GAP_PHY_CODED){  //anything other than coded

        err_code = ble_advdata_encode(&srdata, m_adv_data.scan_rsp_data.p_data, &m_adv_data.scan_rsp_data.len);
        APP_ERROR_CHECK(err_code);

        ble_gap_adv_params_t adv_params;

        // Set advertising parameters.
        memset(&adv_params, 0, sizeof(adv_params));

        adv_params.primary_phy      = BLE_GAP_PHY_1MBPS;
        adv_params.primary_phy      = BLE_GAP_PHY_1MBPS;
        adv_params.duration         = advertise_timeout;
        adv_params.properties.type  = BLE_GAP_ADV_TYPE_CONNECTABLE_SCANNABLE_UNDIRECTED;
        adv_params.p_peer_addr      = NULL;
        adv_params.filter_policy    = BLE_GAP_ADV_FP_ANY;
        adv_params.interval         = advertise_interval;

        err_code = sd_ble_gap_adv_set_configure(&m_adv_handle, &m_adv_data, &adv_params);
        APP_ERROR_CHECK(err_code);

        #ifdef DEBUG
        printf("Advertising at 1Mbps\r\n");
        #endif

    }//tx_rate != BLE_GAP_PHY_CODED

    else{ //tx_rate == BLE_GAP_PHY_CODED

        //err_code = ble_advdata_encode(&srdata, m_adv_data_ext.scan_rsp_data.p_data, &m_adv_data_ext.scan_rsp_data.len);
        //APP_ERROR_CHECK(err_code);

        ble_gap_adv_params_t adv_params;

        // Set advertising parameters.
        memset(&adv_params, 0, sizeof(adv_params));

        adv_params.primary_phy      = BLE_GAP_PHY_CODED;
        adv_params.primary_phy      = BLE_GAP_PHY_CODED;
        adv_params.duration         = advertise_timeout;
        adv_params.properties.type  = BLE_GAP_ADV_TYPE_EXTENDED_CONNECTABLE_NONSCANNABLE_UNDIRECTED;
        adv_params.p_peer_addr      = NULL;
        adv_params.filter_policy    = BLE_GAP_ADV_FP_ANY;
        adv_params.interval         = advertise_interval;

        err_code = sd_ble_gap_adv_set_configure(&m_adv_handle, &m_adv_data_ext, &adv_params);
        APP_ERROR_CHECK(err_code);

        #ifdef DEBUG
        printf("Advertising at 125kbps CODED\r\n");
        #endif

    }//tx_rate == BLE_GAP_PHY_CODED

    err_code = sd_ble_gap_tx_power_set(BLE_GAP_TX_POWER_ROLE_ADV, m_adv_handle, tx_power);
    APP_ERROR_CHECK(err_code);

    #ifdef DEBUG
    printf("advertising_init\r\n");
    #endif
}

RE: Enabling 2MBPS and CODED PHYs

Hung Bui — Thu, 02 Jan 2020 13:33:13 GMT

Hi Adam,
This code worked for me:

static void advertising_init(void)
{
    ret_code_t    err_code;
    ble_advdata_t advdata;
    ble_advdata_t srdata;

    ble_uuid_t adv_uuids[] = {{LBS_UUID_SERVICE, m_lbs.uuid_type}};

    // Build and set advertising data.
    memset(&advdata, 0, sizeof(advdata));

    advdata.name_type          = BLE_ADVDATA_FULL_NAME;
    advdata.include_appearance = true;
    advdata.flags              = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;


    memset(&srdata, 0, sizeof(srdata));
    /*srdata.uuids_complete.uuid_cnt = sizeof(adv_uuids) / sizeof(adv_uuids[0]);
    srdata.uuids_complete.p_uuids  = adv_uuids;*/

    err_code = ble_advdata_encode(&advdata, m_adv_data.adv_data.p_data, &m_adv_data.adv_data.len);
    APP_ERROR_CHECK(err_code);

    err_code = ble_advdata_encode(&srdata, m_adv_data.scan_rsp_data.p_data, &m_adv_data.scan_rsp_data.len);
    APP_ERROR_CHECK(err_code);

    ble_gap_adv_params_t adv_params;

    // Set advertising parameters.
    memset(&adv_params, 0, sizeof(adv_params));

    adv_params.primary_phy     = BLE_GAP_PHY_CODED;
    adv_params.secondary_phy   = BLE_GAP_PHY_CODED;
    adv_params.duration        = APP_ADV_DURATION;
    adv_params.properties.type = BLE_GAP_ADV_TYPE_EXTENDED_CONNECTABLE_NONSCANNABLE_UNDIRECTED;
    adv_params.p_peer_addr     = NULL;
    adv_params.filter_policy   = BLE_GAP_ADV_FP_ANY;
    adv_params.interval        = APP_ADV_INTERVAL;

    err_code = sd_ble_gap_adv_set_configure(&m_adv_handle, &m_adv_data, &adv_params);
    APP_ERROR_CHECK(err_code);
}

Make sure the srdata is empty. Extended advertising doesn't support scan response packet (which makes sense since it transfer extra data in the data channels)

To switch between PHY when in connection, please follow the sequence chart here: infocenter.nordicsemi.com/.../group___b_l_e___g_a_p___p_e_r_i_p_h_e_r_a_l___p_h_y___u_p_d_a_t_e.html

RE: Enabling 2MBPS and CODED PHYs

Adam Gerken — Mon, 30 Dec 2019 17:21:23 GMT

Honestly, I'm not too worried about 2MBPS, but coded is going to be really nice to have in the final application.

Switching up to 2MBPS at run time would be good.

RE: Enabling 2MBPS and CODED PHYs

Adam Gerken — Mon, 30 Dec 2019 16:25:09 GMT

Hung, The errors are all over the place depending on how I set up the ble_gap_adv_data_t variables. I get DATA_SIZE and INVALID_PARAM.

I've read that over and over and for some reason it doesn't simply work. I've copied the code out of the example and it doesn't work. Everything in that example seems to be slightly different than the blinky example my project is originally based on.

So, how do I change the speed during the connection? I want to give the user/application the option to enable CODED/2MBPS if they want. Advertising and connecting in 1MBPS then changing seems fine, but it would also be great to be able to advertise/connect in CODED.

RE: Enabling 2MBPS and CODED PHYs

Hung Bui — Mon, 30 Dec 2019 16:07:21 GMT

Hi Adam,

Could you tell which exact error code do you have and on which function?

Have you had a look at this blog which has the example code ? https://devzone.nordicsemi.com/nordic/nordic-blog/b/blog/posts/testing-long-range-coded-phy-with-nordic-solution-it-simply-works-922075585

Please be aware that, the PHY change can happens when the devices are in connection. So for 2Mbps most of the device will just advertise in 1Mbps first and then switch to 2Mbps after the connection is established (because not many phones scan in 2Mbps).