Ndef library: multiple records update issue

RE: Ndef library: multiple records update issue

lyris — Mon, 23 Mar 2020 10:28:18 GMT

Forgot to put static buffer in load functions

RE: Ndef library: multiple records update issue

Einar Thorsrud — Wed, 18 Mar 2020 14:55:13 GMT

Hi Lyris,

I am sorry for the delay. It is a puzzle. Adding some logging for the FDS_EVT_UPDATE and FDS_EVT_WRITE events I see it is often missing, but I don't understand why. I am sure there is a perfectly reasonable root cause for what is happening, but no progress so far, unfortunately.

Einar

RE: Ndef library: multiple records update issue

lyris — Tue, 17 Mar 2020 14:08:33 GMT

Hi,

any update on this topic ?

Br,

lyris

RE: Ndef library: multiple records update issue

Einar Thorsrud — Thu, 12 Mar 2020 10:20:23 GMT

Hi,

Your example clearly demonstrates an issue, but I have yet not been able to understand what causes this behavior. I am adding the log from your unmodified example here for my own reference. I will look more into this and get back to you.

<info> app_timer: RTC: initialized.
<info> app: BLE Thread template example started.
<info> app: Thread version   : OPENTHREAD/20180926-01143-g8a1992e2; NRF52840; Dec 10 2019 22:48:00
<info> app: Network name     : OpenThread
<info> app: Thread interface has been enabled.
<info> app: 802.15.4 Channel : 11
<info> app: 802.15.4 PAN ID  : 0xABCD
<info> app: Radio mode       : rx-on-when-idle
<info> app: Fast advertising.
<info> app: LOADING FLASH at counter = 1
<info> flash_memory: NDEF file record <info> app: State changed! Flags: 0x009C13A5 Current role: 4

<info> app: bar8        = 0xFF
<info> app: bar16       = 0xFFFF
<info> app: bar8_array  = 0xFFFFFFFFFFFF

<info> app: LOADING FLASH at counter = 120
<info> flash_memory: Found NDEF file record for id 0
<info> flash_memory: Found NDEF file record for id 1
<info> flash_memory: Found NDEF file record for id 2
<info> app: bar8        = 0xB
<info> app: bar16       = 0xB5B
<info> app: bar8_array  = 0xFFFFFFFFFFFF

<info> app: NOW UPDATING FLASH
<info> flash_memory: bar8 update
<info> flash_memory: bar16 update
<info> flash_memory: bar8_array update
<info> app: LOADING FLASH at counter = 280
<info> flash_memory: Found NDEF file record for id 0
<info> flash_memory: Found NDEF file record for id 1
<info> flash_memory: Found NDEF file record for id 2
<info> app: bar8        = 0x11
<info> app: bar16       = 0x1111
<info> app: bar8_array  = 0x111111111111

Br,

Einar

RE: Ndef library: multiple records update issue

lyris — Wed, 11 Mar 2020 08:58:10 GMT

It is version nRF5_SDK_for_Thread_and_Zigbee_v4.0.0_dc7186b

To test, run the code with ses and watch the NRF_LOG_INFO outputs. I have put some commentary to hopefully guide you in the code.devzone.nordicsemi.com/.../ble_5F00_thread_5F00_dyn_5F00_template-_2D00_-flash-test.zip

RE: Ndef library: multiple records update issue

Einar Thorsrud — Tue, 10 Mar 2020 13:48:48 GMT

Hi,

That is excellent. Can you upload it to this thread? Which Thread and Zigbee SDK version does it work with? What is the procedure to test it to reproduce the issue?

RE: Ndef library: multiple records update issue

lyris — Tue, 10 Mar 2020 13:33:28 GMT

hello, I have made a complete example that reproduces the problem.

It was done using the sdk thread and zigbee and can be put in $(sdk_source)/example/multiprotocol/nle_thread

RE: Ndef library: multiple records update issue

Einar Thorsrud — Thu, 13 Feb 2020 14:59:18 GMT

I fail to see the logic. Can you make a simple (but complete) that reproduces this that I can test?

RE: Ndef library: multiple records update issue

lyris — Wed, 12 Feb 2020 15:41:55 GMT

1. In an init function called once before the main loop, you load the data stored in flash. If the records are already there, then they are loaded, otherwise a default value is written in flash with value 0xFF * size of the data.

2. Now let's say that the memory was empty, now we have 3 records like this in memory:

uint8_t data1 = 0xff;
uint16_t data2 = 0xffff;
uint8_t data_array[3] = {0xff,0xff,0xff};

3. I want to update data1:

static buffer_for_data1[1];

data1 = 0x69;

buffer_for_data1[0] = data1;
ndef_file_update(buffer_for_data1, 1, record_id_of_data1);

4. if I load data1 I get the correct value:

data1 = 0;

uint8_t load_buffer[1];

rc = ndef_file_load(load_buffer, 1, record_id_of_data1);

data1 = load_buffer[0]; // now we get data1 = 0x69 which is correct

5. If I now load data2 and data_array, I get a wrong value:

// loading data2 and data_array:

data2 = 0x0434; // wrong! expecting 0xFFFF
data_array = 0x043412 // wrong! expecting 0xFFFFFF

6. If I update data2 and data_array, every thing is fine, no more error.

RE: Ndef library: multiple records update issue

Einar Thorsrud — Wed, 12 Feb 2020 13:46:28 GMT

Hi,

I do not see anything problematic in the code snippet. Your ndef_file_update() only modifies the element given by "id" of m_record_desc and m_record, and fds_record_update() will not change any other record. The only thing it will do is write a new record with the same key and file ID as the old (but with new content), and mark the old as dirty. Existing records will not be touched, and will remain in the same flash location until garbage collection is performed.

Can you make a more complete example that demonstrates the issue that I can run on a DK on my side?

RE: Ndef library: multiple records update issue

lyris — Wed, 12 Feb 2020 08:16:26 GMT

I have updated my post with the code. Hope it helps

RE: Ndef library: multiple records update issue

Einar Thorsrud — Tue, 11 Feb 2020 14:23:38 GMT

Hi,

I am having problems getting a full understanding. Can you elaborate a bit, and perhaps show us your code?