FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

Einar Thorsrud — Wed, 27 May 2020 11:42:31 GMT

Hi,

I will forward the suggestion to the SDK developers so that they can consider it for a future release.

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

radionoise — Tue, 26 May 2020 18:36:45 GMT

Can we have some dummy function in nrf_sdh_soc.c which will be called in fds_init() if softdevice is present to introduce some compile-time check?

This will save many hours of debugging for developers in future.

If it’s not possible, maybe we can have a warning in FDS documentation which clearly says that this file should be added to build and in some circumstances it can be thrown out by linker and handler will not be called?

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

Einar Thorsrud — Tue, 26 May 2020 17:56:03 GMT

Hi,

[quote user="radionoise"]The problem is that if I remove it, the build still goes smoothly but the handler is not invoked.[/quote]

Ah yes, my bad. This is due to the exotic nature of the section variables. I don't see any way you could get a compile-time warning about this since all is done by linker "magic".

[quote user="radionoise"]Can you please tell the place where it is being called?[/quote]

It is registered in the end of the nrf_sdh_soc.c by using the NRF_SDH_STACK_OBSERVER macro, which adds this to a section variable by the linker. This section variable (sdh_stack_observers) holds a list over event handlers to be called, and all handlers are called from the loop in nrf_sdh_evts_poll() in components\softdevice\common\nrf_sdh.c.

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

radionoise — Tue, 26 May 2020 15:01:26 GMT

Same happens when I do not compile SDK as a library. I'm including nrf_sdh_soc.c directly as any other source file in my build. The problem is that if I remove it, the build still goes smoothly but the handler is not invoked. I tried to search the usages of nrf_sdh_soc_evts_poll() function in SDK and I cannot see any invocations. So there is no reason for the linker to complain that this function is referenced but not implemented. Can you please tell the place where it is being called?

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

Einar Thorsrud — Tue, 26 May 2020 14:22:10 GMT

Hi,

That would have to be up to your build configuration and not something. The linker should in any case warn you that nrf_sdh_soc_evts_poll() is referenced but not implemented, and I don't know why that did not happen in your case. But as stated, we do not support building the SDK as a library, partially because of such issues.

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

radionoise — Tue, 26 May 2020 07:55:23 GMT

Can we have some compile check that nrf_sdh_soc.c was not included? It is a real pain to debug such things.

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

Einar Thorsrud — Mon, 25 May 2020 09:07:16 GMT

Hi,

Thanks for letting us know.

I don't think this constitutes a bug. It is related to how you build, and Nordic does not support nor even test building the SDK as a library.

RE: FDS event FDS_EVT_WRITE not triggered when using SDK 16.0.0 and Softdevice S132 7.0.1

radionoise — Mon, 25 May 2020 09:00:32 GMT

After some investigation it seems that nrf_sdh_soc.c file was thrown out by linker. I compile SDK files as a static library and add it as a dependency to my target. When I add nrf_sdh_soc.c directly to the target with main.c, everything is OK. Is it a bug?