Multiple value in one characteristic

RE: Multiple value in one characteristic

Karl Ylvisaker — Mon, 15 Jun 2020 13:54:30 GMT

Now I see what you mean, you have placed it next to the SES project file.
While this is preferable to my earlier guess, I would still recommend creating a separate directory to contain all your own source code, perhaps next to the main.c file, but this is just a suggestion on my part.

Please do not hesitate to ask if you should encounter any other issues or questions in the future.

Good luck with your development!

Best regards,
Karl

RE: Multiple value in one characteristic

Nats — Fri, 12 Jun 2020 14:25:24 GMT

i have actually kept it along with main file, not mixed with other folders. its in the project folder that i have shared with you.

RE: Multiple value in one characteristic

Karl Ylvisaker — Fri, 12 Jun 2020 13:33:44 GMT

Hello again,

[quote userid="83701" url="~/f/nordic-q-a/62110/multiple-value-in-one-characteristic/254731"]i followed the tutorial of https://github.com/NordicPlayground/nRF52-Bluetooth-Course. Custom BLE tutorial. Is this not from Nordic? [/quote]

Yes it is from Nordic - but be advised that all NordicPlayground repos are officially unsupported.
However, in this case that does not matter, since it is code for a tutorial.

If you see the structure of the repository from the tutorial, you will notice that the associated ble_cus.* files are both located next to the main.c file - they are not located with the other official BLE services.

Separating your custom code from the official code is good practice when working with any SDK, as @Awneil mentions. I would even argue it is the best practice, especially if you intend to work with others that are already familiar with the drivers you are modifying.

Best regards,
Karl

RE: Multiple value in one characteristic

Nats — Fri, 12 Jun 2020 12:38:10 GMT

Hey, Thank you so much, but i followed the tutorial of https://github.com/NordicPlayground/nRF52-Bluetooth-Course. Custom BLE tutorial. Is this not from Nordic?

RE: Multiple value in one characteristic

awneil — Fri, 12 Jun 2020 11:59:15 GMT

[quote userid="87869" url="~/f/nordic-q-a/62110/multiple-value-in-one-characteristic/254710"]This is of course just a suggestion[/quote]

But a very good suggestion!

And it is not specific to the Nordic SDK - this would be Good Practice with any SDK, or any other 3rd-party library, etc.

RE: Multiple value in one characteristic

Karl Ylvisaker — Fri, 12 Jun 2020 11:52:13 GMT

Taking a quick look on the code you have shared, it seems to me that the ble_cus_custom_value_update is not part of the main.c project file, which leads me to believe that you have either added it to one of the drivers already included in the SDK, or in a driver you have made yourself - but placed in a location probably close to the other drivers.

If this is the case, I would like to recommend to you that you do not make changes directly to the drivers included in the SDK(to avoid non-compatibility / breakage of the other examples or drivers).
Instead, I would suggest that you make your own copy of the driver you would like to modify, and rename it to reflect that. Ideally, you would also place your modified / custom code in a separate directory, for easy differentiation. Borrowing naming conventions from the SDK might also lead to confusion.
It will make it easier to share your project in the future, and it will avoid confusion when working with someone already familiar with the unmodified SDK code.

This is of course just a suggestion, and you may of course organize the project as you would like.

Have a great weekend!

Best regards,
Karl

RE: Multiple value in one characteristic

Karl Ylvisaker — Fri, 12 Jun 2020 11:43:46 GMT

Hello,

[quote user="Nagashree"]Thank you Karl for your guidance[/quote]

No problem at all, I am happy to help!

[quote user="Nagashree"]along with your suggestions, the attribute section also needed to be changed (the max.len) and now it works fine. [/quote]

Could you link exactly where you made the change, and how you changed it?
My apologies for overlooking this. I am happy you were able to resolve the issue!

[quote user="Nagashree"]Now, my query is, what are the corrections to be made, if i want to send a signed integer of 64 bit, instead of unsigned. [/quote]

Both uint64_t and int64_t consists of exactly 64 bit - the only difference is their range of possible numbers to represent.
As long as your central knows what to expect the approach for sending the value using the Nordic UART example is exactly the same.

Best regards,
Kar

RE: Multiple value in one characteristic

Nats — Thu, 11 Jun 2020 18:33:09 GMT

Thank you Karl for your guidance,along with your suggestions, the attribute section also needed to be changed (the max.len) and now it works fine.

Now, my query is, what are the corrections to be made, if i want to send a signed integer of 64 bit, instead of unsigned.
I have attached the project.

devzone.nordicsemi.com/.../sending-packed-data.zip

RE: Multiple value in one characteristic

Karl Ylvisaker — Wed, 10 Jun 2020 12:22:14 GMT

Hello,

Sorry for my late reply - I was out of office yesterday due to travel.

Could you show me the declaration of your m_custom_value variable?
From your description and usage I would guess it is a global uint64_t.

[quote user="Nagashree"][/quote]

I tried editing,

gatts_value.len = sizeof(uint8_t); --> gatts_value.len = sizeof(uint64_t);

It dint work.

What do you mean by "didnt work", please elaborate.
Did you receive an error when compiling, or unexpected behavior at runtime?

[quote user="Nagashree"][/quote]

So i changed only the

hvx_params.p_len = &gatts_value.len;

I do not understand exactly what you did here. You started with the code snippets you included in the comment, than you made the changes to gatts_value.len = sizeof(uint64_t) and it didnt work, so you only changed the hvx_params.p_len = &gatts_value.len?
If so, the last change wont be any different, since you reverted the change to the gatts_value.len already.

How often is your notification_timeout_handler being called?
If you could share your entire project folder(as a .zip) file, or the entire main.c file, I could gain a better understanding of what you are attempting to do, and why it is not working.

Looking forward to resolving this issue together,

Best regards,
Karl

RE: Multiple value in one characteristic

Nats — Mon, 08 Jun 2020 11:01:47 GMT

Thank you, I tried editing this as per the tutorial you had sent. But it was not working. I am using custom ble code 128 bit UUID. And the function is as below,

uint32_t ble_cus_custom_value_update(ble_cus_t * p_cus, uint8_t cust_value){
    NRF_LOG_INFO("In ble_cus_custom_value_update. \r\n"); 
     
    if (p_cus == NULL)
    {
        return NRF_ERROR_NULL;
    }

    uint32_t err_code = NRF_SUCCESS;
    ble_gatts_value_t gatts_value;

// Initialize value struct.
    memset(&gatts_value, 0, sizeof(gatts_value));

    gatts_value.len     = sizeof(uint8_t);
    gatts_value.offset  = 0;
    gatts_value.p_value = &cust_value;

    // Update database.
    err_code = sd_ble_gatts_value_set(p_cus->conn_handle,
                                        p_cus->custom_value_handles.value_handle,
                                        &gatts_value);
    if (err_code != NRF_SUCCESS)
    {
        return err_code;
    }

        // Send value if connected and notifying.
    if ((p_cus->conn_handle != BLE_CONN_HANDLE_INVALID)) 
    {
        ble_gatts_hvx_params_t hvx_params;

        memset(&hvx_params, 0, sizeof(hvx_params));

        hvx_params.handle = p_cus->custom_value_handles.value_handle;
        hvx_params.type   = BLE_GATT_HVX_NOTIFICATION;
        hvx_params.offset = gatts_value.offset;
        hvx_params.p_len  = &gatts_value.len;
        hvx_params.p_data = gatts_value.p_value;

        err_code = sd_ble_gatts_hvx(p_cus->conn_handle, &hvx_params);
        NRF_LOG_INFO("sd_ble_gatts_hvx result: %x. \r\n", err_code);
    }
        else
    {
        err_code = NRF_ERROR_INVALID_STATE;
        NRF_LOG_INFO("sd_ble_gatts_hvx result: NRF_ERROR_INVALID_STATE. \r\n"); 
    }

    return err_code;
    }

And the calling function is as below,

static void notification_timeout_handler(void * p_context)
{
    UNUSED_PARAMETER(p_context);
    ret_code_t err_code;
    
    // Increment the value of m_custom_value before notifing it.
    m_custom_value+=2;
    err_code = ble_cus_custom_value_update(&m_cus, m_custom_value);
    APP_ERROR_CHECK(err_code);
}

I tried editing,

gatts_value.len = sizeof(uint8_t); --> gatts_value.len = sizeof(uint64_t);

It dint work.

So i changed only the

hvx_params.p_len = &gatts_value.len;

as per your suggestion, but once i make the changes, i dont get any notifications.

RE: Multiple value in one characteristic

Karl Ylvisaker — Fri, 05 Jun 2020 20:25:51 GMT

Hello,

[quote user="Nagashree"]Sorry, if i wasn't clear, I'm very new to this whole concept[/quote]

No problem at all, do not worry. I did not mean to sound crass in my last reply, I just did not understand everything you were asking at first.

[quote user="Nagashree"][/quote]

With regards to Question 1 snapshot, It is was just a demo code, to explain what i meant, when i said, sending three values in the same characteristics.

(I thought of sending X and Y and Z, one after the other in this format, until the concept of packing was introduced.)

Now I understand, thank you for explaining what you meant. Indeed it sounds like packing them into one characteristic is the best method to proceed with for your application.

[quote user="Nagashree"]In regards to Question2, Is there any other reference to explain more in detail regarding sending packed data. What are the functions in which the modifications have to be made, in order to achieve sending more than 8 bits. or array.[/quote]

I suppose the easiest way to proceed would be to leave it as is, and instead just have p_len point to the length of the data you are sending in bytes. So, for sending a uint64_t, you would need to have:

uint16_t len = sizeof(uint64_t);
hvx_params.p_len = &len;

To see an example of how this can be done, you could check out the block starting on line 343 in the ble_bas.c source file.

Best regards,
Karl

RE: Multiple value in one characteristic

Nats — Fri, 05 Jun 2020 16:55:08 GMT

Sorry, if i wasn't clear, I'm very new to this whole concept. I just wanted to know, that the three points i understood were correct or not.

With regards to Question 1 snapshot, It is was just a demo code, to explain what i meant, when i said, sending three values in the same characteristics.

(I thought of sending X and Y and Z, one after the other in this format, until the concept of packing was introduced.)

In regards to Question2, Is there any other reference to explain more in detail regarding sending packed data. What are the functions in which the modifications have to be made, in order to achieve sending more than 8 bits. or array.

RE: Multiple value in one characteristic

Karl Ylvisaker — Fri, 05 Jun 2020 14:07:28 GMT

Hello,

I do not understand the format of your questions, am I to select one of the a, b, c options presented? There are also no actual question posed in "Question 1".

[quote user="Nagashree"]Question 1[/quote]

Yes, less active radio time consumes less power, this is correct.

However, you might want the characteristics to be read by the central whenever the central pleases(read characteristic) or you might want the central to be notified as soon as there is an update to the characteristics.
So it also depends on how the characteristics are configured, but in general it would cost the least power to have all the values in a single characteristic.
To reduce power consumption, you could also use the slave latency feature, combined with longer connection intervals(longer time in between each transmission). You will have to weight these possibilities against the real-time constraints of your application.

I do not know where you are going with your included screenshot in question 1, but be advised that the value is only incremented once each function call, and thus not in between each update call - if that was the intention.

[quote user="Nagashree"][/quote]

Question 2

a, b, and c is correct at least.
The changes made in d are incorrect, and you should not just change these types without looking into what they intend to contain. Please have a look at their documentation.

Best regards,
Karl

RE: Multiple value in one characteristic

Nats — Fri, 05 Jun 2020 10:20:50 GMT

Thank you so much, awneil and Karl Ylvisaker for your suggestions.

So,

Question 1

a. Sending 3 values, one after the other , through the same value and characteristics (This would consume power for all 3 transmissions)

b. Sending 3 values to 3 different characteristics (Would this also means im trying to send the data in 3 transmissions?)

c. Sending all 3 values packed would save power and could send all data in one transmission.

Kindly correct me, if I'm wrong.

------------------------------------------------------------------------------------------------------------------------------------------------------

Question 2

So, currently my code is pushing 8 bits of data . To change this to 64bits, i tried following corrections, Kindly let me know, if this is okay and if anything else has to be changed

a. change the size of custom value (main.c)

b. change the argument size and gatts_value.len (ble_cus.c)

uint32_t ble_cus_custom_value_update(ble_cus_t * p_cus, uint64_t custom_value){
    NRF_LOG_INFO("In ble_cus_custom_value_update. \r\n"); 
     
    if (p_cus == NULL)
    {
        return NRF_ERROR_NULL;
    }

    uint32_t err_code = NRF_SUCCESS;
    ble_gatts_value_t gatts_value;

// Initialize value struct.
    memset(&gatts_value, 0, sizeof(gatts_value));

    gatts_value.len     = sizeof(uint64_t);
    gatts_value.offset  = 0;
    gatts_value.p_value = &custom_value;

    // Update database.
    err_code = sd_ble_gatts_value_set(p_cus->conn_handle,
                                        p_cus->custom_value_handles.value_handle,
                                        &gatts_value);
    if (err_code != NRF_SUCCESS)
    {
        return err_code;
    }

        // Send value if connected and notifying.
    if ((p_cus->conn_handle != BLE_CONN_HANDLE_INVALID)) 
    {
        ble_gatts_hvx_params_t hvx_params;

        memset(&hvx_params, 0, sizeof(hvx_params));

        hvx_params.handle = p_cus->custom_value_handles.value_handle;
        hvx_params.type   = BLE_GATT_HVX_NOTIFICATION;
        hvx_params.offset = gatts_value.offset;
        hvx_params.p_len  = &gatts_value.len;
        hvx_params.p_data = gatts_value.p_value;

        err_code = sd_ble_gatts_hvx(p_cus->conn_handle, &hvx_params);
        NRF_LOG_INFO("sd_ble_gatts_hvx result: %x. \r\n", err_code);
    }
        else
    {
        err_code = NRF_ERROR_INVALID_STATE;
        NRF_LOG_INFO("sd_ble_gatts_hvx result: NRF_ERROR_INVALID_STATE. \r\n"); 
    }

    return err_code;
    }

c. Change the size of custom value in prototype declaration. (ble_cus.h)

d. Change the value of structure of GATT attribute value and HVx value as below (ble_gatts.h)

/**@brief GATT Attribute Value. */
typedef struct
{
  uint64_t  len;        /**< Length in bytes to be written or read. Length in bytes written or read after successful return.*/
  uint64_t  offset;     /**< Attribute value offset. */
  uint64_t  *p_value;    /**< Pointer to where value is stored or will be stored.
                             If value is stored in user memory, only the attribute length is updated when p_value == NULL.
                             Set to NULL when reading to obtain the complete length of the attribute value */
} ble_gatts_value_t;


/**@brief GATT HVx parameters. */
typedef struct
{
  uint64_t          handle;             /**< Characteristic Value Handle. */
  uint64_t           type;               /**< Indication or Notification, see @ref BLE_GATT_HVX_TYPES. */
  uint64_t          offset;             /**< Offset within the attribute value. */
  uint64_t         *p_len;              /**< Length in bytes to be written, length in bytes written after return. */
  uint64_t const    *p_data;             /**< Actual data content, use NULL to use the current attribute value. */
} ble_gatts_hvx_params_t;

RE: Multiple value in one characteristic

awneil — Thu, 04 Jun 2020 07:59:16 GMT

The definition of a "Characteristic", from the Bluetooth SIG website, is:

"Characteristics are defined attribute types that contain a single logical value."

https://www.bluetooth.com/specifications/gatt/characteristics/

(my emphasis)

However, there's nothing to stop you having a 3-byte value - where the 1st byte represents X, the 2nd byte represents Y, and the 3rd byte represents Z

Or have a 6-byte value - where the 1st two bytes represent X, the 2nd two bytes represent Y, and the 3rd two bytes represent Z

etc, etc, ...

Or, as Karl Ylvisaker says, have a characteristic for X, and characteristic for Y, and a characteristic for Z.

See those tutorials.

EDIT

The Thingy:52 adopts the scheme of "packing" multiple values into a single Characteristic; eg, see the "Raw Data" Characteristic:

https://nordicsemiconductor.github.io/Nordic-Thingy52-FW/documentation/firmware_architecture.html#arch_motion

RE: Multiple value in one characteristic

Karl Ylvisaker — Thu, 04 Jun 2020 07:24:24 GMT

Hello,

Yes, you may use a custom service with multiple characteristics for this purpose.
Have you seen our Service tutorial, and characteristics tutorial? I highly recommend completing these tutorials in order to familiarize yourself with creating both custom services and characteristics.

Best regards,
Karl