Thread network commissionning (with Bluetooth)

RE: Thread network commissionning (with Bluetooth)

Edvin — Mon, 31 Aug 2020 11:35:43 GMT

So how did you tell the node that it should accept a new network?

I guess one approach could be something like this:

https://github.com/openthread/openthread/blob/master/src/cli/README_DATASET.md#form-network

But please let me know how you did it. Is there some way for me to reproduce this using only DKs?

RE: Thread network commissionning (with Bluetooth)

QuentinD — Mon, 24 Aug 2020 07:30:30 GMT

In fact, I want to commission one of the devices (which is on another network) to join an existing network.

RE: Thread network commissionning (with Bluetooth)

Edvin — Tue, 04 Aug 2020 07:43:53 GMT

I am not sure I follow. Are they supposed to be commissioning when they are not on the same network?

RE: Thread network commissionning (with Bluetooth)

QuentinD — Tue, 28 Jul 2020 09:10:58 GMT

Hello,

Thank you very much for your help and all this information.

I use the on-mesh commissioner because I don't have a boarder router connected to the internet, as your example shows: I only have a smartphone that can connect to the device via Bluetooth.

Now I am no longer getting errors from these functions but still have problem in certain scenarios.

For example, if I do the simple procedure like this, it works (with the "thread_cli_ftd_uart_pca10056" exemple):

But if the 2 devices were on a different network before launching the commissioning, the commissioning fails:
or

Do you have any idea why commissioning fails when the 2 devices are not on the same network?

Thank you

RE: Thread network commissionning (with Bluetooth)

Edvin — Fri, 17 Jul 2020 08:30:18 GMT

Hello,

A new reply from our Thread team:

Hello,

The commissioner API exposes on-mesh commissioner API.

Note that the on-mesh commissioner feature is optional in Thread, and does not need to be used. The normal/regular commissioning
is done using external commissioner through e.g. mobile phone: https://openthread.io/guides/border-router/external-commissioning

I do see two problems here.

The first one is incorrect API usage, and the second is the bug in OpenThread described here: https://github.com/openthread/openthread/pull/4788
which is already fixed on master.

First of all, otCommissionerStart can be called only when device has already attached
to the network. Calling this API before will return error code as in your case.

For example, you can act on state change handler for example:

switch (otThreadGetDeviceRole(p_context))
 {
 case OT_DEVICE_ROLE_CHILD:
 case OT_DEVICE_ROLE_ROUTER:
 case OT_DEVICE_ROLE_LEADER:
 {
     otError error = otCommissionerStart(thread_ot_instance_get(), commissioner_state_callback, commissioner_joiner_callback, NULL);
     ASSERT(error == OT_ERROR_NONE);
     break;
 }

Only when state of the commissioner changes to `OT_COMMISSIONER_STATE_ACTIVE` you can call

otCommissionerAddJoiner

When it comes to the side-effect of using the OpenThread libraries as is in SDK 4.1.0, as explained
in the GitHub's Pull Request. Basically if Commissioner changes the state without user intervention
e.g. from Active to Disabled (due to some network issue e.g. Keep Alives are lost) without calling
the OpenThread API it may not be possible to turn on/off the commissioner again.
This should not be a blocker with the current OpenThread libraries.

The `OT_ERROR_ALREADY` error is a little bit misleading since it is returned from Border Agent module, not the Commissioner one:
https://github.com/openthread/openthread/blob/c6a258e3a5bd90aa26d8245c435c0ae5797027f4/src/core/api/commissioner_api.cpp#L54

Anyway, I would suggest to rebuild OpenThread libraries with the following commit which includes the fix: 2f618bd4a72501a2f31e23d50a4f388b9a8c6b9b

Try this.

BR,
Edvin

RE: Thread network commissionning (with Bluetooth)

QuentinD — Wed, 15 Jul 2020 12:12:37 GMT

Hello Edvin,

I rebuiled OpenThread but unfortunately I still have the same problem ... I tested it with the example "ble_thread_dyn_mtd_coap_cli_pca10056_s140".

When I execute the "otCommissionerStart (...)" function, it returns "OT_ERROR_ALREADY" to me and then if I execute "otCommissionerAddJoiner (...)", it returns "OT_ERROR_INVALID_STATE".

And if I execute the "otCommissionerStop (...)" function before calling the "otCommissionerStart (...)" function, it returns "OT_ERROR_INVALID_STATE".

Do you have any idea when we can have a correction?
If the answer is no, is it possible to activate it by default (without having to activate it later in the application)? Or, do you have other ways to commission a new device on an existing Thread network?

Thank you

RE: Thread network commissionning (with Bluetooth)

Edvin — Tue, 14 Jul 2020 13:53:53 GMT

Hello QuentinD and HardikHarpal,

Sorry for the late reply. I pinged our Thread team, and they told me that this was apparently already a known issue, but the fix didn't make it before the SDK 4.1.0 freeze.

The fix is included in this pull request:

https://github.com/openthread/openthread/pull/4788

As far as I know, the only way to patch this is to rebuild the openthread stack with this applied.

They said that they will check if there is a possible workaround, but as of now, a rebuild is required.

Best regards,

Edvin

RE: Thread network commissionning (with Bluetooth)

QuentinD — Tue, 14 Jul 2020 09:29:26 GMT

Hi Edvin,

I've been waiting for 3 weeks: do you have any news?

Thank you

RE: Thread network commissionning (with Bluetooth)

HardikHarpal — Wed, 08 Jul 2020 02:58:13 GMT

Hi,

Sorry for hijacking this thread but I have similar issue and I want to know answer of original question of thread.

I am facing similar issue. I am using ble_thread_dyn_proximity_uart_pca10056_s140 as I want to use COAP server as commissioner. as this project included optimized FTD Open thread library by default and I want it to be a commissioner so I removed it and added FTD library. and modified code as I understand commissioning process.

When I call otCommissionerStart() it returns OT_ERROR_ALREADY and another thing is that if I call otInstanceFactoryReset(thread_ot_instance_get()); it jumps to error handler.

I am attaching my code for your review. What I want to do is commission a new device to a network.,devzone.nordicsemi.com/.../ble_5F00_thread_5F00_dyn_5F00_proximity_5F00_SR_5F00_COAP_5F00_Server.rar

Regards,

Hardik Harpal

RE: Thread network commissionning (with Bluetooth)

QuentinD — Tue, 30 Jun 2020 12:48:48 GMT

Ok I await your response.

Thank you very much for your help.

RE: Thread network commissionning (with Bluetooth)

Edvin — Tue, 30 Jun 2020 12:40:50 GMT

Hello,

I see. I also struggle with the return values of these calls. I did some other changes to the project, such as disabling autostart by setting .autostart_disable = true in thread_instance_init():

static void thread_instance_init(void)
{
    thread_configuration_t thread_configuration =
    {
        .radio_mode            = THREAD_RADIO_MODE_RX_OFF_WHEN_IDLE,
        .autocommissioning     = true,
        .poll_period           = 2500,
        .default_child_timeout = 10,
        .autostart_disable     = true
    };

    thread_init(&thread_configuration);
    thread_state_changed_callback_set(thread_state_changed_callback);
}

I see that it makes a difference if I call otCommissionerStart() or not, because it gives a different callback to thread_state_changed_callback(), but it still returns the error, and so does otCommissionerAddJoiner().

I have forwarded this to our Thread team. I'll let you know when I hear from them.

Best regards,

Edvin

RE: Thread network commissionning (with Bluetooth)

QuentinD — Mon, 29 Jun 2020 07:04:01 GMT

Hello Edvin,

Yes you can test this on the example "ble_thread_dyn_mtd_coap_cli_pca10056_s140".

For example, after initializing the thread by auto-commissioning, execute the following functions to create a new network and commission a new device:

otError error = OT_ERROR_NONE;  

//Creation of a new dataset:
error = otDatasetCreateNewNetwork(thread_ot_instance_get(), &sDataset);
ASSERT(error == OT_ERROR_NONE);

//Active the new dataset:
error = otDatasetSetActive(thread_ot_instance_get(), &sDataset);
ASSERT(error == OT_ERROR_NONE);

error = otIp6SetEnabled(thread_ot_instance_get(), true);
ASSERT(error == OT_ERROR_NONE);
error = otThreadSetEnabled(thread_ot_instance_get(), true);
ASSERT(error == OT_ERROR_NONE);

error = otCommissionerStart(thread_ot_instance_get(), NULL, NULL, thread_ot_instance_get());
ASSERT((error == OT_ERROR_NONE) || (error == OT_ERROR_ALREADY)); 

uint8_t eui64[8];  
for(int i=0; i<8; i++)
{
    eui64[i]=i;
}
error = otCommissionerAddJoiner(thread_ot_instance_get(), &eui64, "N0RD1C", 120);
ASSERT(error == OT_ERROR_NONE);

RE: Thread network commissionning (with Bluetooth)

Edvin — Fri, 26 Jun 2020 14:38:03 GMT

Hello,

Do you happen to have a project that I can run on a DK and test this on? If not, I can look into it next week, but it will be quicker if it is easily reproducible.

Best regards,

Edvin

RE: Thread network commissionning (with Bluetooth)

QuentinD — Fri, 26 Jun 2020 11:43:04 GMT

Thank you very much for all this advices.

Unfortunately, for my test I always have the same error when inverting... But that's normal, in the documentation (

https://openthread.io/reference/group/api-commissioner#otcommissioneraddjoiner), they said to start the commissioner before to add a joiner.

Do you have another idea?

Thank you

RE: Thread network commissionning (with Bluetooth)

Edvin — Fri, 26 Jun 2020 10:50:13 GMT

There is no standardized way to do it in Thread 1.1 (which is what we currently support). I believe Thread 1.2. is planned, but I don't have any details about the timeline here. In Thread 1.2. this will be part of the solution.

However, if you don't want to wait for this, then I suggest that you first try to do this without BLE, but hardcode some keys that will only allow certain devices to join, and when you have that working, then you can look into sending these keys over BLE.

I believe you have to call otCommissionerAddJoiner() before otCommissionerStart(), or alternatively call otCommissionerStop() -> otCommissionerAddJoiner() -> otCommissionerStart().

BR,
Edvin

RE: Thread network commissionning (with Bluetooth)

QuentinD — Fri, 26 Jun 2020 07:41:53 GMT

Hi Edvin,

I just wanted to know if there was a good way to commission a new device to join an existing Thread network using Bluetooth.

For example, I was thinking of doing one of the following:
- connect in Bluetooth to the new device (to add to the Thread network) and send it all the credentials of the Thread network
- or, connect in Bluetooth to a device in the Thread network and send it a command to activate the "commissioner" by providing it with the uid64 of the device to be added and its pskd. Then, I will connect in Bluetooth to the new device to activate the "joiner" to start the commissioning.

So the question is: is this a good way to do it?

I started by testing the second solution but I can't start the "Commissioner".
My application is based on the example "ble_thread_dyn_mtd_coap_cli_pca10056_s140" but when I run the function "otCommissionerStart (...)" it returns "OT_ERROR_ALREADY" (Commissioner is already started).
So I ignore this error and I run "otCommissionerAddJoiner (...)" but it returns "OT_ERROR_INVALID_STATE" (The commissioner is not active).
Do you have any idea on how to fix this problem?

Thank you

RE: Thread network commissionning (with Bluetooth)

Edvin — Wed, 24 Jun 2020 08:54:17 GMT

Hello,

As far as I know there are no standardized methods of providing the provision keys for openthread. Are you able to close the network, only allowing certain devices that contain the correct keys to join?

What I am really asking is whether this is the question, or whether the question is if we have any suggestions on how to transfer the keys over BLE.

Best regards,

Edvin