How to use nvs_read and nvs_write in aws_fota app?

RE: How to use nvs_read and nvs_write in aws_fota app?

Simon — Fri, 17 Jul 2020 10:27:54 GMT

It seems like the settings driver is used in ncs\v1.3.0\nrf\subsys\dfu\src\dfu_target_mcuboot.c, and only if CONFIG_DFU_TARGET_MCUBOOT_SAVE_PROGRESS=y. I suggest you to read about the config here, and if that is something you want. If you set it to n, I don't think you'll get any conflicts.

Best regards,

Simon

RE: How to use nvs_read and nvs_write in aws_fota app?

Yusuke — Wed, 15 Jul 2020 10:38:49 GMT

not really. Just remove the two lines and working out so far. I'm not sure this is fine or not

RE: How to use nvs_read and nvs_write in aws_fota app?

Simon — Wed, 15 Jul 2020 10:27:01 GMT

Have you made any progress on this lately?

RE: How to use nvs_read and nvs_write in aws_fota app?

Simon — Thu, 09 Jul 2020 16:13:17 GMT

I am sorry for the late reply. Currently, a huge portion of the support team is on summer vacation (including many of the nRF9160 experts), so you may experience delayed answers. I will look into your issue in the upcoming days.

Best regards,

Simon

RE: How to use nvs_read and nvs_write in aws_fota app?

Yusuke — Mon, 06 Jul 2020 03:44:36 GMT

u8_t mode = 2;
ret = nvs_write(&nvs_fs, NVS_ID_MODE, &mode, 1);
if (ret < 0) {
	return;
}

I get -22 errno in nvs_write when I add it to aws_fota.

This comes from line 179 in ncs\v1.3.0\zephyr\drivers\flash\soc_flash_nrf.c

is_regular_addr_valid(addr, len) apparently fails.

static int flash_nrf_read(struct device *dev, off_t addr,
			    void *data, size_t len)
{
	if (is_regular_addr_valid(addr, len)) { /* This fails */
		addr += DT_REG_ADDR(SOC_NV_FLASH_NODE);
	} else if (!is_uicr_addr_valid(addr, len)) {
		return -EINVAL; /* HERE */
	}

	if (!len) {
		return 0;
	}

#if CONFIG_ARM_NONSECURE_FIRMWARE && CONFIG_SPM && USE_PARTITION_MANAGER
	if (addr < PM_APP_ADDRESS) {
		return spm_request_read(data, addr, len);
	}
#endif

	memcpy(data, (void *)addr, len);

	return 0;
}

In addition, I printed out parameters.

static inline bool is_regular_addr_valid(off_t addr, size_t len)
{
	size_t flash_size = nrfx_nvmc_flash_size_get();

        printk("flash_size = %u\n", flash_size); /* ADD HERE */
        printk("addr = %ld\n", addr); /* ADD HERE */
        printk("len = %u\n", len); /* ADD HERE */

	if (addr >= flash_size ||
	    addr < 0 ||
	    len > flash_size ||
	    (addr) + len > flash_size) {
		return false;
	}

	return true;
}

* without CONFIG_SETTINGS = y

flash_size = 1048576
addr = 1028040
len = 8
flash_size = 1048576
addr = 1028048
len = 8
flash_size = 1048576
addr = 1028056
len = 8
flash_size = 1048576
addr = 1028064
len = 8
flash_size = 1048576
addr = 1028072
len = 8
flash_size = 1048576
addr = 1024004
len = 1

* with CONFIG_SETTINGS = y

flash_size = 1048576
addr = 1044464
len = 8
flash_size = 1048576
addr = 1052664
len = 8

=> errno -22 occurs

The following formula fails with CONFIG_SETTINGS = y.

(addr) + len > flash_size

Any advice to solve this issue?

RE: How to use nvs_read and nvs_write in aws_fota app?

Yusuke — Mon, 06 Jul 2020 02:51:00 GMT

Hi,

Thank you for the detail and I'm reading this page

https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/applications/nrf_desktop/doc/settings_loader.html

but I'm not really understanding the settings loader module.. The settings loader module seems to be similar to nvs library.

https://docs.zephyrproject.org/latest/reference/storage/nvs/nvs.html

>Please also make sure that you write CONFIG_SETTINGS=y, not SETTING.

oh, sorry it's typo. Yes, it's CONFIG_SETTINGS=y.

I tried aws_fota app commenting out these two lines and it apparently works out.

<prj.conf>

# CONFIG_SETTINGS=y
# CONFIG_SETTINGS_NVS=y

Do you think it is ok to remove these lines. If so, we can use nvs in aws_fota app.

RE: How to use nvs_read and nvs_write in aws_fota app?

Simonr — Wed, 01 Jul 2020 07:03:32 GMT

Hi Yusuke

The settings loader module is enabled for every nRF Desktop device with Zephyr's :ref:`zephyr:settings_api` enabled. The :ref:`zephyr:settings_api` subsystem is enabled with the :option:`CONFIG_SETTINGS` Kconfig option. Zephyr's Bluetooth stack does not load the zephyr:settings_api data on its own, as Zephyr assumes that the application will call :cpp:func:`settings_load` after completing all necessary initialization. This function is called on the settings loader module initialization.

Please also make sure that you write CONFIG_SETTINGS=y, not SETTING.

Best regards,

Simon

RE: How to use nvs_read and nvs_write in aws_fota app?

Yusuke — Tue, 30 Jun 2020 10:20:03 GMT

>Can you please specify what you mean by this?

OK. I'll explain. Please look over this zip folder. This is an app testing nvs.

When I add "CONFIG_SETTING=y" to prj.conf file, the app causes an error. That's why.

>Have you done any further debugging to see where the "Error -22" comes from and what this error means?

According to this page, it means "Invalid argument". That's only what I know.

https://github.com/intel/zephyr/blob/master/lib/libc/minimal/include/errno.h

RE: How to use nvs_read and nvs_write in aws_fota app?

Simonr — Tue, 30 Jun 2020 07:21:33 GMT

Hi again

[quote user=""][/quote]

I have inspected a while and it seems that this line in prj.conf causes the issue.

CONFIG_SETTING=y

Can you please specify what you mean by this?

Have you done any further debugging to see where the "Error -22" comes from and what this error means?

Best regards,

Simon

RE: How to use nvs_read and nvs_write in aws_fota app?

Simonr — Mon, 29 Jun 2020 13:54:18 GMT

I will have to get back to you tomorrow to provide a satisfactory answer here. Sorry about the delay! In the meantime, you can check out this, and this case. Which might be related to your implementation of NVS.

Best regards,

Simon