RE: Null pointer dereferenced in sdc_handler in SDK 17.0.0

blac01 — Thu, 09 Jul 2020 12:36:57 GMT

Hi Jørgen,

Sorry to come back late on your answer.

We’ve selected 2. as final fix. This is cleaner to us (uses the ev_handler, avoids having an early break statement, ...).

Note that we didn’t test the 1.

Best regards

Benoît

RE: Null pointer dereferenced in sdc_handler in SDK 17.0.0

Jørgen Holmefjord — Tue, 07 Jul 2020 09:51:56 GMT

Hi,

I see two possible workarounds.

Add a break; at the end of the first if statement.

case SDC_EVT_INIT:
            {
                if (p_event->result != SDC_SUCCESS)
                {
                    nrf_block_dev_t const * block_dev = &(p_sdc_dev->block_dev);
                    ret_code_t err_code = block_dev_sdc_uninit(block_dev);
                    APP_ERROR_CHECK(err_code);
                    break;
                }

                p_work->geometry.blk_count = app_sdc_info_get()->num_blocks;
                p_work->geometry.blk_size  = SDC_SECTOR_SIZE;
                if (m_active_sdc_dev->p_work->ev_handler)
                {
                    const nrf_block_dev_event_t ev = {
                            NRF_BLOCK_DEV_EVT_INIT,
                            ((p_event->result == SDC_SUCCESS) ? \
                                    NRF_BLOCK_DEV_RESULT_SUCCESS : NRF_BLOCK_DEV_RESULT_IO_ERROR),
                            NULL,
                            p_work->p_context
                    };
                    p_work->ev_handler(&p_sdc_dev->block_dev, &ev);
                }
            }
            break;

Move the first if statement after the second if statement, to allow passing the result of the init back to the event handler before uninit.

case SDC_EVT_INIT:
            {
                p_work->geometry.blk_count = app_sdc_info_get()->num_blocks;
                p_work->geometry.blk_size  = SDC_SECTOR_SIZE;
                if (m_active_sdc_dev->p_work->ev_handler)
                {
                    const nrf_block_dev_event_t ev = {
                            NRF_BLOCK_DEV_EVT_INIT,
                            ((p_event->result == SDC_SUCCESS) ? \
                                    NRF_BLOCK_DEV_RESULT_SUCCESS : NRF_BLOCK_DEV_RESULT_IO_ERROR),
                            NULL,
                            p_work->p_context
                    };
                    p_work->ev_handler(&p_sdc_dev->block_dev, &ev);
                }
                
                if (p_event->result != SDC_SUCCESS)
                {
                    nrf_block_dev_t const * block_dev = &(p_sdc_dev->block_dev);
                    ret_code_t err_code = block_dev_sdc_uninit(block_dev);
                    APP_ERROR_CHECK(err_code);
                }
            }
            break;

Best regards,
Jørgen