About missing first button release event after power up if the key is pressed during power up

RE: About missing first button release event after power up if the key is pressed during power up

Edvin — Fri, 18 Sep 2020 08:00:37 GMT

Ok. My interpretation of the bsp_event_to_button_action_assign() implementation was wrong. I missed the line:

if (event == BSP_EVENT_DEFAULT)

First of all, be careful by adding the BPS_EVENT_KEY_2_RLEASE in the middle of the bsp_evt_t enum. It changes all the events after this. Perhaps you should add it after BSP_EVENT_KEY_7, and change BSP_EVENT_KEY_LAST to the last event that you have.

The reason the first release event doesn't occur is because of this:

            case APP_BUTTON_RELEASE:
                (void)app_timer_stop(m_bsp_button_tmr);
                if (release_event_at_push[button] == m_events_list[button].release_event)
                {
                    event = m_events_list[button].release_event;
                }
                break;

Line 3 checks if the button was ever pushed before you receive the release event.

As I see it you have 3 options:

1: Quick and dirty. Comment out line 3 of that snippet.

2: Set the release_event_at_push[button 2] if button 2 is pressed at startup. This requires some modifications.

3: Use the raw app_button module, as we discussed. As mentioned, bsp_button_event_handler() is the callback function for the app_button in this case, and it receives every push and release event. Even the first release even if there were no push.

The debounce is part of the app_button, not bsp. You can either look at how the bsp uses app_button, or you can check out this guide. Note that you need to do section 2 (up and till app_timer_init(), if it is not done elsewhere in your project) before applying section 3(app_button).

BR,
Edvin

RE: About missing first button release event after power up if the key is pressed during power up

Jones — Fri, 18 Sep 2020 02:23:52 GMT

devzone.nordicsemi.com/.../bsp.h

devzone.nordicsemi.com/.../3731.bsp.c

In fact, I just added "BPS_EVENT_KEY_2_RLEASE" in the bsp_event_t.

RE: About missing first button release event after power up if the key is pressed during power up

Edvin — Thu, 17 Sep 2020 14:10:06 GMT

The debounce is part of the app_button module. The app timer that you see in bsp.c is used to separate long push from push.

My point was that bsp doesn't work with release out of the box. So if it works in your case, you must have done some changes. Is that correct? Also, BPS_EVENT_KEY_2_RLEASE is not defined by default. Where did you define it?

I don't know why the first release doesn't work if I don't know what the library you are working with looks like. Can you send me your bsp.h and bsp.c?

If you want to use the app_button directly, look at how bsp uses app_button.

Some keywords to get started:

app_button_init(), app_button_enable(), app_buttons[BUTTONS_NUMBER], and the event handler that you set in app_buttons[BUTTONS_NUMBER].button_handler.

BR,

Edvin

RE: About missing first button release event after power up if the key is pressed during power up

Jones — Thu, 17 Sep 2020 13:49:30 GMT

Hi Edvin,

Thanks for you reply.

In fact, the press and release event works in my code. Sorry I didn’t list them all out.

My problem is that the first release event is missing if the button is press while reset/power up.

By the way, if bsp is not ideal, how I can remove it and how to implement those handling on my own? I want to keep those debouncing features for a key, what software module should I use?

Thanks,

Jones

RE: About missing first button release event after power up if the key is pressed during power up

Edvin — Thu, 17 Sep 2020 12:02:04 GMT

Hello,

Have you by chance changed a few things in bsp.c/h?

The reason I ask is that BPS_EVENT_KEY_2_RLEASE is not defined (and neither is BPS_EVENT_KEY_2_RELEASE).

On top of that, bsp_event_to_button_action_assign() checks if the parameter "action" is BSP_BUTTON_ACTION_PUSH, and if it is not, it will set the event to BSP_EVENT_NOTHING, so it doesn't do anything if you use BSP_BUTTON_ACTION_RELEASE.

Actually, bsp is not ideal if you want to use all the events, because it masks away the release of buttons. Perhaps if you modify it enough, you can make it work, but then I need to know what changes you did to bsp.c/h.

Just curious: Does the release event for button #2 work for the next release events in your case?

EDIT:

I see that it is probably not too difficult to adjust it to accept release events, but let me have a look at the implementation, so I can look into why it doesn't work for the first event. An alternative is to use the app_button module, which the bsp uses below the hood. If you look at the function bsp_button_event_handler() in bsp.c, this is actually the app_button callback. The parameter button_action contains the parameter button_action, which says whther the button is pushed or released. If you debug here, you should see that the button event is probably registered. But the bsp filters out the event, because it is not set up correctly.

BR,

Edvin