Reading JEDEC ID with SPI on nrf9160

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Thu, 07 Jan 2021 10:15:51 GMT

I'm sorry for being unclear. All devices in Zephyr are added through the macro DEVICE_AND_API_INIT(), eg. for spi_nor it is done here: https://github.com/nrfconnect/sdk-zephyr/blob/3366927a54986ad0ddf060d0e08ecc578adf11f0/drivers/flash/spi_nor.c#L1042

You can see that an init function is passed to DEVICE_AND_API_INIT(), and Zephyr will gather all these init functions and run it before main() runs. It happens here: https://github.com/nrfconnect/sdk-zephyr/blob/v2.1.99-ncs1/kernel/device.c#L49-L54

Regarding the other functions inside spi_nor.c, these will not get called directly from main, but instead Zephyr will map the functions in include/drivers/flash.h to the appropriate driver, depending on what is enabled in dts and Kconfig. E.g. flash_erase() is mapped to spi_nor_erase() through:

https://github.com/nrfconnect/sdk-zephyr/blob/ff214d637e8391d94ef2c83612978aebd9cf0c57/include/drivers/flash.h#L164

https://github.com/nrfconnect/sdk-zephyr/blob/3366927a54986ad0ddf060d0e08ecc578adf11f0/drivers/flash/spi_nor.c#L965

Best regards,

Simon

RE: Reading JEDEC ID with SPI on nrf9160

verulia — Wed, 06 Jan 2021 14:14:28 GMT

Hi Simon,

Thank you for your response. I could'nt figure out what you mean by "spi_nor_init()-->spi_nor_configure()-->spi_nor_read_jedec_id()" How should I check these ?I just opened the spi_nor.c and tried to do debugging in those fuction lines but what I realized is that in my main.c , the function doesn't even go inside the spi_nor.c, so in that case how can I do the debugging in spi_nor functions I could'nt understand it properly can you help me with that ?

Best

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Tue, 05 Jan 2021 07:54:34 GMT

Can you try to do some debugging (enable CONFIG_DEBUG_OPTIMIZATIONS) and check if the init function succeeds (spi_nor_init())? As mentioned in NCS Tutorial part-3 1.3. Pitfalls the call to device_get_binding() will fail (and "SPI flash driver %s was not found" is printed) if the init function fails.

Try to check the function spi_nor_init()-->spi_nor_configure()-->spi_nor_read_jedec_id() and see if LOG_ERR("JEDEC ID read failed: %d", rc) is triggered.

Best regards,

Simon

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Thu, 24 Dec 2020 00:32:22 GMT

A huge part of the support team are currently on Christmas vacaction, and you may experience delayed answers. Most of the staff will be back by january 4th and you can expect an answer after then. My apologies for this.

Best regards,

Simon

RE: Reading JEDEC ID with SPI on nrf9160

verulia — Wed, 23 Dec 2020 11:19:54 GMT

Hi Simon,

I already found that and tried. The problem is that flash has an already existing driver I think thats the problem why it doesn't work for my case. What should I wrote these parts in the code:

#if (CONFIG_SPI_FLASH_W25QXXDV - 0)
/* NB: W25Q16DV is a JEDEC spi-nor device, but has a separate driver. */
#define FLASH_DEVICE CONFIG_SPI_FLASH_W25QXXDV_DRV_NAME
#define FLASH_NAME "W25QXXDV"

the overlay that the sample used is:

&spi3 {
        compatible = "nordic,nrf-spim";
        status = "okay";
        sck-pin = <10>;
        mosi-pin = <11>;
        miso-pin = <12>;
        cs-gpios = <&gpio0 13 0>;

        w25q32@0 {
                compatible = "winbond,w25q32", "jedec,spi-nor";
                label = "W25Q32";
                reg = <0>;
                jedec-id = [ef 40 16];
                size = <0x4000000>;
                spi-max-frequency = <1000000>;
        };
};

I tried to change the whole code acccording to my external flash which has very similar command set with spi_nor so I though that I can directly use it as my driver then I implemented the code in the following:

main.c:

/*
 * Copyright (c) 2016 Intel Corporation.
 *
 * SPDX-License-Identifier: Apache-2.0
 */

#include <zephyr.h>
#include <drivers/flash.h>
#include <device.h>
#include <devicetree.h>
#include <stdio.h>
#include <string.h>

#if (CONFIG_SPI_FLASH_W25N01GV - 0)
/* NB: W25Q16DV is a JEDEC spi-nor device, but has a separate driver. */
#define FLASH_DEVICE CONFIG_SPI_FLASH_W25N01GV_DRV_NAME
#define FLASH_NAME "W25N01GV"
#elif (CONFIG_SPI_NOR - 0) ||				\
	DT_NODE_HAS_STATUS(DT_INST(0, jedec_spi_nor), okay)
#define FLASH_DEVICE DT_LABEL(DT_INST(0, jedec_spi_nor))
#define FLASH_NAME "JEDEC SPI-NOR"
#elif (CONFIG_NORDIC_QSPI_NOR - 0) || \
	DT_NODE_HAS_STATUS(DT_INST(0, nordic_qspi_nor), okay)
#define FLASH_DEVICE DT_LABEL(DT_INST(0, nordic_qspi_nor))
#define FLASH_NAME "JEDEC QSPI-NOR"
#else
#error Unsupported flash driver
#endif

#if defined(CONFIG_BOARD_ADAFRUIT_FEATHER_STM32F405)
#define FLASH_TEST_REGION_OFFSET 0xf000
#else
#define FLASH_TEST_REGION_OFFSET 0xff000
#endif
#define FLASH_SECTOR_SIZE        4096




void main(void)
{
	const uint8_t expected[] = { 0x55, 0xaa, 0x66, 0x99 };
	const size_t len = sizeof(expected);
	uint8_t buf[sizeof(expected)];
	const struct device *flash_dev;
	int rc;

	printf("\n" FLASH_NAME " SPI flash testing\n");
	printf("==========================\n");

	flash_dev = device_get_binding(FLASH_DEVICE);

	if (!flash_dev) {
		printf("SPI flash driver %s was not found!\n",
		       FLASH_DEVICE);
		return;
	}

	/* Write protection needs to be disabled before each write or
	 * erase, since the flash component turns on write protection
	 * automatically after completion of write and erase
	 * operations.
	 */
	printf("\nTest 1: Flash erase\n");
	flash_write_protection_set(flash_dev, false);

	rc = flash_erase(flash_dev, FLASH_TEST_REGION_OFFSET,
			 FLASH_SECTOR_SIZE);
	if (rc != 0) {
		printf("Flash erase failed! %d\n", rc);
	} else {
		printf("Flash erase succeeded!\n");
	}

	printf("\nTest 2: Flash write\n");
	flash_write_protection_set(flash_dev, false);

	printf("Attempting to write %u bytes\n", len);
	rc = flash_write(flash_dev, FLASH_TEST_REGION_OFFSET, expected, len);
	if (rc != 0) {
		printf("Flash write failed! %d\n", rc);
		return;
	}

	memset(buf, 0, len);
	rc = flash_read(flash_dev, FLASH_TEST_REGION_OFFSET, buf, len);
	if (rc != 0) {
		printf("Flash read failed! %d\n", rc);
		return;
	}

	if (memcmp(expected, buf, len) == 0) {
		printf("Data read matches data written. Good!!\n");
	} else {
		const uint8_t *wp = expected;
		const uint8_t *rp = buf;
		const uint8_t *rpe = rp + len;

		printf("Data read does not match data written!!\n");
		while (rp < rpe) {
			printf("%08x wrote %02x read %02x %s\n",
			       (uint32_t)(FLASH_TEST_REGION_OFFSET + (rp - buf)),
			       *wp, *rp, (*rp == *wp) ? "match" : "MISMATCH");
			++rp;
			++wp;
		}
	}
}

overlay:

&spi3 {
compatible = "nordic,nrf-spim";
status = "okay";
sck-pin = <10>;
mosi-pin = <11>;
miso-pin = <12>;
cs-gpios = <&gpio0 13 0>;

w25n01gv@0 {
//compatible = "winbond,w25q32", "jedec,spi-nor";
compatible = "jedec,spi-nor";
label = "W25N01GV";
reg = <0>;
jedec-id = [ef AA 21];
size = <0x4000000>;
spi-max-frequency = <4000000>;
};
};

proj.conf

CONFIG_STDOUT_CONSOLE=y
CONFIG_FLASH=y
CONFIG_SPI=y
CONFIG_SPI_NOR=y

In the output it says that:

Can you guide me please what I am missing?

Thank you for the help so much

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Wed, 23 Dec 2020 10:41:33 GMT

Check out this ticket, where a customer was able to read the JEDEC ID. The sample used is also attached in that ticket.

Best regards,

Simon

RE: Reading JEDEC ID with SPI on nrf9160

verulia — Thu, 17 Dec 2020 12:18:14 GMT

This is what I am seeing on logic analyzer with my initial code(without removing cpol):

This is what I am seeing after I remove cpol:

RE: Reading JEDEC ID with SPI on nrf9160

verulia — Thu, 17 Dec 2020 12:04:04 GMT

Hi Simon,

I tried your last advice but then I always received 0.

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Thu, 17 Dec 2020 02:10:11 GMT

Could you test your initial code with SPI_MODE_CPOL removed from spi_cfg = {.operation...

Best regards,

Simon

RE: Reading JEDEC ID with SPI on nrf9160

verulia — Mon, 14 Dec 2020 08:46:07 GMT

Hi Simon,

Thank you so much for this detailed answer, that's so helpful but I couldn't understand some parts. You said that "Try setting them manually, it seems like it's " for cs pin. Do you mean should I have to delete the part above

struct device * gpio_dev;
struct spi_cs_control cs_control;

gpio_dev = device_get_binding("GPIO_0");
if (!gpio_dev) {
  printk("could not find GPIO device\n");
  return;
}
cs_control.delay = 0;
cs_control.gpio_dev = gpio_dev;
cs_control.gpio_pin = 13;
spi_cfg.cs = & cs_control;

and add only "cs-gpios = <&gpio0 13 0>;" to the overlay file?

And for the other parts in these links

I didn't understand it clearly, where should I have to add these parts? Inside the main.c?

Thank you so much

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Sun, 13 Dec 2020 21:43:04 GMT

Could you try to do the following:

Set up the CS pin in the overlay file like done here:
- https://github.com/nrfconnect/sdk-nrf/blob/3062b87b5f3bba095d7bf3948cacbe43708aa8b0/boards/arm/nrf52840gmouse_nrf52840/nrf52840gmouse_nrf52840.dts#L64
- Try setting them manually, it seems like it's
Set these as you've done before
- https://github.com/nrfconnect/sdk-zephyr/blob/3c41201293627ba3208e40de06ab117355fabe57/drivers/flash/spi_nor.c#L843-L845
- In the code provided, it will get the DTS definitions from the jedec_spi_nor sub-node. You don't have this sub-node in your overlay file, so you have the set these manually
Set the rest of the spi_cfg fields like done here:
- https://github.com/nrfconnect/sdk-zephyr/blob/3c41201293627ba3208e40de06ab117355fabe57/drivers/flash/spi_nor.c#L847-L858
- This will get the fields from the SPI node you added in the overlay file
Read the Jedec ID like done here:

Could you upload an image of the logic analyzer output?

Do you see that CS pin go from high to low?

Could you try to attach the logic analyzer to the SPI pins when you're running the loopback (when everything works) code as well? Just to make sure you are actually able to read the signals properly.

Best regards,

Simon

RE: Reading JEDEC ID with SPI on nrf9160

Simon — Sun, 13 Dec 2020 13:24:59 GMT

I modified your ticket by placing all the code snippets into code-containers (click on Insert-->Code) to make it more readable, I hope you don't mind. I'll look into your issue and see if I can get to the bottom of it.

Best regards,

Simon