How to enable Minimum Block Request ?

RE: How to enable Minimum Block Request ?

Edvin — Thu, 15 Apr 2021 09:44:50 GMT

[quote user="luck_king"]Is the following part your advice to me?[/quote]

No. I wanted to make sure that you didn't do that. you need to set it in the initialization, before the zboss stack is started.

[quote user="luck_king"](However, this parameter does not cause any change during OTA[/quote]

What is your OTA server? Is it sending packets faster than the min_block_reques? Or is it perhaps already slow enough that this doesn't affect the speed?

Again, I am sorry for the late reply. I have been out of office (vacation), and I will be on a leave a week from now. I will reassign this ticket before I go on that leave, if it is not yet solved.

I believe the OTA server in nrfutil is slower than 30ms per packet. Are you using the nrfutil OTA server to send the firmware upgrade?

If not, what are you using? And are you sure that this device is following the specification? Does it work with other devices that has set the minimum block request?

Best regards,

Edvin

RE: How to enable Minimum Block Request ?

Jiuping Li — Wed, 07 Apr 2021 05:34:42 GMT

I've been looking forward to your reply for a long time. I'm very glad to receive it today. Please let's continue with this question, OK?The following is my revised part(However, this parameter does not cause any change during OTA):

static void ota_client_attr_init(void)
{
    /* Basic cluster attributes data */
    m_dev_ctx.basic_attr.zcl_version  = ZB_ZCL_VERSION;
    m_dev_ctx.basic_attr.power_source = ZB_ZCL_BASIC_POWER_SOURCE_UNKNOWN;

    /* OTA cluster attributes data */
    zb_ieee_addr_t addr = ZB_ZCL_OTA_UPGRADE_SERVER_DEF_VALUE;
    ZB_MEMCPY(m_dev_ctx.ota_attr.upgrade_server, addr, sizeof(zb_ieee_addr_t));
    m_dev_ctx.ota_attr.file_offset = ZB_ZCL_OTA_UPGRADE_FILE_OFFSET_DEF_VALUE;
    m_dev_ctx.ota_attr.file_version = s_dfu_settings.app_version;
    m_dev_ctx.ota_attr.stack_version = ZB_ZCL_OTA_UPGRADE_FILE_HEADER_STACK_PRO;
    m_dev_ctx.ota_attr.downloaded_file_ver  = ZB_ZCL_OTA_UPGRADE_DOWNLOADED_FILE_VERSION_DEF_VALUE;
    m_dev_ctx.ota_attr.downloaded_stack_ver = ZB_ZCL_OTA_UPGRADE_DOWNLOADED_STACK_DEF_VALUE;
    m_dev_ctx.ota_attr.image_status = ZB_ZCL_OTA_UPGRADE_IMAGE_STATUS_DEF_VALUE;
    m_dev_ctx.ota_attr.manufacturer = OTA_UPGRADE_TEST_MANUFACTURER;
    m_dev_ctx.ota_attr.image_type = OTA_UPGRADE_TEST_IMAGE_TYPE;
    m_dev_ctx.ota_attr.min_block_reque = 30;//here ...^_^
    m_dev_ctx.ota_attr.image_stamp = ZB_ZCL_OTA_UPGRADE_IMAGE_STAMP_MIN_VALUE;
}

Is the following part your advice to me? I don't quite understand. I just want to confirm with you

/* Initialize Periodic OTA server discovery */
    err_code = zb_zcl_ota_upgrade_client_with_periodical_discovery_init(&m_discovery_ctx, &m_ota_server_discovery_timer, OTA_ENDPOINT);
    APP_ERROR_CHECK(err_code);

    zb_err_code = zboss_start_no_autostart();
    ZB_ERROR_CHECK(zb_err_code);
    
    m_dev_ctx.ota_attr.min_block_reque = 60;    //<-- This line has no effect.

RE: How to enable Minimum Block Request ?

Edvin — Tue, 06 Apr 2021 13:30:37 GMT

Things get a bit messy when we reply to comments that are not the latest one, so I'll reply in this one, so it is the one on the bottom.

I am sorry you feel that way. I am truly trying to help, and trust me, if I knew how to solve this with a one-liner, I would tell you.

[quote user="Edvin Holmseth"]Do you do it inside ota_client_attr_init()? Or somewhere else?[/quote]

The reason I asked this is because I don't know where you are trying to adjust this parameter. Is it inside ota_client_attr_init(), and is ota_client_attr_init() called before you start the zboss stack (zboss_start_no_autostart())? I needed to ask this because I don't know what modifications you have done to the application. If I do this, it wouldn't have any effect (see bottom line)

...
static void ota_client_attr_init(void)
{
    /* Basic cluster attributes data */
    m_dev_ctx.basic_attr.zcl_version  = ZB_ZCL_VERSION;
    m_dev_ctx.basic_attr.power_source = ZB_ZCL_BASIC_POWER_SOURCE_UNKNOWN;

    /* OTA cluster attributes data */
    zb_ieee_addr_t addr = ZB_ZCL_OTA_UPGRADE_SERVER_DEF_VALUE;
    ZB_MEMCPY(m_dev_ctx.ota_attr.upgrade_server, addr, sizeof(zb_ieee_addr_t));
    m_dev_ctx.ota_attr.file_offset = ZB_ZCL_OTA_UPGRADE_FILE_OFFSET_DEF_VALUE;
    m_dev_ctx.ota_attr.file_version = s_dfu_settings.app_version;
    m_dev_ctx.ota_attr.stack_version = ZB_ZCL_OTA_UPGRADE_FILE_HEADER_STACK_PRO;
    m_dev_ctx.ota_attr.downloaded_file_ver  = ZB_ZCL_OTA_UPGRADE_DOWNLOADED_FILE_VERSION_DEF_VALUE;
    m_dev_ctx.ota_attr.downloaded_stack_ver = ZB_ZCL_OTA_UPGRADE_DOWNLOADED_STACK_DEF_VALUE;
    m_dev_ctx.ota_attr.image_status = ZB_ZCL_OTA_UPGRADE_IMAGE_STATUS_DEF_VALUE;
    m_dev_ctx.ota_attr.manufacturer = OTA_UPGRADE_TEST_MANUFACTURER;
    m_dev_ctx.ota_attr.image_type = OTA_UPGRADE_TEST_IMAGE_TYPE;
    m_dev_ctx.ota_attr.min_block_reque = 0;
    m_dev_ctx.ota_attr.image_stamp = ZB_ZCL_OTA_UPGRADE_IMAGE_STAMP_MIN_VALUE;
}
...
int main(void)
{
    zb_ret_t       zb_err_code;
    zb_ieee_addr_t ieee_addr;
    ret_code_t     err_code;

    /* Initialize timers, logging and LEDs */
    timers_init();
    log_init();
    bsp_board_init(BSP_INIT_LEDS);

    /* Set Zigbee stack logging level and traffic dump subsystem. */
    ZB_SET_TRACE_LEVEL(ZIGBEE_TRACE_LEVEL);
    ZB_SET_TRACE_MASK(ZIGBEE_TRACE_MASK);
    ZB_SET_TRAF_DUMP_OFF();

    /* Initialize the Zigbee DFU Transport */
    zb_dfu_init(OTA_ENDPOINT);

    /* Initialize the attributes */
    ota_client_attr_init();

    /* Initialize Zigbee stack. */
    ZB_INIT("ota_client");

    /* Set device address to the value read from FICR registers. */
    zb_osif_get_ieee_eui64(ieee_addr);
    zb_set_long_address(ieee_addr);

    /* Set static long IEEE address. */
    zb_set_network_router_role(IEEE_CHANNEL_MASK);
    zb_set_max_children(MAX_CHILDREN);
    zigbee_erase_persistent_storage(ERASE_PERSISTENT_CONFIG);
    zb_set_keepalive_timeout(ZB_MILLISECONDS_TO_BEACON_INTERVAL(3000));

    /* Register OTA Client device context (endpoints). */
    ZB_AF_REGISTER_DEVICE_CTX(&ota_upgrade_client_ctx);

    /* Register callback for handling ZCL commands. */
    ZB_ZCL_REGISTER_DEVICE_CB(zcl_device_cb);

    /* Initialize Periodic OTA server discovery */
    err_code = zb_zcl_ota_upgrade_client_with_periodical_discovery_init(&m_discovery_ctx, &m_ota_server_discovery_timer, OTA_ENDPOINT);
    APP_ERROR_CHECK(err_code);

    zb_err_code = zboss_start_no_autostart();
    ZB_ERROR_CHECK(zb_err_code);
    
    m_dev_ctx.ota_attr.min_block_reque = 60;    //<-- This line has no effect.

[quote user="luck_king"]

m_dev_ctx.ota_attr.min_block_reque = 60; /m_dev_ctx.ota_attr.min_block_reque = 300;

[/quote]

Out of curiousity, do you see any difference between 0 and 60? 0 and 300? Did you see my comment regarding the ZB_CONFIG_APS_DUPS_TABLE_SIZE ?

The reason I ask these simple questions is that I don't have any way to measure this myself, while apparently you have. I am sorry, but that means I rely on you to do some work and testing as well.

RE: How to enable Minimum Block Request ?

Jiuping Li — Tue, 06 Apr 2021 01:37:01 GMT

nRF5_SDK_for_Thread_and_Zigbee_v4.1.0_32ce5f8/examples/zigbee/ota/client/pca10056

I made the following changes:

m_dev_ctx.ota_attr.min_block_reque = 60; /m_dev_ctx.ota_attr.min_block_reque = 300;

But ‘’MinimunBlockPeriod‘’ has not changed

Do you have a solution to this problem? Or do you not understand my proposition?

RE: How to enable Minimum Block Request ?

Jiuping Li — Tue, 06 Apr 2021 01:34:43 GMT

Do you have a solution to this problem? Or do you not understand my proposition?

RE: How to enable Minimum Block Request ?

Jiuping Li — Thu, 01 Apr 2021 01:43:31 GMT

Hi,

do you understand my question?

I feel that your reply is very casual, just to complete a reply, regardless of whether the answer is really related to my question?

RE: How to enable Minimum Block Request ?

Jiuping Li — Wed, 31 Mar 2021 09:29:26 GMT

yes,nRF5_SDK_for_Thread_and_Zigbee_v4.1.0_32ce5f8/examples/zigbee/ota/client/pca10056

RE: How to enable Minimum Block Request ?

Edvin — Tue, 30 Mar 2021 07:05:13 GMT

Do you do it inside ota_client_attr_init()? Or somewhere else?

RE: How to enable Minimum Block Request ?

Jiuping Li — Tue, 30 Mar 2021 06:18:23 GMT

I made the following changes:

m_dev_ctx.ota_attr.min_block_reque = 60; /m_dev_ctx.ota_attr.min_block_reque = 300;

But ‘’MinimunBlockPeriod‘’ has not changed

RE: How to enable Minimum Block Request ?

Edvin — Thu, 25 Mar 2021 12:37:20 GMT

How/where do you modify it?

Do you do it directly in ota_client_attr_init()? Or do you try to modify it runtime?

RE: How to enable Minimum Block Request ?

Jiuping Li — Thu, 25 Mar 2021 05:51:02 GMT

Hi,

I did a lot of tests, no matter how I modified m_dev_ctx.ota_attr.min_block_reque, but cannot modify MinimunBlockPeriod? I feel this parameter is fixed. Do you have any method to modify it?

RE: How to enable Minimum Block Request ?

Edvin — Thu, 04 Mar 2021 23:44:47 GMT

According to the specification, the MinimumBlockPeriod is an uint16_t, ranging from 0x0000 - 0xfffe, and is a value given in milliseconds. I have not tested this myself, but I imagine it is the minimum time between each transfer block. 0 basically means disabled.

Our team also mentioned that "the value of this attribute is limited by the ability of the OTA client to check for APS duplicates. In order to get the faster transmission, we have increased the APS duplicate table size using the dynamic memory configuration feature:

https://github.com/nrfconnect/sdk-nrf/blob/da055eb52272c04e5f702806cc6f9cddaef9b1de/samples/zigbee/light_switch/include/zb_mem_config_custom.h#L44

Which is set in zb_mem_config_med.h, depending on which of the definitions that are defined:

ZB_CONFIG_APPLICATION_COMPLEX --> #define ZB_CONFIG_APS_DUPS_TABLE_SIZE 32

ZB_CONFIG_APPLICATION_MODERATE --> #define ZB_CONFIG_APS_DUPS_TABLE_SIZE 16

ZB_CONFIG_APPLICATION_SIMPLE --> #define ZB_CONFIG_APS_DUPS_TABLE_SIZE 8

I am not sure exactly how these relate, but it looks like if you want a faster transfer (lower minimumBlockPeriod), you need to increase this value. Probably because it needs to keep more packets in the memory that it needs to check whether or not is a duplicate.

So try treating this as a millisecond variable, and see how it is affecting the nrfutil DFU server that is used in the test description from the link in my previous reply.

Best regards,

Edvin

RE: How to enable Minimum Block Request ?

Jiuping Li — Thu, 04 Mar 2021 22:47:01 GMT

Thank you for your patient reply. I see this parameter, which is usually set to 0. But when I want to set it to other parameters, I can't find the detailed description of this parameter. Do you know the detailed description of this parameter?

RE: How to enable Minimum Block Request ?

Edvin — Thu, 04 Mar 2021 22:41:50 GMT

Hello,

Sorry for the late reply.

If you look at the ZB_ZCL_DECLARE_OTA_UPGRADE_ATTRIB_LIST declaration, you can see that it actually contains the min_block_reque parameters, which is the minimum block request attribute.

In ota_client_attr_init() it sets this parameter to 0,but you can change it during initialization by modifying this, or later during runtime.

The DFU client that we use in our tests, based on nrfutil should respect this parameter, so it should be fairly easy to experiment with this.

Check out the SDK\examples\zigbee\ota example, with the test description in the link above, and play around with the min_block_reque parameter.

Best regards,

Edvin

RE: How to enable Minimum Block Request ?

Jiuping Li — Wed, 03 Mar 2021 02:07:36 GMT

I also think that the current DFU transmission speed is relatively slow, but customers insist on such a controllable function, and the schemes they use support it. What's the status of your discussion with your team?

RE: How to enable Minimum Block Request ?

Edvin — Mon, 01 Mar 2021 10:53:35 GMT

I see. I will check with our Zigbee team if we have implemented this attribute, or if it needs to be done from scratch. Alternatively, if there is any other way to control the speed of which the DFU packets are being sent. I don't know what throughput your (the customer's) network is facing, but as you are probably aware, there should be retransmission on lost packets (in attributes where it is enabled). But you are seeing a difference when the DFU packets are being transmittet? (I thought they were already transmittet through a fairly slow speed).

RE: How to enable Minimum Block Request ?

Jiuping Li — Mon, 01 Mar 2021 07:14:35 GMT

Minimum block request sets the packet polling rate for the end device. This is a requirement for devices on zigbee network. The coordinator does set how many simultaneous updates at a single time, but does not control how fast the end device asks for OTA packets, which is why the minimum block request is needed.

RE: How to enable Minimum Block Request ?

Jiuping Li — Sun, 28 Feb 2021 22:58:38 GMT

nRF5_SDK_for_Thread_and_Zigbee_v4.1.0_32ce5f8/examples/zigbee/ota/client/pca10056,Our customers have such a request

RE: How to enable Minimum Block Request ?

Edvin — Fri, 26 Feb 2021 07:49:31 GMT

Hello,

I have not noticed that attribute before. I don't think it is used in any examples. What SDK version are you using? (NCS or nRF5 SDK? And what release version?)

BR,
Edvin