Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Wed, 02 Jun 2021 14:26:29 GMT

As long as you do not need scanf for floats, you should be fine without the option.

Though I am not sure what your best option would be if you need float support.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Aidanv — Wed, 02 Jun 2021 12:24:14 GMT

Hi Didrik.

Thank you, it seems to be working on Dan's side now (harder for me to test on this side due to my location).

We initially were going to use scanf for the binary to hex conversion. I know that we did test without the CONFIG_NEWLIB_LIBC_FLOAT_SCANF but it's possible that there were issues with the build not being cleaned first or something.

What would we do if we did need to use scanf? Slightly concerning that such a simple change could cause such an obscure problem.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Tue, 01 Jun 2021 14:54:35 GMT

Yes, it looks like CONFIG_NEWLIB_LIBC_FLOAT_SCANF is the culprit.

Why did you add it? It doesn't look like you are using scanf in your project.

If I remove the option, I am no longer able to reproduce the crash in your code.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Mon, 31 May 2021 19:31:30 GMT

Quick update: I am able to reproduce the crash with just changes to prj.conf.

My current suspect is CONFIG_NEWLIB_LIBC_FLOAT_SCANF, but I'll keep working on this tomorrow.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Aidanv — Mon, 31 May 2021 11:01:38 GMT

Thank you Didrik. That is correct. It only occurs on GPS lock.
If I recall correctly, even if we do not reference our added source code (sms and pdu) it still crashes.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Fri, 28 May 2021 16:55:17 GMT

Thanks.

I am able to reproduce the crash, though it seems to be dependent on the GPS. If the device doesn't get GPS fixes, I don't see the crashes.

Other than that I haven't been able to make much more progress in identifying the cause of the crash, but I will keep investigating.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Aidanv — Thu, 27 May 2021 15:59:00 GMT

Hi Didrik,

I sent you the application in a private message.

Thanks

Aidan

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Thu, 27 May 2021 14:35:14 GMT

Hello, and sorry for the late answer.

Unfortunately, it doesn't look like your application is attached to the ticket any longer.

Could you re-upload it, or send it to me in a direct message, so I can take a look at it?

Best regards,

Didrik

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Aidanv — Tue, 25 May 2021 14:53:31 GMT

Hi Didrik

I'm working with Dan on this project. Thank you for assisting us with this issue.

The problem is that we simply add SMS functionality and PDU decoding to the original Asset Tracker v2 example. This is causing stack overflows. The fact that every time Dan has increased the stack size has merely delayed the issue implies a deeper issue.

It's not clear how our code could cause this issue as the functions we have added are not even called at this point (only when an SMS is received). The overflow occurs during normal out-of-the-box functionality of asset tracker v2.

We're new to Zephyr, and we're just trying make what should be a simple modification to the example. Please can you review the small amount of code that we've added to see if we have done something obviously wrong?

Thank you

Aidan

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

danimalia — Fri, 21 May 2021 21:09:16 GMT

Hi Didrik

Thanks, I increased the buffer size to 4096 - it helped, but still overflows; just takes longer now.

If you could please test on your side - after a few GPS locks it always overflows. We did not add much code, only the SMS and PDU libraries. What do you suggest we make the buffer?

Thanks
Dan

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Fri, 21 May 2021 14:31:04 GMT

I haven't had time to test your application yet. Is there anything in paraticular you want me to try?

The log shows that the stack overflow comes from the data_module thread.

You can set it's stack size with CONFIG_DATA_THREAD_STACK_SIZE. The default is 2048.

The data_module also has a lot of other buffers. To see what options exists for controlling their sizes, you can take a look at asset_tracker_v2/src/modules/Kconfig.data_module.

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

danimalia — Thu, 20 May 2021 15:27:04 GMT

Hi Didrik

Thanks for the reply. I added confid_thread_name=y to the prj.conf, see attached log.

Also, are you able to run the firmware I originally attached and verify the issue on your side?

Kind regards

Dandevzone.nordicsemi.com/.../2021_2D00_05_2D00_20T15_5F00_23_5F00_00.914Z_2D00_log.txt devzone.nordicsemi.com/.../6175.prj.conf

RE: Stack overflow after GPS when integrating SMS and PDU libraries (based on asset tracker v2)

Didrik Rokhaug — Thu, 20 May 2021 14:41:42 GMT

Hi,

Do you know which thread the stack overflow comes from?

Setting CONFIG_THREAD_NAME=y in your prj.conf might be a good place to start.

If you are using SES, remember that you must re-open the project, or use 'Project -> Run CMake...' for changes in your prj.conf to be included.

Best regards,

Didrik