Not able to allocate UART receive buffer

RE: Not able to allocate UART receive buffer

JONATHAN LL — Fri, 18 Jun 2021 13:33:14 GMT

Have you followed the guide her for testing; https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/samples/bluetooth/peripheral_uart/README.html#testing

What terminal are you using?

It works for me, i have tested on a nrf5340 DK v0.11.0

Could you try to du a update of the NCS repository?

Using the "west update" command?

Regards,
Jonathan

RE: Not able to allocate UART receive buffer

Turbo J — Fri, 18 Jun 2021 10:08:06 GMT

If have to reverse my statement here - the code is just too hard to understand.

While "buf" goes out of scope, it it reinstaded via macro after the UART RX handler runs. Very confusing, and not part of OP submission either. PLEASE DON'T SUBMIT CODE AS IMAGE, EVER!

RE: Not able to allocate UART receive buffer

zhouhaifang — Fri, 18 Jun 2021 10:07:59 GMT

neither using ncs1.5.0 nor using ncs1.5.1 ,peripheral_uart sample uart code is the same .i use nrf5340dk and ncs1.5.1 ,encount this situation and spending several days to resolve,but have no result . you show three same code,do not understand what's your meaning.

I have re-unzip my ncs1.5.0(former run well), sample peripheral_uart code i do not change a char, but when debug ,log information pop out "Not able to allocate UART receive buffer". maybe i should re-mount may computer operating system???

RE: Not able to allocate UART receive buffer

JONATHAN LL — Fri, 18 Jun 2021 09:41:05 GMT

Hi,

What version of the nrf53 are you using, are you on a DK that is earlier then 0.11.0 ?

Here is the different places where the its used

https://github.com/nrfconnect/sdk-nrf/blob/a18b84ef0c7231291ca718b5876af50ed33b7923/samples/bluetooth/peripheral_uart/src/main.c#L137
https://github.com/nrfconnect/sdk-nrf/blob/a18b84ef0c7231291ca718b5876af50ed33b7923/samples/bluetooth/peripheral_uart/src/main.c#L153

https://github.com/nrfconnect/sdk-nrf/blob/a18b84ef0c7231291ca718b5876af50ed33b7923/samples/bluetooth/peripheral_uart/src/main.c#L194

Did it work in NCS 1.5.0 for you?

Regards,
Jonathan

RE: Not able to allocate UART receive buffer

zhouhaifang — Thu, 17 Jun 2021 13:24:25 GMT

in ncs1.5.0,there is two samples use this way to deal with uart receive event , in sample peripheral_uart function void uart_cb(xxxx) ,there are two place like below code:

struct uart_data_t *buf

buf = k_malloc(sizeof(*buf));
if (buf) {
buf->len = 0;
} else {
LOG_WRN("Not able to allocate UART receive buffer");
k_delayed_work_submit(&uart_work,UART_WAIT_FOR_BUF_DELAY);

}

when using nrf5340 debug ,every encount this situation . program all run to else branching ，not run to if branching

NORDIC code style is difficult than all other chip manufacture code style ,nordic code always turn a thousand turns,very difficult to understand .a mini change always mean many error.i declare

static struct uart_data_t *buf

a globle variable of in main.c , and delete all code as below:

buf = k_malloc(sizeof(*buf));
if (buf) {
buf->len = 0;
} else {
LOG_WRN("Not able to allocate UART receive buffer");

but can not work well .

i do not change a word of sample peripherart_uart in NCS1.5.0 !!!

RE: Not able to allocate UART receive buffer

Turbo J — Thu, 17 Jun 2021 09:59:13 GMT

Heap overflow. The pointer "buf" goes out-of-scope without the corresponding "k_free" call.