Small bugs found in the Dimming server example

RE: Small bugs found in the Dimming server example

tesc — Tue, 13 Jul 2021 06:09:49 GMT

Hi,

Yes, you are right, generic level should be a signed value. According to the Mesh Model specification v. 1.0.1, section 3.1.2 Generic Level: "The Generic Level state is a 16-bit signed integer (2's complement) representing the state of an element."

Definitely a bug. Thanks!

Regards,
Terje

RE: Small bugs found in the Dimming server example

Jeffe — Mon, 12 Jul 2021 18:37:27 GMT

I can't see how the level is ever supposed to be an unsigned value because the delta level, like the set level and move level, is also represented by a signed type (int32_t to be specific). The generic level model seems to define all the level values as a signed integer

To clarify what I find odd, here is a picture of the output (no fixes, just the original dimming examples)

The top rtt output is the client and the bottom rtt output is the server

You can see that the set command in the client side is the target level is the correct signed type but in the server output it is the unsigned version. For example, in the last input from the client where it sets the target level from -20000 to -30000, on the server side it outputs the target level as 35536. I think its clear that its a mistake due to the uint16_t argument from the transition callback casting a signed int16_t input as its argument to a uint16. In this case it turns -30000 to 35536, but those two numbers exact same representation in binary which is indicative of a signed -> unsigned casting.

RE: Small bugs found in the Dimming server example

tesc — Mon, 12 Jul 2021 17:43:36 GMT

Hi,

Thank you for the reports, it is highly appreciated!

The first issue might be a bug, yes. I have reported it through our internal issue tracker. I agree the inconsistency looks out of place. Please note, however, that while the callbacks for set and get are used also for deltas (meaning both positive and negative values might apply), the transition target_level is an absolute value. Are you sure the level itself is not actually supposed to be an unsigned value?

Regards,
Terje

RE: Small bugs found in the Dimming server example

Jeffe — Fri, 09 Jul 2021 16:43:43 GMT

Update: THe second bug is not actually a bug, its just that i was dumb and forgot to set publishing for the server and subscribing for the client (the other way). I have crossed it out in the main post