GPIO port definition in devicetree

RE: GPIO port definition in devicetree

Sigurd — Fri, 20 Aug 2021 12:39:49 GMT

[quote user="Dmitry Kr"]Is it a right way to use regulator_enable API function?[/quote]

Looking at the description of sys_notify_init_callback: ,

 * On completion of the operation the client object must be
 * reinitialized before it can be re-used.

it seems like the client object must be reinitialized, yes.

RE: GPIO port definition in devicetree

Dmitry Kr — Wed, 18 Aug 2021 17:34:28 GMT

Hi Sigurd,

Checking that code: https://github.com/nrfconnect/sdk-zephyr/blob/e4f87fba1b8785dcdcd1a3872e592bd7f7b53039/tests/lib/onoff/src/main.c

I've found that there was reset_client() function called before the every call to regulator_enable().

That reset_client() function clears onoff_client structure and reinstalls callback binding.

Is it a right way to use regulator_enable API function?

RE: GPIO port definition in devicetree

Sigurd — Tue, 17 Aug 2021 08:25:46 GMT

Hi,

I think this means that you have not registered a callback with sys_notify_init_callback()

RE: GPIO port definition in devicetree

Dmitry Kr — Fri, 13 Aug 2021 21:13:47 GMT

Hi, Sigurd,

yes,

* regulator_enable() returns -EINVAL (-22)

* regulator_disable() returns -134

RE: GPIO port definition in devicetree

Sigurd — Fri, 13 Aug 2021 10:05:34 GMT

Hi,

[quote user="Dmitry Kr"]Is there any things to check why the regulator_xxx functions don't work?[/quote]

Did the function call return any errors?

RE: GPIO port definition in devicetree

Dmitry Kr — Wed, 11 Aug 2021 19:23:44 GMT

Hi, Sigurd,

Many thanks for the recommendation.

I've added regulator element in DTS file:

pwr_sf: sensor-flash-supply {
/* Power regulator for sensors & flash mem */
compatible = "regulator-fixed";
label = "sensor-flash-supply";
regulator-name = "sensor-flash-supply";
enable-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
/* startup-delay-us = <1000>; -- uncomment this to specify the startup time delay */
off-on-delay-us = <1000>; /* 600 us for TPS706xx */
/* regulator-boot-on; -- uncomment this to enable the regulator in bootloader mode */
/* regulator-always-on; -- uncomment this to enable the regulator unconditionally */
};

Still, the code (regulator_enable, _disable) doen't work completely (the commented lines has been replaced by direct gpio_pin_set to check if GPIO initialization was done properly). Is there any things to check why the regulator_xxx functions don't work?

const struct device *pwr_sf_dev;
const struct device *pwr_gpio;
struct onoff_client onoff_cli = {};

#define REGULATOR_NODE DT_NODELABEL(pwr_sf)

#define BOOT_ON DT_PROP(REGULATOR_NODE, regulator_boot_on)
#define ALWAYS_ON DT_PROP(REGULATOR_NODE, regulator_always_on)
#define STARTUP_DELAY_US DT_PROP(REGULATOR_NODE, startup_delay_us)
#define OFF_ON_DELAY_US DT_PROP(REGULATOR_NODE, off_on_delay_us)

int pwrct_sf_init()
{
//!!! move to boards.c
pwr_sf_dev = device_get_binding(DT_LABEL(REGULATOR_NODE));
if (pwr_sf_dev == NULL) {
return -ENODEV;
}

/* Set power control pin as output */
pwr_gpio = device_get_binding(DT_GPIO_LABEL(REGULATOR_NODE, enable_gpios));
if (pwr_gpio == NULL) {
return -ENODEV;
}
int ret = gpio_pin_configure(pwr_gpio, DT_GPIO_PIN(REGULATOR_NODE, enable_gpios), GPIO_OUTPUT_INACTIVE | DT_GPIO_FLAGS(REGULATOR_NODE, enable_gpios));

printk("Regulator: %s%s\n", IS_ENABLED(BOOT_ON) ? ", boot-on" : "", IS_ENABLED(ALWAYS_ON) ? ", always-on" : "");
printk("startup-delay: %u us\n", STARTUP_DELAY_US);
printk("off-on-delay: %u us\n", OFF_ON_DELAY_US);

return ret;
}

void pwrct_sf_on()
{
gpio_pin_set(pwr_gpio, DT_GPIO_PIN(REGULATOR_NODE, enable_gpios), 1);
//regulator_enable(pwr_sf_dev, &onoff_cli);
}

void pwrct_sf_off()
{
gpio_pin_set(pwr_gpio, DT_GPIO_PIN(REGULATOR_NODE, enable_gpios), 0);
//regulator_disable(pwr_sf_dev);
}

RE: GPIO port definition in devicetree

Sigurd — Mon, 09 Aug 2021 13:45:13 GMT

Hi,

There are several ways to do this, but typically you create some sort of board.c file where you do the board specific initialization.

Take a look at these files to see how it can be done:

Thingy:91 , https://github.com/nrfconnect/sdk-nrf/blob/master/boards/arm/thingy91_nrf9160/board_secure.c#L16

Thingy:53, https://github.com/nrfconnect/sdk-zephyr/blob/v2.6.0-rc1-ncs1/boards/arm/thingy53_nrf5340/board.c#L85

Thingy:52, https://github.com/nrfconnect/sdk-zephyr/blob/v2.6.0-rc1-ncs1/boards/arm/thingy52_nrf52832/board.c