Including specific sensor header files

RE: Including specific sensor header files

Sigurd — Fri, 10 Sep 2021 11:19:18 GMT

I'm not able to reproduce this.

Could you upload a small sample that reproduces this? (If you have done changes to Zephyr, add those files as well.)

RE: Including specific sensor header files

Aleksa — Wed, 01 Sep 2021 13:48:30 GMT

I have tried to make my own driver(because I feel that the sensor API is way too limited for these two sensors). I don't want to edit the zephyr unless I really have to(makes it harder to update ncs versions if I just edit it whenever I don't like how it works). For example in the adxl372.c there is a adxl372_bus_access() function, that extracts some configuration and in the end calls:

return spi_transceive(adxl372_data->bus, &adxl372_data->spi_cfg, &tx, &rx);

When I try to make the same function in my own code, it says spi_cfg is not a part of the struct adxl372_data. But it definitely has to be a part of it, since I've set CONFIG_ADXL372_SPI=y. Same happens with the lis2dh, where it doesn't allow access to the spi part of the configuration.

PS: Before I've tried accessing these fields that depend on whether or not the sensor is used via spi, my code did build too. Could you please try accessing them too?

RE: Including specific sensor header files

Sigurd — Wed, 01 Sep 2021 13:19:23 GMT

So far I'm not able to reproduce this.

Testing with asset_tracker_v2. I modified thingy91_nrf9160ns.overlay so it looks like this:

/*
 * Copyright (c) 2021 Nordic Semiconductor ASA
 *
 * SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
 */

/ {
        aliases {
                temp-sensor = &bme680;
                humidity-sensor = &bme680;
                accelerometer = &adxl362;
        };
};

&i2c2 {
        bme680: bme680@76 {};
};

&spi3 {
        adxl362: adxl362@0 {};
        
        lis2dh@2 {
                compatible = "st,lis2dh";
                label = "LIS2DH";
                spi-max-frequency = <8000000>;
                reg = <0>;
                irq-gpios = <&gpio0 9 0>;
        };
};

I added this to CMakeLists.txt :
zephyr_include_directories(${ZEPHYR_BASE}/drivers/sensor/lis2dh)

and added

#include <lis2dh.h>

to main.c, it compiled without any warnings or errors.

RE: Including specific sensor header files

Aleksa — Tue, 31 Aug 2021 16:25:18 GMT

Actually I've posted the wrong output, but I use spi3 now and the issue is still the same.

RE: Including specific sensor header files

Sigurd — Tue, 31 Aug 2021 15:42:30 GMT

[quote user="Aleksa"]I've changed to the spi3, [/quote]

Could you use and upload that file instead? The one you are using now is still using spi0

RE: Including specific sensor header files

Aleksa — Tue, 31 Aug 2021 15:24:44 GMT

devzone.nordicsemi.com/.../8345.CMakeLists.txt devzone.nordicsemi.com/.../0815.zephyr.dts

Here are the two files. Here is ther error message(we use some build script to set things up for cmake before running it).

<MY_PATH>/bsp_sensor.c:122:53: error: 'const union lis2dh_bus_cfg' has no member named 'spi_cfg'
  122 |     const struct spi_config *spi_cfg = &cfg->bus_cfg.spi_cfg->spi_conf;
      |                                                     ^
<MY_PATH>/bsp_sensor.c: In function 'bsp_sensor_lis3dh_spi_read':
<MY_PATH>/bsp_sensor.c:159:53: error: 'const union lis2dh_bus_cfg' has no member named 'spi_cfg'
  159 |     const struct spi_config *spi_cfg = &cfg->bus_cfg.spi_cfg->spi_conf;

RE: Including specific sensor header files

Sigurd — Tue, 31 Aug 2021 12:52:24 GMT

[quote user="Aleksa"]By the way is the reason why you suggested this because the pins I use are pins of the spi3 or is it something else?[/quote]

Yes, It's what the default thingy91 board is configured for. See this: https://github.com/nrfconnect/sdk-nrf/blob/master/boards/arm/thingy91_nrf9160/thingy91_nrf9160_common.dts#L128

+ also if you are using uart0, then you cannot use spi0 at the same time, since they share the same memory ID/address: https://infocenter.nordicsemi.com/topic/ps_nrf9160/memory.html#topic

[quote user="Aleksa"]Is this zephyr.dts a final output of the overlay and the default dts files?[/quote]

Yes, correct. Can you upload it ? and your CMakeLists.txt file ?

Also, if there are other spi devices on spi3, you should use a unique device instance number for lis2dh, change

lis2dh@0 {
compatible = "st,lis2dh";
label = "LIS2DH";
spi-max-frequency = <8000000>;
reg = <0>;
irq-gpios = <&gpio0 9 0>;
};

lis2dh@2 {
compatible = "st,lis2dh";
label = "LIS2DH";
spi-max-frequency = <8000000>;
reg = <0>;
irq-gpios = <&gpio0 9 0>;
};

RE: Including specific sensor header files

Aleksa — Mon, 30 Aug 2021 12:18:39 GMT

Hi Sigurd,

I've changed to the spi3, it didn't help. By the way is the reason why you suggested this because the pins I use are pins of the spi3 or is it something else?

Yes I do have lis2dh device in the zephyr.dts. Is this zephyr.dts a final output of the overlay and the default dts files?

Cheers,

Aleksa

RE: Including specific sensor header files

Sigurd — Mon, 30 Aug 2021 11:20:38 GMT

Hi,

Are you sure the overlay is being applied? Check if you have the lis2dh device in build_folder/zephyr/zephyr.dts

And for the overlay, don't use spi0, use spi3 instead.

RE: Including specific sensor header files

Aleksa — Mon, 30 Aug 2021 08:02:49 GMT

Additionally, CMakeLists.txt in both lis2dh and adxl372 don't use the zephyr_include_directories command, which makes it harder to include them any other way. I've tried adding zephyr_include_directories(.) but I still get the same error for lis2dh.