Asset Tracker V2 - BH1749 enable

RE: Asset Tracker V2 - BH1749 enable

Ales Pour — Wed, 22 Mar 2023 08:06:13 GMT

Do you please have a working solution? I'm also trying to make Asset Tracker v2 send light sensor data, but all I'm getting from the sensor are zeros for all color channels. No errors (device is ready, sample fetch - OK, channel get - OK), I just get 0s.

Thank you.

RE: Asset Tracker V2 - BH1749 enable

Luca Z — Sun, 24 Oct 2021 15:50:43 GMT

Hi Jon,

Indeed it compiles when replacing DEVICE_DEFINE by DEVICE_DT_INST_DEFINE. Any idea why ?

I can now get data from the sensor after some rework of my ext_sensors_color_x_get() functions.
So that other people don't lose time on this : calling sensor_sample_fetch_chan() will clear VALID bit in MODE_CONTROL2 register of the sensor. If same function is called again for another data, an error will be raised : "No valid data to fetch".

The right way to do it is to call once sensor_sample_fetch_chan() and then sensor_channel_get() for each data with the correct channel passed to the function. An example can be found in Asset Tracker application.

Luca

RE: Asset Tracker V2 - BH1749 enable

Jon Helge — Thu, 21 Oct 2021 21:32:26 GMT

I managed to get it to compile, but I have now idea if it actually works. I saw that the bme680 driver was using DEVICE_DT_INST_DEFINE instead of DEVICE_DEFINE that was used by bh1749. Modifiying the bh1749 driver to do it similar like the BME680 did the trick.

diff --git a/drivers/sensor/bh1749/bh1749.c b/drivers/sensor/bh1749/bh1749.c

index 86f12dfc0..703ae84dd 100644

--- a/drivers/sensor/bh1749/bh1749.c

+++ b/drivers/sensor/bh1749/bh1749.c

@@ -306,6 +306,5 @@ static const struct sensor_driver_api bh1749_driver_api = {

static struct bh1749_data bh1749_data;

-DEVICE_DEFINE(bh1749, DT_INST_LABEL(0),

- bh1749_init, NULL, &bh1749_data, NULL,

+DEVICE_DT_INST_DEFINE(0,bh1749_init, NULL, &bh1749_data, NULL,

POST_KERNEL, CONFIG_SENSOR_INIT_PRIORITY, &bh1749_driver_api);

RE: Asset Tracker V2 - BH1749 enable

Luca Z — Thu, 21 Oct 2021 20:41:06 GMT

Hi Jon,

Thanks for your reply.

I double checked and indeed the changes I described in my first message do not cause a build error. The alias is correctly binded to the structure. But the structure is not used in your case...

The 2 following changes cause the undefined reference error during build stage :

In ext_sensors_init() :

	if(!device_is_ready(red_sensor.dev)){
		LOG_ERR("Color sensor - red channel - is not ready");
		evt.type = EXT_SENSOR_EVT_COLOR_RED_ERROR;
		evt_handler(&evt);
	}

And adding this function :

int ext_sensors_color_red_get(uint16_t *ext_red)
{
	int err;
	struct sensor_value data = {0};
	struct ext_sensor_evt evt = {0};

	err = sensor_sample_fetch_chan(red_sensor.dev, SENSOR_CHAN_ALL);
	if (err) {
		LOG_ERR("Failed to fetch data from %s, error: %d",
			red_sensor.dev->name, err);
		evt.type = EXT_SENSOR_EVT_COLOR_RED_ERROR;
		evt_handler(&evt);
		return -ENODATA;
	}

	err = sensor_channel_get(red_sensor.dev, red_sensor.channel, &data);
	if (err) {
		LOG_ERR("Failed to fetch data from %s, error: %d",
			red_sensor.dev->name, err);
		evt.type = EXT_SENSOR_EVT_COLOR_RED_ERROR;
		evt_handler(&evt);
		return -ENODATA;
	}

	k_spinlock_key_t key = k_spin_lock(&(red_sensor.lock));
	*ext_red = sensor_value_to_double(&data);
	k_spin_unlock(&(red_sensor.lock), key);

	return 0;
}

Could you please try with the 2 above changes ?

And by the way I am using the SDK's tag version v1.6.1 and VS Code extension for nRF Connect SDK as development environment.

Thanks a lot,

Luca

RE: Asset Tracker V2 - BH1749 enable

Jon Helge — Thu, 21 Oct 2021 17:21:50 GMT

Strange. I just did the same on NCS master. It compiles and I get a warnings like

/Users/jhn/work/repos/ncs/nrf/applications/asset_tracker_v2/src/ext_sensors/ext_sensors.c:65:26: warning: 'green_sensor' defined but not used [-Wunused-variable]

since I am not using it for anything. Linker reports no errors. You have not done anything else to your configs?