Zigbee Multiple Endpoint declaration gives error

RE: Zigbee Multiple Endpoint declaration gives error

Stian Røed Hafskjold — Fri, 21 Jan 2022 14:25:19 GMT

Hi, sorry for the late reply. Here is the feedback from the Zigbee team here in Nordic:

ZBOSS ZCL APIs are not fully prepared to work with multiple endpoints (especially if you declare the same set of clusters on more than one endpoint).

In order to do that, you have to define a new set of defines, that will handle the variable name collisions.

We have done that in nRF5 SDK in the examples/multiprotocol/experimental/ble_zigbee_dynamic_color_light_bulb_thingy/zb_ha_dimmable_color_light.h. This header should be full of nice ideas on how to adapt the original ZCL declaration into your use case.

RE: Zigbee Multiple Endpoint declaration gives error

Manju_rn — Fri, 21 Jan 2022 10:19:41 GMT

@Nordic Team,

Please update on the above, whether the multiple endpoint definition code is correct or is there a better way to define the multiple endpoints

RE: Zigbee Multiple Endpoint declaration gives error

Manju_rn — Mon, 10 Jan 2022 10:06:06 GMT

@Nordic Team,

Please confirm that the above changes is the correct one and whether the macro is a problem? If yes, can we expect bug to be fixed in the macro?

RE: Zigbee Multiple Endpoint declaration gives error

Manju_rn — Sun, 02 Jan 2022 10:06:55 GMT

Okay I found the solution by implementing by expanding the macros, but it begs the question, why is the macro creating duplicate struct?

The problem was the Macro ZB_HA_DECLARE_DIMMABLE_LIGHT_EP was creating a duplicate struct zb_af_simple_desc_6_0_s and its instance zb_af_simple_desc_6_0_t. I just expanded this macro and change the struct naming. Maybe because it was used for creating the declaration for first Endpoint? Anyway, if Nordic can fix this macro, it will save some debugging and effort in future

// ZB_HA_DECLARE_DIMMABLE_LIGHT_EP(
// 	dimmable_light_ep_gpio,
// 	HA_DIMMABLE_LIGHT_ENDPOINT_GPIO,
// 	dimmable_light_clusters_gpio);

// Expansion of ZB_HA_DECLARE_DIMMABLE_LIGHT_EP - START
typedef ZB_PACKED_PRE struct zb_af_simple_desc_6_0_struc 
{ 
	zb_uint8_t endpoint; 
	zb_uint16_t app_profile_id; 
	zb_uint16_t app_device_id; 
	zb_bitfield_t app_device_version:4; 
	zb_bitfield_t reserved:4; 
	zb_uint8_t app_input_cluster_count; 
	zb_uint8_t app_output_cluster_count; 
	zb_uint16_t app_cluster_list[(6) + (0)]; 
} ZB_PACKED_STRUCT zb_af_simple_desc_6_0_t_instance;

ZB_AF_SIMPLE_DESC_TYPE(6, 0) simple_desc_dimmable_light_ep_gpio = 
	{ 
	  11, ZB_AF_HA_PROFILE_ID, ZB_HA_DIMMABLE_LIGHT_DEVICE_ID, ZB_HA_DEVICE_VER_DIMMABLE_LIGHT, 0, 6, 0, 
	  { 
	    ZB_ZCL_CLUSTER_ID_BASIC, ZB_ZCL_CLUSTER_ID_IDENTIFY, ZB_ZCL_CLUSTER_ID_SCENES, ZB_ZCL_CLUSTER_ID_GROUPS, ZB_ZCL_CLUSTER_ID_ON_OFF, ZB_ZCL_CLUSTER_ID_LEVEL_CONTROL, 
	  }
	};
ZBOSS_DEVICE_DECLARE_REPORTING_CTX(reporting_infodevice_ctx_name, ZB_HA_DIMMABLE_LIGHT_REPORT_ATTR_COUNT);
ZBOSS_DEVICE_DECLARE_LEVEL_CONTROL_CTX(cvc_alarm_infodevice_ctx_name, ZB_HA_DIMMABLE_LIGHT_CVC_ATTR_COUNT);
ZB_AF_DECLARE_ENDPOINT_DESC(dimmable_light_ep_gpio, HA_DIMMABLE_LIGHT_ENDPOINT_GPIO, ZB_AF_HA_PROFILE_ID, 0, NULL, ZB_ZCL_ARRAY_SIZE(dimmable_light_clusters_gpio, zb_zcl_cluster_desc_t), dimmable_light_clusters_gpio, (zb_af_simple_desc_1_1_t*)&simple_desc_dimmable_light_ep_gpio, ZB_HA_DIMMABLE_LIGHT_REPORT_ATTR_COUNT, reporting_infodevice_ctx_name, ZB_HA_DIMMABLE_LIGHT_CVC_ATTR_COUNT, cvc_alarm_infodevice_ctx_name);