NCS CAF leds modules can not receive power down event?

RE: NCS CAF leds modules can not receive power down event?

Hung Bui — Thu, 02 Nov 2023 09:58:54 GMT

@Tasos: Please create a new ticket for your question.

RE: NCS CAF leds modules can not receive power down event?

Tasos — Thu, 02 Nov 2023 08:49:42 GMT

Which is the module that controls the power managment? How can I make a module to control the power managment?

RE: NCS CAF leds modules can not receive power down event?

Hung Bui — Mon, 17 Jan 2022 12:29:19 GMT

Hi Magdalena,
I got the feedback from the developer, it seems that new_force_power_down_event() is needed, instead of the new_power_down_event(). If you have a look here you can find that power_down_event should not be used in a module that not controls the power management and it's the final subscriber to the power down event.

* Only the module that controls the power management in the application can submit the power down event. It is also the final subscriber for the power down event. When it receives the power down event, it's ensured that all other application modules that handle power down event are already suspended. Then it can continue the power down procedure.

I tried with the new_force_power_down_event() for CLICK_LONG and it seems to work. You need to include :
CONFIG_PM_POLICY_APP=y
CONFIG_CAF_POWER_MANAGER=y

RE: NCS CAF leds modules can not receive power down event?

Hung Bui — Thu, 13 Jan 2022 12:48:30 GMT

Thanks Magadalena,
I have reproduced the issue here. Looks like a bug to me. The team has started looking into this. Will keep you updated.

RE: NCS CAF leds modules can not receive power down event?

Harvey Zheng — Thu, 13 Jan 2022 01:13:58 GMT

Hi,

This is my click_dector_def.h file.

/*
 * Copyright (c) 2019 Nordic Semiconductor ASA
 *
 * SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
 */

#include <caf/click_detector.h>

/* This configuration file is included only once from click_detector module
 * and holds information about click detector configuration.
 */

/* This structure enforces the header file is included only once in the build.
 * Violating this requirement triggers a multiple definition error at link time.
 */
const struct {} click_detector_def_include_once;

static const struct click_detector_config click_detector_config[] = {
	{
		.key_id = 0,
		.consume_button_event = false,
	},
};

RE: NCS CAF leds modules can not receive power down event?

Hung Bui — Wed, 12 Jan 2022 16:40:53 GMT

Hi Magadalena,
Could you help sending your click_dector_def.h file so we can compile here ?

I have investigate a little bit and can see similar issue when testing with the button press.
But it would be nice to have the exact code as you so it's easier to debug and report to the team.

RE: NCS CAF leds modules can not receive power down event?

Harvey Zheng — Wed, 12 Jan 2022 02:56:20 GMT

These are log information of short click and long click respectively.

RE: NCS CAF leds modules can not receive power down event?

Harvey Zheng — Wed, 12 Jan 2022 02:49:07 GMT

My project is based on sample/caf : https://github.com/nrfconnect/sdk-nrf/tree/v1.8.0/samples/caf

It will also appear on 52840 DK. I add click event in sample/caf, this is the modified led_state.c file and prj.conf. You can replace them in sample/caf.

#include <zephyr.h>

#define MODULE led_state
#include <caf/events/module_state_event.h>
#include <caf/events/led_event.h>
#include <caf/events/button_event.h>
#include <caf/events/click_event.h>
#include <caf/events/power_event.h>

#include <logging/log.h>
LOG_MODULE_REGISTER(MODULE, CONFIG_CAF_SAMPLE_LED_STATE_LOG_LEVEL);

#include "led_state_def.h"


enum button_id {
	BUTTON_ID_NEXT_EFFECT,
	BUTTON_ID_NEXT_LED,

	BUTTON_ID_COUNT
};

static enum led_effect_id curr_led_effect_id[LED_ID_COUNT];
static enum led_id curr_led_id;


static void send_led_event(enum led_id led_id, const struct led_effect *led_effect)
{
	__ASSERT_NO_MSG(led_effect);
	__ASSERT_NO_MSG(led_id < LED_ID_COUNT);

	struct led_event *event = new_led_event();

	event->led_id = led_id;
	event->led_effect = led_effect;
	EVENT_SUBMIT(event);
}

static bool handle_click_event(const struct click_event *evt) {
    if (evt->key_id == 0) {
        if (evt->click == CLICK_LONG) {
            struct power_down_event *event = new_power_down_event();

            event->error = false;
            EVENT_SUBMIT(event);
        } else if (evt->click == CLICK_SHORT) {
            struct power_down_event *event = new_power_down_event();

            event->error = false;
            EVENT_SUBMIT(event);
        }
    }

    return false;
}

static bool event_handler(const struct event_header *eh)
{
    if (is_click_event(eh)) {
        return handle_click_event(cast_click_event(eh));
    }

	if (is_module_state_event(eh)) {
		const struct module_state_event *event = cast_module_state_event(eh);

		if (check_state(event, MODULE_ID(leds), MODULE_STATE_READY)) {
			/* Turn on the first LED */
			send_led_event(LED_ID_0, &led_effect_on);
		}

		return false;
	}

	/* Event not handled but subscribed. */
	__ASSERT_NO_MSG(false);

	return false;
}

EVENT_LISTENER(MODULE, event_handler);
EVENT_SUBSCRIBE(MODULE, module_state_event);
EVENT_SUBSCRIBE(MODULE, click_event);

# Dependencies for EVENT_MANAGER and CAF
CONFIG_LINKER_ORPHAN_SECTION_PLACE=y
CONFIG_HEAP_MEM_POOL_SIZE=2048

# Enable CAF_BUTTONS
CONFIG_CAF=y
CONFIG_CAF_BUTTONS=y
CONFIG_CAF_BUTTONS_POLARITY_INVERSED=y

# Dependencies for CAF_LEDS
CONFIG_LED=y
CONFIG_PWM=y
CONFIG_LED_PWM=y

# Enable CAF_LEDS
CONFIG_CAF_LEDS=y
CONFIG_CAF_LEDS_PWM=y

CONFIG_CAF_CLICK_DETECTOR=y
CONFIG_CAF_PM_EVENTS=y

# Enable logging
CONFIG_LOG=y
# Increase number of internal logging buffers
CONFIG_LOG_STRDUP_BUF_COUNT=32

# Application specific options
CONFIG_CAF_SAMPLE_LED_STATE=y

RE: NCS CAF leds modules can not receive power down event?

Harvey Zheng — Wed, 12 Jan 2022 01:49:49 GMT

Yeah, CONFIG_CAF_LEDS_PM_EVENTS is set to 1. My project only enable LEDs、BUTTON and CLICK，you can see it work normally when short click or double click. It doesn't seem to have anything to do with leds, because this kind of problem can happen if I submit power down event in click long event.

RE: NCS CAF leds modules can not receive power down event?

Hung Bui — Tue, 11 Jan 2022 15:09:13 GMT

Hi Magdalena,

Could you check if CONFIG_CAF_LEDS_PM_EVENTS is set to 1.

Could you send us the project so we can test on a DK here ?

RE: NCS CAF leds modules can not receive power down event?

Harvey Zheng — Mon, 10 Jan 2022 12:08:48 GMT

Under the same conditions, button modules can receive normally. In addition, led use GPIO mode.