Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

mohamad — Sat, 24 Jun 2023 09:20:30 GMT

thank u all guys that helping other to solve their problems, i have same problem but i can't find nrf/subsys/spm/Kconfig i use vscode with nrfconnect extention i remove systick in device tree and other rtc and solved this problem for me hope worked for someone else too

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Fri, 22 Apr 2022 19:44:55 GMT

Aleksa's solution did work for me. I have not tried Parthitce solution yet. Have not tried the Hello World example.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Elfving — Fri, 22 Apr 2022 12:51:10 GMT

Hello again, and thanks for your patience on this issue during the Easter vacation.

Did the solution presented by Aleksa and Parthitce work for you? If not, I am still unable to reproduce the issue.

Could you send me your project?

[quote user="GameCodingNinja"]I did a test where I compiled an empty main() function with all my proj.conf settings commented out and my cmakelists.txt only referencing the main.c for compile and it still errored with "multiple definition".[/quote]

So this is also the case with eg. the basic Hello World example in 1.9.1 for you?

Regards,

Elfving

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

parthitce — Wed, 20 Apr 2022 14:09:38 GMT

I faced the same problem in my application software and managed to solve it today. Here is how

- Compilation is failed for SPM, prj.conf for SPM build needs to be updated
- Add `child_image/spm/prj.conf` in your application project
- Make sure to have `CONFIG_CORTEX_M_SYSTICK=n` in it with all the basic configuration for spm (you can find the nrf-sdk mainline repo a sample prj,conf for spm)

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Wed, 13 Apr 2022 12:33:16 GMT

Your above fix did allow me to get past the point that would otherwise error. Now I would have to fix my code due to changes in 1.9.1 vs 1.7.1. Awesome!

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

John — Tue, 12 Apr 2022 09:58:07 GMT

I have the same problem

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Fri, 08 Apr 2022 13:41:43 GMT

Thank you for debugging this! I'm still cutting my teeth on Zephyr and wouldn't have even known to look there. I've been unclear as to the roll of the Kconfig file but this has shed some light on the subject.

I'll give this a try and report back.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Aleksa — Fri, 08 Apr 2022 13:30:26 GMT

I've done it directly in he nrf/subsys/spm/Kconfig. But it's not an optimal solution unless you make your own fork of the nrf repo. Even then, this is just a temporary fix.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Fri, 08 Apr 2022 13:13:15 GMT

Is the local Kconfig file how you would override settings in the Kconfig in nrf/subsys/spm?

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Aleksa — Fri, 08 Apr 2022 09:05:08 GMT

I am not sure about that. Obviously these two definitions shouldn't be allowed to be active at the same time.

File nrf/subsys/spm/Kconfig has been changed between ncs v1.6.1(from which I'm migrating) and v1.9.1.

When I build any of your samples, and I check libdrivers__timer.a for symbols, I find that these three functions are all defined in nrf_rtc_timer.c. Which means that in our case, cortex_m_systick.c shouldn't be built as a part of this library. Obviously the two CONFIGs are the issue.

What I've done as a workaround for now is to edit nrf/subsys/spm/Kconfig, so that the CORTEX_M_SYSTICK works like this:

config CORTEX_M_SYSTICK
	default n if NRF_RTC_TIMER
	default y if SPM_NRF_RTC1_NS
	help
	  Use the Cortex-M SYSTICK timer as the system clock driver since RTC1 is Non-Secure

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Elfving — Fri, 08 Apr 2022 08:18:25 GMT

Then there seems to be something wrong with the toolchain. Try reinstalling NCS 1.9.1.

Regards,

Elfving

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Thu, 07 Apr 2022 14:28:29 GMT

My project does use CONFIG_AT_CMD and CONFIG_AT_NOTIF but I did have to comment these out when trying to build under toolchain 1.9.1. Forgot to do that when posting my proj.conf file. I made that change above.

My project under 1.7.1 does build and run with CONFIG_LTE_LOG_LEVEL_DBG but it's in my autoconf.h by default.

I did a test where I compiled an empty main() function with all my proj.conf settings commented out and my cmakelists.txt only referencing the main.c for compile and it still errored with "multiple definition".

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Elfving — Thu, 07 Apr 2022 13:23:54 GMT

Hello Howard and Aleksa,

I haven't managed to reproduce your exact error message, though I do also see errors when trying to run CMake with your configurations. It seems that some of your configurations are outdated, for instance: CONFIG_AT_CMD and CONFIG_AT_NOTIF. For an overview of configurations available on different versions, you can check out the KConfig reference here. Are you getting your project to run with CONFIG_LTE_LOG_LEVEL_DBG on NCS 1.7.1?

Could you also tell me more about your project? Is it maybe based on any sample in particular, so that I can have an easier way of trying to reproduce your issues?

Regards,

Elfving

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Elfving — Tue, 05 Apr 2022 09:38:27 GMT

Hello Howard,

I will have to get back to you on this.

Regards,

Elfving

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Aleksa — Tue, 05 Apr 2022 06:53:38 GMT

I wasn't able to fix it either. Hopefully tech support comes soon.
If I find anything out, I'll contact you here.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Mon, 04 Apr 2022 14:57:14 GMT

I added CONFIG_NRF_RTC_TIMER=n to my prj.conf and it was not added to autoconf.h but it still errors with the "multiple definitions". If CONFIG_NRF_RTC_TIMER is not defined in my prj.conf, then it is added as 1. Either way it still errors for me.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Aleksa — Mon, 04 Apr 2022 14:18:45 GMT

I didn't use them either, they get auto generated. Check your autoconf.h in build output files for these conf options, I bet you'll find them defined to 1.

If you go to the: zephyr/drivers/timer/CMakeLists.txt
You will see that timer related source files that go into the project, depend on project configurations, such as these two.

And the functions that are defined multiple times for us are only declared here: zephyr/include/drivers/timer/system_timer.h

I'm pretty sure that there is some weird reason in Kconfig why these two project options now get enabled for us, instead of only CONFIG_NRF_RTC_TIMER.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

GameCodingNinja — Mon, 04 Apr 2022 13:02:54 GMT

Yeah, I'm not using those conf options. The nrf_rtc_timer.c has header files that expose the other definitions in the same file. Right now I don't understand why I can compile some things and not others. Tried to debug it but gave up because I was going to deep down the rabbit hole. The code base doesn't look like it's applying a proper standard to handle includes and this is the result.

RE: Multiple definition errors when trying to migrate code from toolchain 1.7.1 to 1.9.1

Aleksa — Mon, 04 Apr 2022 10:21:09 GMT

I have the exact same problem. Not sure what to do. I can build the nrf sample code still.

The two files that get included depend on the following Kconfig options: CONFIG_CORTEX_M_SYSTICK and CONFIG_NRF_RTC_TIMER.

I've tried setting these two options to false, but it didn't help because the build system would override my settings, and change both options to true.