Pinctrl and PWM

RE: Pinctrl and PWM

spekary — Wed, 13 Apr 2022 12:38:55 GMT

Oh, and looking at that example you mentioned, which is actually just a pwm test, I see this comment:

/* Default port should be adapted per board to fit the channel
* associated to the PWM pin. For intsance, for following device,
* pwm1: pwm {
* status = "okay";
* pinctrl-0 = <&tim1_ch3_pe13>;
* };
* the following should be used:
* #define DEFAULT_PWM_PORT 3
*/

There are a ton of ifdefs here too. In other words, even the test file is not using pinctrl to define the pwm pin, but rather testing for a specific #define and then manually setting the pin.

Again I ask, what is the point of pinctrl if you have to redefine the exact same pin elsewhere. It actually makes things worse because now you MUST define the same pin in two different places and keep them synchronized if something changes.

RE: Pinctrl and PWM

spekary — Wed, 13 Apr 2022 12:30:05 GMT

In zephyr/dts/bindings/pwm/nordic,nrf-pwm.yaml:

ch0-pin:
type: int
required: false
description: |
IMPORTANT: This option will only be used if the new pin control driver
is not enabled. It will be deprecated in the future.

Note that this phrase:

IMPORTANT: This option will only be used if the new pin control driver
is not enabled. It will be deprecated in the future.

Is in lots of other nordic yaml files. I assume the word IMPORTANT means its important NOW.

Also, when I try to define things without pinctrl, I get a warning that pinctrl is on so I MUST use it. I did not turn pinctrl on in my config file. It appears that the file nrf52840dk_nrf52840_defconfig has CONFIG_PINCTRL=y. So Nordic is essentially forcing us to use pinctrl at this point.

RE: Pinctrl and PWM

Jared — Wed, 13 Apr 2022 11:35:35 GMT

Hi there,

Where is it stated that not using pinctrl is deprecated? Maybe you could try to use DEVICE_DT_GET(PWM_DEV_NODE) as in this example?

regards

Jared