NRF5340 USB SIZE.EPOUT[n] value not stable

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

Håkon Alseth — Thu, 02 Jun 2022 13:59:24 GMT

Hi Jerzy,

I agree that it is not stated explicitly, but it is mentioned that triggering tasks within the usbd peripheral will limit access to this set of registers:

https://infocenter.nordicsemi.com/topic/ps_nrf5340/chapters/usbd/doc/usbd.html?cp=3_0_0_6_38_11#unique_1203114361

Other registers than the one's listed shall be safe to read.

Kind regards,

Håkon

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

kasjer — Wed, 01 Jun 2022 14:56:59 GMT

Thanks Håkon,

NRFX version indeed prepares whole DMA transaction (including read from SIZE.EPOUT) after previous DMA has finished.

Code could be written that way even if only restriction was: 'single EasyDMA transfer at a time'.

Currently I'm just seeking confirmation about which registers can't be accessed while DMA is in progress.

Surely some registers are not affected by running DMA but which ones can be read without problem?

best regards

Jerzy

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

Håkon Alseth — Wed, 01 Jun 2022 13:57:52 GMT

Hi Jerzy,

If you look at the nrfx_usbd driver, it has similar comments as you describe, due to the restriction in the datasheet.

If you look at the handling of this specific variable (and following functions), you'll see that its only read after a transaction is completed:

https://github.com/zephyrproject-rtos/hal_nordic/blob/master/nrfx/drivers/src/nrfx_usbd.c#L718

Kind regards,

Håkon

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

kasjer — Tue, 31 May 2022 07:06:11 GMT

Hi,

Code that fails is opensource TinyUSB.

Line that read invalid value is here

https://github.com/hathach/tinyusb/blob/f4efb51fe2b7f4fee38c28ff80d03904d0b5b73e/src/portable/nordic/nrf5x/dcd_nrf5x.c#L220

xact_len = tu_min16((uint16_t) NRF_USBD->SIZE.EPOUT[epnum], xfer->total_len - xfer->actual_len);

While this code have tu_min16 macro that potentially could read register value twice. I tried extracting register read to separate line from tu_min16 and result was the same.

As visible in code SIZE.EPOUT is first read in function from USBD registers. In case when this read fails, previous access to any register was stating DMA on some other OUT endpoint.

During investigation process I tried dumping all SIZE.EPOUT registers before DMA is started and just after is starts.

When reading all register in a loop and storing them in RAM reveled that registers had expected values before DMA was started. Specifically endpoint that had new data had correct value.

Then DMA for other endpoint was stated.

Then 8 times I read all SIZE.EPOUT registers again.

This time read content of the registers were incorrect for one or more loop, then it was correct again.

I did not verify that this loop start yielding correct values after DMA finished but that is my assumption.

TinyUSB project is open source testing code is also opensource so I could help with setup if needed.

Jerzy

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

Håkon Alseth — Mon, 30 May 2022 14:49:26 GMT

Hi,

Could you share the output that you're getting, and your routine for reading the register?

Kind regards,

Håkon

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

kasjer — Mon, 30 May 2022 09:35:17 GMT

Hi Håkon, thanks for reply

Register SIZE.EPOUT is mentioned in USB register access limitations section, but what I observe is that read of this register is in the middle of heavy USB traffic. USB is not disabled, nor suspended, it is transmitting in both direction prior to failure.

I added dummy read of from EVENTS_STARTED register before read from SIZE.EPOUT and read is still incorrect.

Code that accessed SIZE.EPOUT register did not try to read any other USBD registers just before read that failed.

Document you mentioned state that only single EasyDMA can be started at a time at that is enforced in my case but

I could not find any confirmation that while DMA is running certain registers can't be read.

Maybe it should be added to USB register access limitation section if it is really the case.

Jerzy

RE: NRF5340 USB SIZE.EPOUT[n] value not stable

Håkon Alseth — Mon, 30 May 2022 08:20:32 GMT

Hi,

In certain states, a group of registers shall not be accessed, as described here:

https://infocenter.nordicsemi.com/topic/ps_nrf5340/chapters/usbd/doc/usbd.html?cp=3_0_0_6_38_11

I do not know how your read-routine looks, but please keep this in mind:

When reading registers directly from the CPU, it is important that you add a wait-state between each read. This is because the peripheral bus runs on a lower clock speed compared to the CPU.

Pseudo code:

uint32_t reg = NRF_USBD->SOME_REG;
// Dummy read of any EVENTS_ register to generate wait-state
(void)NRF_USBD->EVENTS_STARTED;

Kind regards,

Håkon