publish and subscribe address set and get function not working

RE: publish and subscribe address set and get function not working

Michael Moser — Thu, 23 Jun 2022 06:47:11 GMT

Thanks with this function it works.

Regards,

Michael

RE: publish and subscribe address set and get function not working

tesc — Mon, 13 Jun 2022 10:49:11 GMT

Hi,

For 1, depending on how the publish address was set, there might be some internal state not being cleared up, or there might be conflict with already scheduled publications. You should consider access_model_publication_stop() for your use case, which cleans up both dsm and internal access layer state. (Removing the public address without stopping poublications may lead to other errors, but access_model_publication_stop() makes sure to put the device in a state where publicataions will not be attempted.)

Please note that for normal configuration, adding and removing publish addresses etc. is done through the configuration server model on the node, from a provisioner. Use of functions such as access_model_publish_address_set() is for when you want the device to auto-configure without the need of configuring it from a provisioner. Further, those functions are considered to be an internal API, hence why they may be difficult to use (and lead to undefined or bad states if used incorrectly.)

Regards,
Terje

RE: publish and subscribe address set and get function not working

Michael Moser — Mon, 13 Jun 2022 07:11:35 GMT

1. I don't get a error value.
When i added a publish address (eg. 0xC001) only to one model it is possible to clear the value again.
As soon as i publish the same address to different models i can't remove them anymore.

2. With your modification the problem is solved.

3. I can't reproduce the issue again. Maybe it was some mistake from my side.

regards,

Michael

RE: publish and subscribe address set and get function not working

tesc — Fri, 10 Jun 2022 13:03:19 GMT

Hi,

[quote user=""]

1.pubish set function:

I can't set the address back to 0 (unassigned).

[/quote]

What happens when you try, do you get an error value, does it silently not work, or other?

[quote user=""]2.subscribe get function
give me sometimes wrong addresses back when the address is not set 0[/quote]

I suggest initializing subscribe_address to DSM_HANDLE_INVALID before the call to access_model_subscriptions_get(), so that it will not contain a bogus value when the number of handles written by access_model_subscriptions_get() is 0, and instead of checking for DSM_HANDLE_INVALID after the call to access_model_subscriptions_get(), to check if 0 == count instead.

uint16_t common_ble_mesh_init_sub_addr_get(access_model_handle_t model)
{
	uint32_t status = NRF_SUCCESS;
	dsm_handle_t subscribe_address = DSM_HANDLE_INVALID;
	uint16_t count = 1;

    if(model == NULL)   return 0;

	status = access_model_subscriptions_get(model, &subscribe_address, &count);

	if (status || subscribe_address == DSM_HANDLE_INVALID || 0 == count)
	{
		return 0;
	}
(...)

[quote user=""]3. subscribe set function
sometimes i can't set a subscribe address[/quote]

What happens when you try, do you get an error value, does it silently not work, or other?

In general I recommend adding ERROR_CHECK() around error return values, as is done throughout the mesh SDK libraries and examples. It will call the app error handler on non-NRF_SUCCESS values, so you get the error code and location for debugging. If there are return values that you can handle programmatically or safely ignore, then check for those and use ERROR_CHECK on the value otherwise.

Regards,
Terje