Grove LCD - Grove LCD: Device not ready.

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Tue, 19 Jul 2022 12:42:37 GMT

Sorry, just found my mistake. I was comparing your code to mine I realised I made an error in the overlay file.

I had defined the group as

i2c1_default_alt: i2c1_default_alt

but then when I called it, i used

pinctrl-0 = <&i2c1_default>;

and missed off the _alt. Dooh!, my mistake, sorry.

The code is now running, It is not running as previously, the characters are jumping around and it is not running as it did in older versions, although the source code does look the same. So, Im guessing there is something else hidden in there.

I will close this now, thanks for your help and sorry again for the mistake

Rod

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Tue, 19 Jul 2022 09:01:27 GMT

Yes, it does but before I do that, I want to cross check the I2C scanner code you sent me in case I spot something in there, that may point to the problem. Its a long shot, but worth a try.

If no joy, I will open a ticket on GitHub, put link here and close this one.

Rod

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Tue, 19 Jul 2022 08:59:14 GMT

Thanks, yes this worked, I only had to add the following to my config to get serial output.

CONFIG_CONSOLE=y

But this shows all my I2C devices, thanks. I also have a BME280 and SSD1306 on the bus and I can communicate with them fine.

Rod

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Tue, 19 Jul 2022 08:16:04 GMT

Hi,

Since the Grove driver is a sample in the zephyr project, I suggest that you create an issue on their github.
This way, the problem is documented and someone can work on it.

If you do this, I can create an internal ticket in our system linking to your issue, which will increase the chances that someone works with your issue.

How does that sound to you?

Regards,
Sigurd Hellesvik

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Tue, 19 Jul 2022 07:46:57 GMT

Hi Rod,

I took an unofficial I2C scanner sample by crfosse I know worked for earlier versions of the nRF Connect SDK, and changed its overlay file to work with nrf52840dk with pinctrl, so it should work with v2.0.0.

I do not have an I2C sensor handy at the moment, so I have not tested it yet.
Can you try it first, and I will have another look at the sample if it does not work for you.

devzone.nordicsemi.com/.../1258.i2c_5F00_scanner.zip

Regards,
Sigurd Hellesvik

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Mon, 18 Jul 2022 14:28:58 GMT

Thanks Sigurd,

I will look forward to their update. As an aside, do you have a !2C scanner example that works out of the box? I found links to some examples, but nothing that seems to work with the new SDK.

Rod

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Mon, 18 Jul 2022 13:37:21 GMT

Hi Rod,

Since it seems to be an issue with the SDK, I have asked our developers if they have any advise. I will let you know when I hear from them.

Regards,
Sigurd Hellesvik

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Sat, 16 Jul 2022 12:25:38 GMT

Hi Sigurd,

I went back to v1.3.0 of the SDK and can confirm that the LCD works as expected. I wanted to double check my pinout, my pull-ups and basic connectivity were all good which this test has done. So, this confirms the hardware is all good and the something had changed in moving to v2.0.0 in the SDK.

So, Im guessing this point to a configuration error either in my overlay file or my pro file.

I changed my overlay file to use I2C1 and I explicitly disabled some other peripherals.

/ {
        chosen {
		zephyr,display = &glcd;
        };
};

&pinctrl {
	uart0_default_alt: uart0_default_alt {
		group0 {
			psels = <NRF_PSEL(UART_TX, 0, 24)>, <NRF_PSEL(UART_RX, 0, 22)>;
		};
	};

	uart0_sleep_alt: uart0_sleep_alt {
		group1 {
			psels = <NRF_PSEL(UART_TX, 0, 24)>, <NRF_PSEL(UART_RX, 0, 22)>;
			low-power-enable;
		};
	};

	i2c1_default_alt: i2c1_default_alt {
       		group2 {
          		psels = <NRF_PSEL(TWIM_SDA, 0, 17)>,
                  		<NRF_PSEL(TWIM_SCL, 0, 20)>;
       			};
    		};
};

&uart0 {
	pinctrl-0 = <&uart0_default_alt>;
	pinctrl-1 = <&uart0_sleep_alt>;	
	pinctrl-names = "default", "sleep";

	compatible = "nordic,nrf-uart";
	current-speed = <115200>;
	status = "okay";
};

&i2c1 {
	status = "okay";
	compatible = "nordic,nrf-twim";	
	pinctrl-0 = <&i2c1_default>;
	pinctrl-1 = <&i2c1_sleep>;
	pinctrl-names = "default", "sleep";
//    	clock-frequency = <I2C_BITRATE_STANDARD>;  
	clock-frequency = <I2C_BITRATE_FAST>;  
	zephyr,concat-buf-size = <520>;

	bme680@77 {
		compatible = "bosch,bme680";
		reg = <0x77>;
		label = "BME680";
	};

	glcd: glcd@3e {
		compatible = "seeed,grove-lcd-rgb";
		label = "GLCD";
		reg = <0x3e>;
	};
};

&i2c1 {
/delete-property/sda-gpios;
/delete-property/scl-gpios;
};

&uart1 {
    status = "disabled";
};

&spi0 {
    status = "disabled";
};

&spi1 {
    status = "disabled";
};

&spi2 {
    status = "disabled";
};

&spi3 {
    status = "disabled";
};

This got rid of the 0x0BAE0001 error I was seeing above but I am still seeing errors.

[00:00:00.295,135] <dbg> grove_lcd: glcd_initialize: initialize called
[00:00:00.295,166] <dbg> grove_lcd: glcd_initialize: Check if Device is Ready
[00:00:00.295,196] <dbg> grove_lcd: glcd_initialize: Device is Ready
[00:00:00.295,196] <dbg> grove_lcd: glcd_initialize: delay 50 ms while the VDD powers on
[00:00:00.845,397] <err> i2c_nrfx_twim: Error on I2C line occurred for message 0
[00:00:00.845,489] <dbg> grove_lcd: glcd_function_set: set function options, delay 5 ms
[00:00:01.350,646] <err> i2c_nrfx_twim: Error on I2C line occurred for message 0
[00:00:01.350,677] <dbg> grove_lcd: glcd_display_state_set: set display_state options, delay 5 ms

Rod

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Fri, 15 Jul 2022 10:51:03 GMT

I am pretty sure I have had this working previously on this board with an older version of the SDK which makes me this its a software config error. I will check

Rod

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Fri, 15 Jul 2022 09:19:48 GMT

The grove init function uses CONFIG_KERNEL_INIT_PRIORITY_DEVICE, so as long as I2C has higher priority than this, I guess it should be fine.

To debug your I2C errors, I suggest that you use an oscilloscope or logic analyzer to have a look at the I2C lines and see if the communication makes sense.

Also see nrfx_errors.h for error codes.

Regards,
Sigurd Hellesvik

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Fri, 15 Jul 2022 08:39:23 GMT

Hi Sigurd,

I added the following line to my config file

CONFIG_I2C_INIT_PRIORITY = 30

I tried 60 but this didn't make any difference . Any suggestions for which value I should use?

This moves it a bit further..

[00:00:00.309,020] <dbg> grove_lcd: glcd_initialize: initialize called
[00:00:00.309,051] <dbg> grove_lcd: glcd_initialize: Check if Device is Ready
[00:00:00.309,051] <dbg> grove_lcd: glcd_initialize: Device is Ready
[00:00:00.309,082] <dbg> grove_lcd: glcd_initialize: delay 50 ms while the VDD powers on
[00:00:00.359,375] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.359,436] <dbg> grove_lcd: glcd_function_set: set function options, delay 5 ms
[00:00:00.364,715] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.364,746] <dbg> grove_lcd: glcd_display_state_set: set display_state options, delay 5 ms
[00:00:00.370,025] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.370,056] <dbg> grove_lcd: glcd_clear: clear, delay 20 ms
[00:00:00.390,380] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.390,411] <dbg> grove_lcd: glcd_input_state_set: set the input_set, no delay
[00:00:00.390,441] <inf> grove_lcd: configuring the RGB background
[00:00:00.390,655] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.390,869] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.391,082] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.391,113] <dbg> grove_lcd: glcd_initialize: background set to white
[00:00:00.391,296] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.391,510] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.391,723] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.391,937] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.391,967] <dbg> grove_lcd: glcd_function_set: set function options, delay 5 ms
[00:00:00.397,308] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.397,338] <dbg> grove_lcd: glcd_display_state_set: set display_state options, delay 5 ms
[00:00:00.402,648] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0
[00:00:00.402,893] <err> i2c_nrfx_twim: Error 0x0BAE0001 occurred for message 0

Rod

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Fri, 15 Jul 2022 08:18:58 GMT

Disregard my previous comment.
It seems that you can fix the order of I2C initialization by changing CONFIG_I2C_INIT_PRIORITY.

Regards,
Sigurd Hellesvik

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Fri, 15 Jul 2022 08:05:14 GMT

Hi Rod,

Try to move

add_subdirectory(misc)

to below

add_subdirectory_ifdef(CONFIG_I2C i2c)

in zephyr/drivers/CMakeLists.txt.

Does this fix your issue?

In which case, the problem might look like a bug.

Regards,
Sigurd Hellesvik

RE: Grove LCD - Grove LCD: Device not ready.

RodWatt — Thu, 14 Jul 2022 21:16:44 GMT

Hi Sigurd,

I have enabled debug and added a couple of debug statements shown below.

static int glcd_initialize(const struct device *dev)
{
	const struct glcd_config *config = dev->config;
	uint8_t cmd;

	LOG_DBG("initialize called");

	LOG_DBG("Check if Device is Ready");

	if (!device_is_ready(config->bus.bus)) {
	LOG_DBG("Check if Device is Ready Failed");
		return -ENODEV;
	}

This is what I see

uart:~$ Grove LCD: Device not ready.

[00:00:00.311,798] <dbg> grove_lcd: glcd_initialize: initialize called
[00:00:00.311,798] <dbg> grove_lcd: glcd_initialize: Check if Device is Ready
[00:00:00.311,828] <dbg> grove_lcd: glcd_initialize: Check if Device is Ready Failed
uart:~$

Rod

RE: Grove LCD - Grove LCD: Device not ready.

Sigurd Hellesvik — Thu, 14 Jul 2022 14:09:36 GMT

Hi Rod

To debug, add the following to your prj.conf:

CONFIG_LOG=y
CONFIG_GROVE_LCD_RGB_LOG_LEVEL_DBG=y

Then you can add some custom debugging log to glcd_initialize(), which will be called automatically on startup.

I guess this function does not finish somehow, and therefore your code reports that it is not ready yet.

Regards,
Sigurd Hellesvik