NCS nRF91: using PRS after mcuboot used SPI

RE: NCS nRF91: using PRS after mcuboot used SPI

MaLu — Thu, 01 Sep 2022 05:10:12 GMT

Hi,

No worries. Since I also have a lot of other work to do, I also put this on the backburner, since I am not as well acquainted with the inner workings of the SDK/the nRF91 as you and would certainly waste more time than anything.

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Wed, 31 Aug 2022 14:04:50 GMT

Hello,

Sorry for the delay on this. Have you made any progress lately?

I will be gone until Monday, but will look into your issue then

Best regards,

Simon

RE: NCS nRF91: using PRS after mcuboot used SPI

MaLu — Tue, 23 Aug 2022 06:34:50 GMT

Hi,
at first sight this seems like it's working at first glance, but I have noticed some strange behaviour still.

I want to use the SPIM in a blocking way. When I do, then I get what seems infinite twim event handler after a twim xfer.

I have my new main.c here:

#include <zephyr.h>
#include <sys/printk.h>
#include <string.h>
#include <nrfx_twim.h>
#include <nrfx_spim.h>
#include <drivers/src/prs/nrfx_prs.h>

nrfx_twim_t sTwimInstance = NRFX_TWIM_INSTANCE(3);
nrfx_spim_t sSpimInstance = NRFX_SPIM_INSTANCE(3);
volatile nrfx_err_t eErr;

nrfx_twim_config_t sDevCfg = 
{
  .scl = 6,                
  .sda = 5,                
  .frequency = NRF_TWIM_FREQ_400K,          
  .interrupt_priority = 7, 
  .hold_bus_uninit = false 
};

nrfx_spim_config_t sDevCfgSpim = 
{
  .sck_pin        = 7,
  .mosi_pin       = 8,
  .miso_pin       = 9,
  .ss_pin         = NRFX_SPIM_PIN_NOT_USED,
  .ss_active_high = false,
  .irq_priority   = 7,
  .orc            = 0xFF,
  .frequency      = NRF_SPIM_FREQ_8M,
  .mode           = NRF_SPIM_MODE_0,
  .bit_order      = NRF_SPIM_BIT_ORDER_MSB_FIRST,
  .miso_pull      = NRF_GPIO_PIN_PULLUP,
};

uint8_t au8Data[16];

nrfx_spim_xfer_desc_t sSpiRxTxData = 
{
  .p_tx_buffer = au8Data,
  .tx_length   = 4,
  .p_rx_buffer = au8Data,
  .rx_length   = 4
};

nrfx_twim_xfer_desc_t sTwiRxTxData = 
{

    .type = NRFX_TWIM_XFER_RX, ///< Type of transfer.
    .address = 123,            ///< Slave address.
    .primary_length = 1,       ///< Number of bytes transferred.
    .secondary_length = 0, ///< Number of bytes transferred.
    .p_primary_buf = au8Data,    ///< Pointer to transferred data.
    .p_secondary_buf = 0,  ///< Pointer to transferred data.
};

nrfx_twim_evt_t sTestEvent;
nrfx_spim_evt_t sTestEventSpi;

K_SEM_DEFINE(sMain_Sem, 0, 1);

static void Main_EvtHandler(const nrfx_twim_evt_t* psEvent, void* pContext)
{
  /* Handler gets called a LOT! (infinitely?) */
  memcpy(&sTestEvent, psEvent, sizeof(nrfx_twim_evt_t));
  k_sem_give(&sMain_Sem);
}

static void Main_TestEvtHandlerSpi(const nrfx_spim_evt_t* psEvent, void* pContext)
{
  memcpy(&sTestEventSpi, psEvent, sizeof(nrfx_spim_evt_t));
  k_sem_give(&sMain_Sem);
}

void main(void)
{
  volatile static uint8_t u8Test123 = 0;
	printk("Hello World ! %s\n", CONFIG_BOARD);

  memset(&sTestEvent, 0xA5, sizeof(sTestEvent));
  memset(&sTestEventSpi, 0xA5, sizeof(sTestEventSpi));

#if 1 /* error case 1 */
  IRQ_CONNECT(DT_IRQN(DT_NODELABEL(i2c3)),
		    DT_IRQ(DT_NODELABEL(i2c3), priority),
		    nrfx_isr, nrfx_prs_box_3_irq_handler, 0);

  eErr = nrfx_spim_init(&sSpimInstance, &sDevCfgSpim, NULL, NULL);
  eErr = nrfx_spim_xfer(&sSpimInstance, &sSpiRxTxData, 0); /* xfer necessary to get crash */
  nrfx_spim_uninit(&sSpimInstance);

  k_sleep(K_MSEC(1000));

  eErr = nrfx_twim_init(&sTwimInstance, &sDevCfg, Main_EvtHandler, &sTwimInstance); /* crash */
  nrfx_twim_enable(&sTwimInstance);  
  nrfx_twim_xfer(&sTwimInstance, &sTwiRxTxData, 0);
  k_sem_take(&sMain_Sem, K_MSEC(10000));
  nrfx_twim_uninit(&sTwimInstance);

#else /* error case 2 */

  eErr = nrfx_spim_init(&sSpimInstance, &sDevCfgSpim, Main_TestEvtHandlerSpi, NULL);
  eErr = nrfx_spim_xfer(&sSpimInstance, &sSpiRxTxData, 0);
  k_sem_take(&sMain_Sem, K_MSEC(500)); /* crash */
  nrfx_spim_uninit(&sSpimInstance);

#endif

  /* dummy var for setting breakpoints */
  u8Test123++;
  u8Test123++;
  u8Test123++;
  u8Test123++;
  k_sleep(K_FOREVER);
}

If spim is used in a non-blocking way, as you have it in your latest snippet, then the Spi handler never gets called (which might make sense, given the IRQ_CONNECT() just connects the i2c, but still).
I need a way to wait for the spi transfer to be finished as well. Either with it being blocking or with it calling a handler which gives a semaphore (like I am doing with twim in my sample here), but for that I need either one to work.

I tried something like this, but then I get a build error, since an irq can apparently only be connected one time.

  IRQ_CONNECT(DT_IRQN(DT_NODELABEL(spi3)),
		    DT_IRQ(DT_NODELABEL(spi3), priority),
		    nrfx_isr, nrfx_prs_box_3_irq_handler, 0);

  eErr = nrfx_spim_init(&sSpimInstance, &sDevCfgSpim, Main_TestEvtHandlerSpi, NULL);
  eErr = nrfx_spim_xfer(&sSpimInstance, &sSpiRxTxData, 0); /* xfer necessary to get crash */
  nrfx_spim_uninit(&sSpimInstance);

  k_sleep(K_MSEC(1000));
  
  IRQ_CONNECT(DT_IRQN(DT_NODELABEL(i2c3)),
		    DT_IRQ(DT_NODELABEL(i2c3), priority),
		    nrfx_isr, nrfx_prs_box_3_irq_handler, 0);

  eErr = nrfx_twim_init(&sTwimInstance, &sDevCfg, Main_EvtHandler, &sTwimInstance); /* crash */
  nrfx_twim_enable(&sTwimInstance);  
  nrfx_twim_xfer(&sTwimInstance, &sTwiRxTxData, 0);
  k_sem_take(&sMain_Sem, K_MSEC(10000));
  nrfx_twim_uninit(&sTwimInstance);

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Sat, 20 Aug 2022 10:24:33 GMT

Try the following main.c:

/*
 * Copyright (c) 2012-2014 Wind River Systems, Inc.
 *
 * SPDX-License-Identifier: Apache-2.0
 */

#include <zephyr.h>
#include <sys/printk.h>
#include <string.h>
#include <nrfx_twim.h>
#include <nrfx_spim.h>
#include <drivers/src/prs/nrfx_prs.h>

nrfx_twim_t sTwimInstance = NRFX_TWIM_INSTANCE(3);
nrfx_spim_t sSpimInstance = NRFX_SPIM_INSTANCE(3);
volatile nrfx_err_t eErr;

nrfx_twim_config_t sDevCfg = 
{
  .scl = 6,                
  .sda = 5,                
  .frequency = NRF_TWIM_FREQ_400K,          
  .interrupt_priority = 7, 
  .hold_bus_uninit = false 
};

nrfx_spim_config_t sDevCfgSpim = 
{
  .sck_pin        = 7,
  .mosi_pin       = 8,
  .miso_pin       = 9,
  .ss_pin         = NRFX_SPIM_PIN_NOT_USED,
  .ss_active_high = false,
  .irq_priority   = 7,
  .orc            = 0xFF,
  .frequency      = NRF_SPIM_FREQ_8M,
  .mode           = NRF_SPIM_MODE_0,
  .bit_order      = NRF_SPIM_BIT_ORDER_MSB_FIRST,
  .miso_pull      = NRF_GPIO_PIN_PULLUP,
};

uint8_t au8Data[16];

nrfx_spim_xfer_desc_t sSpiRxTxData = 
{
  .p_tx_buffer = au8Data,
  .tx_length   = 4,
  .p_rx_buffer = au8Data,
  .rx_length   = 4
};

nrfx_twim_evt_t sTestEvent;
nrfx_spim_evt_t sTestEventSpi;

K_SEM_DEFINE(sMain_Sem, 0, 1);

static void Main_EvtHandler(const nrfx_twim_evt_t* psEvent, void* pContext)
{
  memcpy(&sTestEvent, psEvent, sizeof(nrfx_twim_evt_t));
  k_sem_give(&sMain_Sem);
}

static void Main_TestEvtHandlerSpi(const nrfx_spim_evt_t* psEvent, void* pContext)
{
  memcpy(&sTestEventSpi, psEvent, sizeof(nrfx_spim_evt_t));
  k_sem_give(&sMain_Sem);
}

static void spim_handler(const nrfx_spim_evt_t *p_event, void *p_context)
{
	printk("spim_handler running\n");
}


void main(void)
{
	printk("hello world twim ! %s\n", CONFIG_BOARD);

#if 1 /* error case 1 */
  IRQ_CONNECT(DT_IRQN(DT_NODELABEL(i2c3)),
		    DT_IRQ(DT_NODELABEL(i2c3), priority),
		    nrfx_isr, nrfx_prs_box_3_irq_handler, 0);

  eErr = nrfx_spim_init(&sSpimInstance, &sDevCfgSpim, spim_handler, NULL);
  eErr = nrfx_spim_xfer(&sSpimInstance, &sSpiRxTxData, 0); /* xfer necessary to get crash */
  nrfx_spim_uninit(&sSpimInstance);

  eErr = nrfx_twim_init(&sTwimInstance, &sDevCfg, Main_EvtHandler, &sTwimInstance); /* crash */
  nrfx_twim_enable(&sTwimInstance);  
  nrfx_twim_uninit(&sTwimInstance);
  printk("Goes here");
#else /* error case 2 */

  eErr = nrfx_spim_init(&sSpimInstance, &sDevCfgSpim, Main_TestEvtHandlerSpi, NULL);
  eErr = nrfx_spim_xfer(&sSpimInstance, &sSpiRxTxData, 0);
  k_sem_take(&sMain_Sem, K_MSEC(500)); /* crash */
  nrfx_spim_uninit(&sSpimInstance);

#endif
}

With that I was able to go past nrfx_twim_init() without the program crashing.

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Fri, 19 Aug 2022 14:21:33 GMT

[deleted]

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Fri, 19 Aug 2022 11:47:20 GMT

I'm able to reproduce your issue and will look into it today/Monday

RE: NCS nRF91: using PRS after mcuboot used SPI

MaLu — Fri, 19 Aug 2022 07:04:46 GMT

Hi, sorry for taking so long to reply.
1. yes, I am using the nRF9160dk_nrf9160_ns.

2. your problem is most likely due to this: Invalid private key with ed25519

I have changed this in my SDK installation, so of course it works. so It's my bad.

In my sample project you just need to change signature type to RSA instead of ED25519 in nRF_mcuboot.conf. That should fix it.

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Thu, 18 Aug 2022 15:02:59 GMT

After fixing the first issue a new popped up:

I: MX25R64: SFDP v 1.6 AP ff with 3 PH
I: PH0: ff00 rev 1.6: 16 DW @ 30
I: MX25R64: 8 MiBy flash
I: PH1: ffc2 rev 1.0: 4 DW @ 110
*** Booting Zephyr OS build v2.7.99-ncs1-1  ***
I: Starting bootloader
I: Swap type: none
E: Unable to find bootable image

Do you not get this?

I can see that it fails to validate the primary slot, since both of these statements evaluates to true. Do you know why it fails here, since you don't see it on your side?

It is probably something obvious. I will continue to investigate this tomorrow, so I can reproduce the issue you see.

Best regards,

Simon

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Thu, 18 Aug 2022 13:10:45 GMT

Ah, I figured out why it failed for me. After enabling log I saw the following:

E: SFDP magic 00000000 invalid

Which comes from the spi_nor driver and means that I'm not able to communicate with external flash

That is why it failed in boot_read_image_headers(), since it tried to acces the image in the external flash. The reason it failed was because but I hadn't programmed the 52840 properly, the 52840 works as a board controller and will connect the external flash to the 9160.

After programming the nrf9160dk_nrf52840 with connect_ext_flash_to_9160 I no longer had this issue. Now I will look into your issue.

Best regards,

Simon

RE: NCS nRF91: using PRS after mcuboot used SPI

Simon — Tue, 16 Aug 2022 13:37:08 GMT

What board do you use? nRF9160dk_nrf9160_ns or nrf9160dk_nrf9160? I tested it with nrf9160dk_nrf9160_ns and then it failed in \bootloader\mcuboot\boot\bootutil\src\loader.c-->boot_read_image_headers(). I then tested with the nrf9160dk_nrf9160 and noticed that it failed in drivers\flash\flash_page_layout.c--> flash_page_foreach(). I used NCS v1.9.1

I confirmed this by setting breakpoints before and after these functions and saw that it didn't hit the breakpoint.

I'm not sure how you saw that it failed in __STATIC_INLINE void __NVIC_EnableIRQ(IRQn_Type IRQn). Could you provide some detailed steps how to reproduce?

Next step would be to add some RTT/UART logging to see if we can get any hard fault information. I will try to do this and get back to you with my results.

Best regards,

Simon

RE: NCS nRF91: using PRS after mcuboot used SPI

MaLu — Tue, 16 Aug 2022 04:32:36 GMT

Hi Dejan,

I know. As I said, we use the other function blocks for uart0, uart1 and uart2. The last function block then is used via PRS
developer.nordicsemi.com/.../README.html

RE: NCS nRF91: using PRS after mcuboot used SPI

dejans — Mon, 15 Aug 2022 10:03:33 GMT

Hi Matthias,

I2C3 and SPI3 share the same base memory address as you can see in the nRF9160 memory instantiation. Have you tried using different peripheral instances for I2C and SPI?

Best regards,
Dejan

RE: NCS nRF91: using PRS after mcuboot used SPI

dejans — Thu, 11 Aug 2022 16:00:35 GMT

Hi Matthias,

I'll look into this tomorrow or on Monday.

Best regards,
Dejan