w25q16jv interfacing with nRF 52833 board

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Thu, 03 Nov 2022 08:36:37 GMT

Hi , I agree creating multiple cases confusion but I am stuck at this problem for almost 2 months now , If we could connect for a short period of time just to solve this would be really helpful.

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Thu, 03 Nov 2022 07:27:43 GMT

I see that my colleague Kazi is helping you out in your recently created case, I suggest we you keep the discussion there, as getting information from two places at once will likely lead to confusion. Here are some quick answers to the questions you've asked here, but let's close this case for now and continue it in your latest one. In the future, please don't create multiple cases on one thread.

1. Yes, spi_nor.c must be included in your project to be used.

3. too few arguments means that you have not entered enough arguments/parameters in a given function.

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Wed, 02 Nov 2022 03:59:22 GMT

HI simon ,

I tried using the spi_nor driver but I cannot get to configure it properly ,

I had started a different question thread for it but did not get any satisfactory help with it ,

problem 1 - to use the spi_nor.c I have to include it manually to my src folder of my project

problem 2- I need it to get SFDP run time configuration which I cant seem to get it write ,

problem 3 - in the spi_nor.c file I am getting this error

DEVICE_DT_INST_DEFINE(0, &spi_nor_init, NULL,
		 &spi_nor_data_0, &spi_nor_config_0,
		 POST_KERNEL, CONFIG_SPI_NOR_INIT_PRIORITY,
		 &spi_nor_api);
		 
		 
error - too few arguments in invocation of macro "Z_FOR_LOOP_1"C/C++(54)

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Wed, 28 Sep 2022 06:45:17 GMT

Since the w25q16jv is a NOR flash device, I would recommend using the spi_nor.c driver instead of the basic spi functions I think. Please check out the driver located in NCS_FOLDER\v2.x.x\zephyr\drivers\flash\spi_nor.c and rather use spi_nor_access() and spi_nor_wait_until_ready() functions to make sure the flash device is ready to receive the next message before transmitting a new message. As I think the flash might not be ready to receive a new message when you call the transceive function and it returns this error.

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Tue, 27 Sep 2022 11:27:59 GMT

Hi Simon ,

I am getting the error in spi_transceive.

working

not working

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Mon, 26 Sep 2022 08:56:09 GMT

If you could make the snippets include the names of the lines that would be better. What function is it that returns error -22 that points to the previous write not being finished? The general meaning of error -22 means there is an invalid argument somewhere in a function.

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Fri, 23 Sep 2022 12:11:36 GMT

Hi Simon,

Sorry for the late response , I was trying to figure it out , have now received some values from the flash but its not correct ,

I want to try using CPOL=0 CPHA=1 because I tried it on another board and it was working fine , but when I try to implement it , I get -22 error which means that my previous write has not finished , but I am using only one transceive function to send all 4 bytes . I am attaching both captures of my Logic analyzer

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Mon, 19 Sep 2022 12:22:33 GMT

Me and a colleague looked at your code, but it's very hard to spot something wrong by just looking at raw code, so we have not seen anything obviously wrong in your application. Can you upload a picture of the activity on your logic analyzer with a label of what line is what pin, right after a read JEDEC ID operation, from the Arduino and from an nRF52833. That way we can compare and find out where exactly things are going wrong.

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Fri, 16 Sep 2022 09:51:33 GMT

My first step is to read JEDIC ID ,but i am not getting any response from the device only

This is my code and I

#include <zephyr.h>
#include <sys/printk.h>
#include <device.h>
#include <drivers/spi.h>
#include <hal/nrf_gpio.h>
#include <kernel.h>
#include <devicetree.h>

#define SPI_MODE_CPOL 0

  struct spi_cs_control spim_cs_one = { 
                            .gpio_dev = NULL,
    						.gpio_pin = 20,
    						.gpio_dt_flags = GPIO_ACTIVE_LOW,
    						.delay = 0,
  };

static const struct spi_config spi_cfg = {
	.operation = SPI_WORD_SET(8) | SPI_TRANSFER_MSB |
		     SPI_MODE_CPOL | SPI_MODE_CPHA,
	.frequency = 4000000,
	.slave = 0,
	.cs= &spim_cs_one
};

struct device * spi_dev;

static void spi_init(void)
{
	spim_cs_one.gpio_dev = device_get_binding("GPIO_0");
	spi_dev = device_get_binding("SPI_3");

	if (spi_dev == NULL) {
		printk("Could not get %s device\n", spi_dev);
		return;
	}
}

void spi_test_send(void)
{
	int err;
	static uint8_t tx_buffer[4]={
		0x9F,
		0x00,
		0x00,
		0x00
	};
	static uint8_t rx_buffer[3];

	const struct spi_buf tx_buf = {
		.buf = tx_buffer,
		.len = sizeof(tx_buffer)
	};
	const struct spi_buf_set tx = {
		.buffers = &tx_buf,
		.count = 1
	};

	struct spi_buf rx_buf = {
		.buf = rx_buffer,
		.len = sizeof(rx_buffer),
	};
	const struct spi_buf_set rx = {
		.buffers = &rx_buf,
		.count = 1
	};
	
	 err = spi_transceive(spi_dev, &spi_cfg, &tx,&rx);
	if (err) {
		printk("SPI error: %d\n", err);
	} else {
		printk("TX sent: %x\n", tx_buffer[0]);
		for(int i=0;i<3;i++){
		printk("RX recv: %x\n", rx_buffer[0]);
		}
	}	
}

void main(void)
{
	printk("SPIM Example\n");
	spi_init();

	while (1) {
		spi_test_send();
		k_sleep(K_SECONDS(2));
	}
}



-----------------------------------------------------------------------

arduino_spi: &spi3 {
	status = "okay";
	cs-gpios = <&gpio0  20 GPIO_ACTIVE_LOW>; /* D10 */
	pinctrl-0 = <&spi3_default>;
	pinctrl-1 = <&spi3_sleep>;
	pinctrl-names = "default", "sleep";
	w25q16jv: w25q16jv@0 {
		compatible = "jedec,spi-nor";
		reg = <0>;
		spi-max-frequency = <8000000>;
		label = "w25q16jv";
	};
};

have to read the ID by sending 9F followed buy dummy bytes

I am not receiving anything from the device , is the flow of the code correct or not?

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Fri, 16 Sep 2022 06:55:14 GMT

So your application does read the JEDEC ID? If so, then this shouldn't be an issue. In this case, my colleague Håkon showed another user how to read the JEDEC ID from a Winbond flash: https://devzone.nordicsemi.com/f/nordic-q-a/64355/is-there-any-spi-example-of-ncs-v1-3-to-refer-to/262533#262533

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Fri, 16 Sep 2022 04:47:39 GMT

HI simon , I am still trying to understand what values should be put in jedec-id = [EF 70 16];

and why is it compulsory to mention this , cause we read this from the flash right?

could you help me out plz.

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Thu, 15 Sep 2022 11:33:43 GMT

First thing I see is that you've set the SPI max frequency to 50 MHz, which is restricted to 8MHz for the SPI peripheral on the nRF52833.

Do you have the datasheet of the w25q flash device you're using available? I don't see where you get EF 70 16 as the JEDEC ID from here: https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=en&DocNo=DA00-W25Q16JV.1

Are you also able to see some kind of return or error code now, or see where in the code it stops to give you an idea of what's wrong.

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Wed, 14 Sep 2022 12:35:50 GMT

Hi Simon after making the necessary changes in my DT setting i still have not gotten it to work

this is my dts spi3 setting

arduino_spi: &spi3 {
	status = "okay";
	cs-gpios = <&gpio0  20 GPIO_ACTIVE_LOW>; /* D10 */
	pinctrl-0 = <&spi3_default>;
	pinctrl-1 = <&spi3_sleep>;
	pinctrl-names = "default", "sleep";
	w25q16jv: w25q16jv@0 {
		compatible = "jedec,spi-nor";
		reg = <0>;
		spi-max-frequency = <50000000>;
		label = "w25q16jv";
		jedec-id = [EF 70 16];
		size = <16777216>;
	};
};

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Wed, 14 Sep 2022 08:48:35 GMT

Hi Simon , Yes I was not adding anything like this to my DT , I will try this out ,

I am new to DTs and its functioning, Thank you for being patient

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Wed, 14 Sep 2022 07:38:58 GMT

I still think this is an issue with your devicetree settings, please read our documentation on it thoroughly. I would also recommend trying to do some debugging so we can see what is actually returning error codes.

In your .dts file, when using an external flash, it should look something like this (SPI instead of QSPI though, since you're using an nRF52833). But the jedec-id, sfdp-bfp, size, etc. needs to match the external flash's datasheet.

&qspi {
	status = "okay";
	pinctrl-0 = <&qspi_default>;
	pinctrl-1 = <&qspi_sleep>;
	pinctrl-names = "default", "sleep";
	mx25r64: mx25r6435f@0 {
		compatible = "nordic,qspi-nor";
		reg = <0>;
		/* MX25R64 supports only pp and pp4io */
		writeoc = "pp4io";
		/* MX25R64 supports all readoc options */
		readoc = "read4io";
		sck-frequency = <8000000>;
		label = "MX25R64";
		jedec-id = [c2 28 17];
		sfdp-bfp = [
			e5 20 f1 ff  ff ff ff 03  44 eb 08 6b  08 3b 04 bb
			ee ff ff ff  ff ff 00 ff  ff ff 00 ff  0c 20 0f 52
			10 d8 00 ff  23 72 f5 00  82 ed 04 cc  44 83 68 44
			30 b0 30 b0  f7 c4 d5 5c  00 be 29 ff  f0 d0 ff ff
		];
		size = <67108864>;
		has-dpd;
		t-enter-dpd = <10000>;
		t-exit-dpd = <35000>;
	};
};

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Tue, 13 Sep 2022 04:51:25 GMT

Hi I can now get my cs pin to work and I am Unable to get any response from the flash , I tried implementing the flash with arduino and i can read the values stored in it , As per the data sheet i am trying to send 90h and then 000000h , where am i going wrong

#include <zephyr.h>
#include <sys/printk.h>
#include <device.h>
#include <drivers/spi.h>
#include <hal/nrf_gpio.h>
#include <kernel.h>
#define SPI_MODE_CPOL 0
#define MY_SPI DT_NODELABEL(spi3)

  struct spi_cs_control spim_cs_one = { 
                            .gpio_dev = NULL,
    						.gpio_pin = 20,
    						.gpio_dt_flags = GPIO_ACTIVE_LOW,
    						.delay = 0,
  };

static const struct spi_config spi_cfg = {
	.operation = SPI_WORD_SET(8) | SPI_TRANSFER_MSB |
		     SPI_MODE_CPOL | SPI_MODE_CPHA,
	.frequency = 4000000,
	.slave = 0,
	.cs= &spim_cs_one
};

struct device * spi_dev;

static void spi_init(void)
{
	spim_cs_one.gpio_dev = device_get_binding("GPIO_0");
	
	const char* const spiName = "SPI_3";
	spi_dev = device_get_binding(spiName);

	if (spi_dev == NULL) {
		printk("Could not get %s device\n", spiName);
		return;
	}
}

void spi_test_send(void)
{
	int err;
	static uint8_t tx_buffer[4]={
		0x90,
		0x00,
		0x00,
		0x00
	};
	static uint8_t rx_buffer[2];

	const struct spi_buf tx_buf = {
		.buf = tx_buffer,
		.len = sizeof(tx_buffer)
	};
	const struct spi_buf_set tx = {
		.buffers = &tx_buf,
		.count = 1
	};

	struct spi_buf rx_buf = {
		.buf = rx_buffer,
		.len = sizeof(rx_buffer),
	};
	const struct spi_buf_set rx = {
		.buffers = &rx_buf,
		.count = 1
	};

	err = spi_transceive(spi_dev, &spi_cfg, &tx, &rx);
	if (err) {
		printk("SPI error: %d\n", err);
	} else {
		/* Connect MISO to MOSI for loopback */
		printk("TX sent: %x\n", tx_buffer[0]);
		for(int i=0;i<2;i++){
		printk("RX recv: %x\n", rx_buffer[0]);
		}
	}	
}

void main(void)
{
	printk("SPIM Example\n");
	spi_init();

	while (1) {
		spi_test_send();
		k_sleep(K_SECONDS(2));
	}
}

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Mon, 12 Sep 2022 08:41:51 GMT

HI Simon I have connected a logic analyzer and I don't see anything on my CS pin being activated , I have tried using CS-GPIO in the DTS and I also tied the spi_cs_control .

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Mon, 12 Sep 2022 06:56:38 GMT

Hi Simon , I am using the default pins for spi ,i.e. SPI default which is 23-22-21 .

PIN 10 was used in that example hence I have commented them

I have tried the spi loop back and it is working properly.

Yes I haven't named the device , I am a little confused in what to mention in my overlay file . could you help me with that?

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Mon, 12 Sep 2022 06:51:16 GMT

Can you upload the error message you're seeing on your end? It doesn't seem like you have "named" the device as you should in the overlay file, with label, JEDEC-ID, size and max frequency. Please also note that pin P0.10 that you're using as the MOSI pin, is by default configured as an NFC pin by default, and you will have to add the following config to your prj.conf file to use this as a normal GPIO: CONFIG_NFCT_PINS_AS_GPIOS. Additionally, if you're working on an nRF52833 DK, there are some HW changes necessary to use P0.09 and P0.10 as GPIOs. This is described in our DK user guide.

Best regards,

Simon

RE: w25q16jv interfacing with nRF 52833 board

Manas_punjabi — Fri, 09 Sep 2022 12:44:26 GMT

Hi I am using 2.0.2 and i am having the error of not finding the flash devise because i don't have the compatible mentioned in it . I dont know what should be mentioned in the overlay file . please can you hlep.

RE: w25q16jv interfacing with nRF 52833 board

Simonr — Fri, 09 Sep 2022 12:19:27 GMT

What version of nRF Connect SDK are you using for development. The version discussed in this ticket is pretty old right now, and in NCS v2.x.x and onwards we added a whole new way to do Pin Control. My guess is that you haven't implemented the pin control correctly.

You might also want to check out the JEDEC SPI-NOR sample in Zephyr that already sets up an external Flash and QSPI/SPI with an external flash. But you need to configure the overlay file to match your specific flash.

Best regards,

Simon