Zephyr shell & log timestamp format

RE: Zephyr shell & log timestamp format

Einarh — Mon, 03 Oct 2022 08:21:33 GMT

It doesn't matter that CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP=n is set in proj.conf if you cannot see it in the .config file.

The .config file is the result of your different configurations, so if CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP=n doesn't show up there, then another option is overwriting it.

-Einar

RE: Zephyr shell & log timestamp format

nRF5xFanboy — Sun, 02 Oct 2022 06:12:06 GMT

Hi Einarh

I do confirm the flag is in proj.conf

I have three hardware platforms / build folders to check.

In two builds (I most often used for development) the flag is in absent build_x/zephyr/.config?

The third build was not create with ncs 2.0.2 so not wise to compare.

best regards,
nRF5xFanBoy

RE: Zephyr shell & log timestamp format

Einarh — Tue, 27 Sep 2022 13:54:09 GMT

Did you try setting CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP=n ?

Best regards,

Einar

edit:

wait, I'm blind, you already set that.

Can you confirm that this flag is actually set by checking build/zephyr/.config?

RE: Zephyr shell & log timestamp format

nRF5xFanboy — Tue, 27 Sep 2022 11:18:36 GMT

I did dive into some of the zephyr source code for logging in the shell and the backends and I got confused:

Log_backend_native_posix.c

static void put(const struct log_backend *const backend,
		struct log_msg *msg)
{
	log_msg_get(msg);

	uint32_t flags = LOG_OUTPUT_FLAG_LEVEL | LOG_OUTPUT_FLAG_TIMESTAMP;   /// <--  ????

	if (IS_ENABLED(CONFIG_LOG_BACKEND_SHOW_COLOR)) {
		if (posix_trace_over_tty(0)) {
			flags |= LOG_OUTPUT_FLAG_COLORS;
		}
	}

	if (IS_ENABLED(CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP)) {
		flags |= LOG_OUTPUT_FLAG_FORMAT_TIMESTAMP;   	/// <--  ???? why ??
	}

	log_output_msg_process(&log_output_posix, msg, flags);

	log_msg_put(msg);

}

shell_log_backend.c

static void msg_process(const struct log_output *log_output,
			struct log_msg *msg, bool colors)
{
	uint32_t flags = LOG_OUTPUT_FLAG_LEVEL |
		      LOG_OUTPUT_FLAG_TIMESTAMP |
		      LOG_OUTPUT_FLAG_FORMAT_TIMESTAMP;

	if (colors) {
		flags |= LOG_OUTPUT_FLAG_COLORS;
	}

	log_output_msg_process(log_output, msg, flags);
	log_msg_put(msg);
}

log_core.c

static int timestamp_print(const struct log_output *output,
			   uint32_t flags, log_timestamp_t timestamp)
{
	int length;
	bool format =
		(flags & LOG_OUTPUT_FLAG_FORMAT_TIMESTAMP) |   /// <--- always true
		(flags & LOG_OUTPUT_FLAG_FORMAT_SYSLOG) |
		IS_ENABLED(CONFIG_LOG_OUTPUT_FORMAT_LINUX_TIMESTAMP); /// ?????

...

Based upon above statements it seems shell logging can never become raw
Question to Zephyr is that intended by design or a bug?