Need help with battery example

RE: Need help with battery example

BehicMV — Tue, 07 Feb 2023 13:50:15 GMT

If you done it, can you help this ticket ?

RE: Need help with battery example

Mike Austin (LPI) — Sun, 06 Nov 2022 23:14:20 GMT

Thanks Jared. Think the penny dropped for me about the same time you sent that explanation through.

I've actually got a similar circuit set up on my custom board, except I'm using P0.30 as my BAT_MON_EN signal, and at the moment I have two 150K resistors as my resistor divider network.

So, I modified my overlay file to this:

/ {
    vbatt {
       compatible = "voltage-divider";
       io-channels = <&adc 0>;
       output-ohms = <150000>;
       full-ohms = <(150000 + 150000)>;
       power-gpios = <&gpio0 30 (GPIO_PULL_DOWN | GPIO_ACTIVE_HIGH)>;
    };
 };

And everything works as expected

Thanks again

Mike

RE: Need help with battery example

Jared — Fri, 04 Nov 2022 10:10:29 GMT

Hi Mike,

Great, that you found the solution!

[quote user="Mike Austin (LPI)"]One other question - the power-gpios is an optional parameter in the vbatt node. What actually is that for? I've just commented it out in my application, but I'd like to understand what it does[/quote]

From here,

power-gpios:
type: phandle-array
required: false
description: |
Control power to the voltage divider inputs.
If present the corresponding GPIO must be set to an active level
to enable the divider input.

To be honest, I haven't really used this child node before so not entirely sure how it's used.

EDIT: Actually, I found a use case where this child node would have been used. For example on our Thingy:52 we have a signal called BAT_MON_EN that "turns off" the voltage divider when it's not in use:

regards

Jared

RE: Need help with battery example

Mike Austin (LPI) — Thu, 03 Nov 2022 22:09:06 GMT

Hi Jared,

That was actually my objective - to use AIN0. I didn't realise that I also have to specify a channel though. I probably need to understand a bit more about the SAADC function and how channels work - can you point me to some documentation that explains this part of it?

Looking at the battery.c code, I was able to see what the issue is. In this snippet:

if (cfg->output_ohm != 0) {
		accp->input_positive = SAADC_CH_PSELP_PSELP_AnalogInput0
			+ iocp->channel;
	} else {
		accp->input_positive = SAADC_CH_PSELP_PSELP_VDD;
	}

its basically setting the analog positive input channel to equal VDD if I haven't added the vbatt definition to my overlay file. Which explains why the output of the example code was sitting unchanged at ~ 3V even though I was varying the analog signal at P0.02.

I added the following to my overlay file:

 / {
    vbatt {
       compatible = "voltage-divider";
       io-channels = <&adc 0>;
       output-ohms = <150000>;
       full-ohms = <(1500000 + 150000)>;
       //power-gpios = <&sx1509b 4 0>;
    };
 };

And changed this section of battery.c:

f (cfg->output_ohm != 0) {
		accp->input_positive = SAADC_CH_PSELP_PSELP_AnalogInput0;
			//+ iocp->channel;

And now its working as I would expect.

One other question - the power-gpios is an optional parameter in the vbatt node. What actually is that for? I've just commented it out in my application, but I'd like to understand what it does

Regards,

Mike

RE: Need help with battery example

Jared — Thu, 03 Nov 2022 13:05:11 GMT

Hi there MIke,

I think that would setup the DK to use AIN0 and channel 0.

The ADC examples sets the device to use the same pin number as the channel here.

If you want to use AIN2 and channel 0 then you have to set this line in the example to SAADC_CH_PSELP_PSELP_AnalogInput2 and omit "+ iocp->channel".

regards

Jared