RE: New Command Line Interface and enhanced Logger - part 2.

Vincent Belaïche — Tue, 12 Sep 2023 15:28:09 GMT

The code:

#define NRF_LOG_MODULE_NAME my_module
#if MY_MODULE_CONFIG_LOG_ENABLED
#  define NRF_LOG_LEVEL MY_MODULE_CONFIG_LOG_LEVEL
#  define NRF_LOG_INFO_COLOR MY_MODULE_CONFIG_INFO_COLOR 
#  define NRF_LOG_DEBUG_COLOR MY_MODULE_CONFIG_DEBUG_COLOR 
#else // MY_MODULE _CONFIG_LOG_ENABLED 
#  define NRF_LOG_LEVEL 0 
#endif // MY_MODULE _CONFIG_LOG_ENABLED
#include "nrf_log.h"
NRF_LOG_MODULE_REGISTER();

will fail if NRF_LOG_INFO_COLOR or NRF_LOG_DEBUG_COLOR are defined in the sdk_config.h because a macro is redefined.

Maybe it would be great to change the nrf_log_internal.h to rather have something like that:

#ifndef NRF_LOG_COLOR_DEFAULT
# define NRF_LOG_COLOR_DEFAULT 0
#endif
#ifndef NRF_LOG_DEBUG_COLOR_DEFAULT
# define NRF_LOG_DEBUG_COLOR_DEFAULT NRF_LOG_COLOR_DEFAULT
#endif
#ifndef NRF_LOG_INFO_COLOR_DEFAULT
# define NRF_LOG_INFO_COLOR_DEFAULT NRF_LOG_COLOR_DEFAULT
#endif
#ifndef NRF_LOG_DEBUG_COLOR
# define NRF_LOG_DEBUG_COLOR NRF_LOG_DEBUG_COLOR_DEFAULT
#endif
#ifndef NRF_LOG_INFO_COLOR
# define NRF_LOG_INFO_COLOR NRF_LOG_INFO_COLOR_DEFAULT
#endif

This way you can set NRF_LOG_DEBUG_COLOR_DEFAULT or NRF_LOG_INFO_COLOR_DEFAULT in the sdk_config.h w/o causing preprocessor barking.

RE: New Command Line Interface and enhanced Logger - part 2.

lvh831 — Wed, 09 Nov 2022 07:31:59 GMT

I wonder if there has been any other updates on CLI for SDK v17+ now. Images are obviously still not working.

RE: New Command Line Interface and enhanced Logger - part 2.

mehow — Mon, 23 Mar 2020 20:59:42 GMT

Could you please fix the images not loading?

RE: New Command Line Interface and enhanced Logger - part 2.

Bselekar — Wed, 16 Oct 2019 14:11:09 GMT

Hi, can somebody publish HEX file for nrf52832 for this improved Command Line Interface and enhanced Logger? Thanks!