fds.c: m_op_queue.rp uninitialized

[Justin]

i don't see where the command queue index, m_op_queue.rp, is initialized.

when queue_process is called, the following line blows up:

fds_op_t   * const p_op = &m_op_queue.op[m_op_queue.rp];

this occurs when using peer manager and a new device bonds with the peripheral. adding a check resolves the issue:

if ( m_op_queue.rp >= FDS_OP_QUEUE_SIZE )
{
     m_op_queue.rp = 0;
}

SDK12.0.0

[Sigurd]

Hi,

All global and static variables will be initialized to zero. See here for more details about this.

m_op_queue is declared in the top of fds.c as:

static fds_op_queue_t       m_op_queue;

m_op_queue.rp is therefore initialized to 0.

[Justin]

Thanks. I was definitely seeing m_op_queue.rp with an invalid value.

It must have been the result of some memory corruption elsewhere.