Updating advertising data (manuf. spec. data) in SDK15

[Spirit]

Hello guys! And girls 

My project is working as expected in SDK14.2.
I'm updating adv data (manuf. spec. data) without any problem with this function

static void advertising_data_update(uint8_t adv_manuf_byte)
{
		ret_code_t err_code;

		ble_advertising_init_t 		init;
		ble_advdata_manuf_data_t 	adv_manuf_data;
		uint8_array_t            	adv_manuf_data_array;
		uint8_t                  	adv_manuf_data_data[1];
		adv_manuf_data_data[0] 		= adv_manuf_byte;

		memset(&init, 0, sizeof(init));

		init.advdata.name_type          		 = BLE_ADVDATA_FULL_NAME;
		init.advdata.include_appearance 		 = false;
		init.advdata.flags              		 = BLE_GAP_ADV_FLAGS_LE_ONLY_GENERAL_DISC_MODE;
		init.advdata.uuids_complete.uuid_cnt = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
		init.advdata.uuids_complete.p_uuids  = m_adv_uuids;

		adv_manuf_data_array.p_data 							 = adv_manuf_data_data;
		adv_manuf_data_array.size 								 = sizeof(adv_manuf_data_data);
		adv_manuf_data.company_identifier 				 = APP_COMPANY_IDENTIFIER;
		adv_manuf_data.data 											 = adv_manuf_data_array;
		init.advdata.p_manuf_specific_data 				 = &adv_manuf_data;

		init.config.ble_adv_whitelist_enabled      = true;
		init.config.ble_adv_directed_enabled       = true;
		init.config.ble_adv_directed_slow_enabled  = false;
		init.config.ble_adv_directed_slow_interval = 0;
		init.config.ble_adv_directed_slow_timeout  = 0;
		init.config.ble_adv_fast_enabled  				 = true;
		init.config.ble_adv_fast_interval 				 = APP_ADV_INTERVAL;
		init.config.ble_adv_fast_timeout  				 = APP_ADV_TIMEOUT_IN_SECONDS;
							
		err_code = ble_advdata_set(&init.advdata, NULL);
		APP_ERROR_CHECK(err_code);	   
}

But in SDK15 the function ble_advdata_set() has been deprecated.
The migration guide is says to use ble_advdata_encode() and sd_ble_gap_adv_set_configure() instead.

So I changed it to something like this

static void advertising_data_update(uint8_t adv_manuf_byte)
{
		ret_code_t err_code;

		ble_advertising_init_t 		init;
		ble_advdata_manuf_data_t 	adv_manuf_data;
		uint8_array_t            	adv_manuf_data_array;
		adv_manuf_data_data[0] 		= adv_manuf_byte;

		memset(&init, 0, sizeof(init));

    init.advdata.name_type          		 = BLE_ADVDATA_FULL_NAME;
    init.advdata.include_appearance 		 = false;
    init.advdata.flags              		 = BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE;
    init.advdata.uuids_complete.uuid_cnt = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    init.advdata.uuids_complete.p_uuids  = m_adv_uuids;
			
		adv_manuf_data_array.p_data 							 = adv_manuf_data_data;
		adv_manuf_data_array.size 								 = sizeof(adv_manuf_data_data);
		adv_manuf_data.company_identifier 				 = APP_COMPANY_IDENTIFIER;
		adv_manuf_data.data 											 = adv_manuf_data_array;
		init.advdata.p_manuf_specific_data 				 = &adv_manuf_data;

    init.config.ble_adv_whitelist_enabled      			= true;
		init.config.ble_adv_directed_high_duty_enabled 	= true;
    init.config.ble_adv_directed_enabled       			= false;
    init.config.ble_adv_fast_enabled  				 			= true;
    init.config.ble_adv_fast_interval 				 			= APP_ADV_INTERVAL;
    init.config.ble_adv_fast_timeout  				 			= APP_ADV_FAST_DURATION;

		//err_code = sd_ble_gap_adv_stop(m_advertising.adv_handle);
		//APP_ERROR_CHECK(err_code);
			
		err_code = ble_advdata_encode(&init.advdata, m_adv_data.adv_data.p_data, &m_adv_data.adv_data.len);	
		APP_ERROR_CHECK(err_code);

		err_code = sd_ble_gap_adv_set_configure(&m_advertising.adv_handle, &m_adv_data, NULL);
		APP_ERROR_CHECK(err_code);
		
		//err_code = sd_ble_gap_adv_start(m_advertising.adv_handle, APP_BLE_CONN_CFG_TAG);
		//APP_ERROR_CHECK(err_code);
}

And of course... it's not working. :)
I'm getting a very strange error at sd_ble_gap_adv_set_configure() --> app: ERROR 12801 [Unknown error code]

Any idea why?
What I'm doing wrong?
What I have to change to get this working like in the SDK14.2?

[haakonsh]

Try this code:

static void advertising_init(void)
{
    ret_code_t 					err_code;
    ble_advertising_init_t 		init;

    ble_advdata_manuf_data_t 	adv_manuf_data;
    uint8_array_t            	adv_manuf_data_array;
	
    adv_manuf_data_data[0] 		= 0x00;

	
    memset(&init, 0, sizeof(init));

    init.advdata.name_type          		= BLE_ADVDATA_FULL_NAME;
    init.advdata.include_appearance 		= false;
    init.advdata.flags              	    = BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE;
    init.advdata.uuids_complete.uuid_cnt    = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    init.advdata.uuids_complete.p_uuids     = m_adv_uuids;
         
    adv_manuf_data_array.p_data 			= adv_manuf_data_data;
    adv_manuf_data_array.size 				= sizeof(adv_manuf_data_data);
    adv_manuf_data.company_identifier 		= APP_COMPANY_IDENTIFIER;
    adv_manuf_data.data 					= adv_manuf_data_array;
    init.advdata.p_manuf_specific_data 		= &adv_manuf_data;

    init.config.ble_adv_whitelist_enabled      		= true;
    init.config.ble_adv_directed_high_duty_enabled 	= false;
    init.config.ble_adv_directed_enabled       		= false;
    init.config.ble_adv_fast_enabled  				= true;
    init.config.ble_adv_fast_interval 				= APP_ADV_INTERVAL;
    init.config.ble_adv_fast_timeout  				= APP_ADV_FAST_DURATION;

    init.evt_handler 	= on_adv_evt;
    init.error_handler  = ble_advertising_error_handler; 

    err_code = ble_advertising_init(&m_advertising, &init);
    APP_ERROR_CHECK(err_code);

    ble_advertising_conn_cfg_tag_set(&m_advertising, APP_BLE_CONN_CFG_TAG);
}

static void advertising_data_update(uint8_t adv_manuf_byte)
{
    ret_code_t err_code;
    ble_advdata_t              advdata;       /**< Advertising data: name, appearance, discovery flags, and more. */
    //ble_advdata_t              srdata;        /**< Scan response data: Supplement to advertising data. */

	ble_advdata_manuf_data_t 	adv_manuf_data;
	
    uint8_array_t            	adv_manuf_data_array;
	
	adv_manuf_data_data[0]     = adv_manuf_byte;

    memset(&advdata, 0, sizeof(advdata));
    //memset(&srdata, 0, sizeof(srdata));
   
    advdata.name_type          	        = BLE_ADVDATA_FULL_NAME;
    advdata.include_appearance 	        = false;
    advdata.flags              	        = BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE;
    advdata.uuids_complete.uuid_cnt     = sizeof(m_adv_uuids) / sizeof(m_adv_uuids[0]);
    advdata.uuids_complete.p_uuids      = m_adv_uuids;
			
	adv_manuf_data_array.p_data         = adv_manuf_data_data;
	adv_manuf_data_array.size 			= sizeof(adv_manuf_data_data);
	adv_manuf_data.company_identifier   = APP_COMPANY_IDENTIFIER;
	adv_manuf_data.data 				= adv_manuf_data_array;
	advdata.p_manuf_specific_data 		= &adv_manuf_data;

    update_advertising_data(&m_advertising, &advdata, m_advertising.adv_data.adv_data.len, NULL, 0);
}

/* PARAMS
[IN] p_advertising: Pointer to an advertising instance, usually m_advertising in 'main' context.
[IN] p_adv_data:    Pointer to an advertisment data instance.
[IN] adv_data_len:  Length of advertisment data in bytes.
[IN] p_sr_data:     Pointer to an scan respose data instance, set to NULL if no SR data.
[IN] sr_data_len:   Length of scan response data in bytes.
*/
void update_advertising_data(ble_advertising_t *p_advertising, ble_advdata_t *p_adv_data, uint16_t adv_data_len, ble_advdata_t *p_sr_data, uint16_t sr_data_len)
{
    ASSERT(p_advertising->initialized);

    uint32_t ret = NRF_SUCCESS;
    ble_gap_adv_data_t *new_advdata;

    new_advdata->adv_data.len = adv_data_len;      

    ret = ble_advdata_encode(p_adv_data, new_advdata->adv_data.p_data, &new_advdata->adv_data.len);
    APP_ERROR_CHECK(ret);

    if (p_sr_data)
    {
        new_advdata->scan_rsp_data.len = sr_data_len;

        ret = ble_advdata_encode(p_sr_data,
                               new_advdata->scan_rsp_data.p_data,
                               &new_advdata->scan_rsp_data.len);
        APP_ERROR_CHECK(ret);
    }
    else
    {
        new_advdata->scan_rsp_data.p_data = NULL;
        new_advdata->scan_rsp_data.len    = 0;
    }

    ret = sd_ble_gap_adv_set_configure(&p_advertising->adv_handle, new_advdata, NULL);
    APP_ERROR_CHECK(ret);
}

[parallelko]

I also tried this, and recieve error 12, with a ble_advdata_encode(). May be we should encode data directly to m_advertising.enc_advdata? like when we initialize advertising?

[haakonsh]

Yes! You need at least two buffers to switch between.

[Spirit]

haakonsh you can say what you want, but ble_advdata_set() what a much much better solution
I really don't know why the "SDK-makers" are making every single revision more difficult or complex for us

parallelko thank you! 
I will try your solution a bit later.

[Spirit]

parallelko haakonsh
nope, now I'm getting an ERROR 12801 (BLE_ERROR_GAP_DISCOVERABLE_WITH_WHITELIST) like I had at the beginning of all this story 
Although I use BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE...

[Spirit]

haakonsh
When I set a flag (just for testing) to BLE_GAP_ADV_FLAG_BR_EDR_NOT_SUPPORTED, all above is wokring well. Except one thing. When I do a disconnect, every single time this my p_manuf_specific_data byte return to the default value defined in advertising_init(), no matter what it was before with an update of adv data.

Now I'm really getting desperate.
It is even possible to do this in SDK15 or I must go back to 14 where everything was working well??

[haakonsh]

From BLE_ERROR_GAP_DISCOVERABLE_WITH_WHITELIST docs:
"Use of Whitelist not permitted with discoverable advertising."

The code you've posted earlier has this line in advertising init:

init.config.ble_adv_whitelist_enabled      = true;

It should be false, or else you need to use the 

BLE_GAP_ADV_FLAG_BR_EDR_NOT_SUPPORTED flag instead of BLE_GAP_ADV_FLAGS_LE_ONLY_LIMITED_DISC_MODE.

[Spirit]

haakonsh
I realized that and I already change to BLE_GAP_ADV_FLAG_BR_EDR_NOT_SUPPORTED
But the main problem with your (and parallelko) code remain - as I said above.

I qoute myself: "When I do a disconnect, every single time this my p_manuf_specific_data byte return to the default value defined in advertising_init(), no matter what it was before with an update of adv data."

[haakonsh]

You need to chase the logic of your application. I'm guessing there is a call to advertising_start() or some similar function name whenever a BLE_GAP_EVT_DISCONNECTED is sent to the application. I guess that this function points to the original advertisement data currently set in the m_advertisment instance in main.c 

[Spirit]

haakonsh, nope.
My BLE_GAP_EVT_DISCONNECT is completely empty of any advertising_start() or similar function.



advertising_start() is called only at the beginning.


How could I find out what could possibly point to the original advertisement data?

[haakonsh]

Hmm. Send me a PM with your application and I'll take a look at it. 

[haakonsh]

Line 681 of ble_advertising.c: // Upon disconnection, whitelist will be activated and direct advertising is started.

ble_advertising_on_ble_evt is the event handler registered with the macro  BLE_ADVERTISING_DEF(m_advertising); on line 104 of main.c.

This event handler will call on_disconnected() given the event is BLE_GAP_EVT_DISCONNECTED. You need to update the advertising data of m_advertising in main before you can restart the advertisements if you want the updated advertisement data. You should be able to to this by setting m_advertising.adv_data.adv_data.p_data and .len to the address and length of your previously used buffer, 

new_advdata.adv_data.p_data and new_advdata.adv_data.len.