Crash when handling Config Node Reset when a reliable transfer is ongoing

[JonasJ]

If a reliable mesh transfer is ongoing the node will crash with a mesh assert at access_reliable.c:373, in access_reliable_cancel_all().

This happens because access_clear() calls access_state_clear() and then access_reliable_cancel_all().

The access_state_clear() will erase m_model_pool and access_reliable_cancel_all() will cancel all ongoing transfers which holds a handle into m_model_pool which is now invalid and thus access_model_p_args_get() returns NRF_ERROR_NOT_FOUND triggering the assert.

Swapping the calls make things work better.

diff --git a/mesh/access/src/access.c b/mesh/access/src/access.c
index 81e1492..153b2fe 100644
--- a/mesh/access/src/access.c
+++ b/mesh/access/src/access.c
@@ -1083,8 +1083,8 @@ uint32_t access_packet_tx(access_model_handle_t handle,
 /* ********** Public API ********** */
 void access_clear(void)
 {
-    access_state_clear();
     access_reliable_cancel_all();
+    access_state_clear();
     access_flash_config_clear();
 }
 

I'm using SDK For Mesh v3.1.0.

Thanks.

[Jørgen Holmefjord]

Hi,

Thank you for reporting this issue, I agree that it looks like a bug. I have reported it internally.

Best regards,
Jørgen

[JonasJ]

Hi Jørgen Holmefjord,

It looks like this fix didn't make it for v3.2.0, any reason for this?

Thanks.

[Jørgen Holmefjord]

Hi,

I'm checking this with the developers, I will get back to you when I receive an answer.

Typically there are two reasons that a fix is not included in a release:

1. The developers did not have enough resources to implement and test the fix for the release.
2. The fix makes API changes that are not acceptable in a minor release version.

Best regards,
Jørgen

[JonasJ]

Jørgen HolmefjordIt looks like Mesh SDK 4.0.0 still have the same bug. Any feedback from the Mesh Team on this?

[Jørgen Holmefjord]

Hi,

I did not receive feedback from the developers, but I see that the internal ticket has been resolved and the fix should be included in the next release.

I'm sorry for the long delay in handling this.