-DNRF52 ambiguous and incompatible with -DNRF52832_XXAB

[Bruno Randolf]

When working on adapting the bootloader for NRF52832_XXAB I noticed that -DNRF52 seems to define NRF52832_XXAA and later defining -DNRF52832_XXAB does not override it. I suppose -DNRF52 should be removed alltogether and the more specific -DNRF52832_XXAA or -DNRF52832_XXAB be used.

[Andy]

Sure, the fix is easy, but very hard to troubleshoot if it happens. I don't know about SDK15.3 since I'm still in 15.2, but in 15.2 -DNRF52 is defined along -DNRF52832_XXAA in a lot of example projects.

I think the redefinition doesn't do as much damage as including the "old" NRF52 definition in newer example projects.

[Bruno Randolf]

I am using SDK 15.3.0 and yes, the main problem is that the old define -DNRF52 is still used in many example projects. without digging deeper into the SDK its hard to know wether -DNRF52 is needed for something or not... i think many people start their project from one example project and then it's that will just get copied over and when we then want to change or refine the target gets into the way. so... please remove it from all examples!!! thanks