compiler warning: pointer from integer without a cast

Question

Hello, 
 Would appreciate some understanding of a compiler warning. Developing for nRF52832 using SDK 15.3.0 plus S112. 
 This code compiles without warning: 
 ret_code_t err_code;
err_code = nrfx_ppi_channel_assign(chan_0, nrfx_gpiote_in_event_addr_get(COMPARATOR_PIN),nrfx_timer_task_address_get(&m_timer1,NRF_TIMER_TASK_START));
APP_ERROR_CHECK(err_code); 
 Then I switch from nrfx to sd calls: 
 ret_code_t err_code;
err_code = sd_ppi_channel_assign(chan_0, nrfx_gpiote_in_event_addr_get(COMPARATOR_PIN),nrfx_timer_task_address_get(&m_timer1,NRF_TIMER_TASK_START));
APP_ERROR_CHECK(err_code); 
 and the following warnings: 
 passing argument 2 of 'sd_ppi_channel_assign' makes pointer from integer without a cast [-Wint-conversion] 
 passing argument 3 of 'sd_ppi_channel_assign' makes pointer from integer without a cast [-Wint-conversion] 
 All seems to work, but would appreciate understanding the warnings. 
 Many thanks, 
 Tim

tesc · Accepted Answer

Hi, 
 From what I can tell, the two are equivalent (except for the second one missing the call to APP_ERROR_CHECK()). That is, both should compile to the same as long as the compiler does some minimal optimization. 
 However I do find the first one easier to read and understand. It does fewer things per line, and also gives descriptive names to the arguments sent in to sd_ppi_channel_assign() by using temporary variables (event_addr and task_addr). 
 When in doubt, use the one which is the easiest to understand for someone looking into this code in the future. That might be you, a couple of years from now. 
 Regards, Terje

compiler warning: pointer from integer without a cast

Top Replies