there is one error function in nRF5_SDK_12.1.0_0d23e2a

[Chaw]

Hi, Nordic engineers I checked there is one error function in nRF5_SDK_12.1.0_0d23e2a:

in nrf_esb.h

uint32_t nrf_esb_get_rf_channel(uint32_t * p_channel);

but in nrf_esb.c

uint32_t nrf_esb_rf_channel_get(uint32_t * p_channel) {

VERIFY_PARAM_NOT_NULL(p_channel);
*p_channel = m_esb_addr.rf_channel;
return NRF_SUCCESS;

}

they should be same one function, but function name is different. I think nrf_esb.c is wrong, it should be nrf_esb_get_rf_channle. Plz check. Thanks.

[Sigurd]

Hi Chaw,

In nrf_esb.c the function is named nrf_esb_get_rf_channel(), but in nrf_esb.h the corresponding function is named nrf_esb_rf_channel_get(). The header file is wrong here, and the correct name should be nrf_esb_get_rf_channel().

Thank you for giving us feedback on this!

[Susheel Nuguru]

Hi, try to keep the name in header file if it is compatible with older versions. If header file matches older revisions, change name in C file

[Sigurd]

The bug was introduced in SDK 11 with the new implementation of the ESB protocol (support added for nRF52).

[Jens]

Wow Nordic... Just came across this isn nrf5 sdk 12.3.0. Doesn't look like it got fixed after 12.1. As we are on nrf51822 platform, any chance of a backported fix, e.g. 12.3.1, bugfix release?

[Sigurd]

Hi Jens, it got fixed in SDK 13. To fix this bug, you only need to update the header file nrf_esb.h