Peer Manager Peer Delete

[PanTikTak]

Hello Nordic, Im using SDK13.0 and im struggling with pm_peer_delete() My way of testing this function:

1. Raw firmware without any bonds.
2. Create bond. Peer id is set to 0.
3. Over this connection try to delete different bond using pm_peer_delete(n). (n=1) Always return NRF_SUCCESS. I thnink it should return NRF_ERROR_INVALID_PARAM because there is no such bond.

I think problems is here :

 ret_code_t im_peer_free(pm_peer_id_t peer_id) {
     uint16_t   conn_handle;
     ret_code_t ret;
 
     NRF_PM_DEBUG_CHECK(m_module_initialized);
 
     conn_handle = im_conn_handle_get(peer_id);
     ret         = pdb_peer_free(peer_id);
 
     if ((conn_handle != BLE_CONN_HANDLE_INVALID) && (ret == NRF_SUCCESS))
     {
         peer_id_set(conn_handle, PM_PEER_ID_INVALID);
     }
     return ret;

}

Regards Tomek

[Petter Myhre]

The documentation doesn't say that it will return NRF_ERROR_INVALID_PARAM if there is no bond coupled with the ID, it says it will return NRF_ERROR_INVALID_PARAM "if the peer ID was not valid." In this context a Peer ID is valid if it is a value between 0 and PM_PEER_ID_N_AVAILABLE_IDS (256).

[PanTikTak]

Yes, You are right. But it could be more convenient for end user to get information whether current peer exist or not. Please consider it with next SDK Release. I will try to change it by myself. (In general you can't delete something that doesnt exist so it should not return Success) . BTW: Your SDK is organized in the best way. Good Job :).

[Petter Myhre]

I agree. Thank you for the feedback, and for the praise.