• State Not Answered
  • Locked Locked
  • Replies 1 reply
  • Subscribers 62 subscribers
  • Views 1664 views
  • Users 0 members are here
Attachments (0)
Nordic Case Info
  • Case ID: 122477
Options
This post is older than 2 years and might not be relevant anymore
More Info: Consider searching for newer posts
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Wrong passkey leads to crash in ble_app_gls example

Joris Roussel

Hi,

I found a bug in ble_app_gls example from SDK_12.3.0 / s130. If user enters a wrong passkey, the app ends in a app_error_fault_handler exception and the central keeps connected until BLE connection timeout.

This comes from a call to sd_ble_gap_disconnect with an invalid connection handle in pm_evt_handler function.

Current code is :

    case PM_EVT_CONN_SEC_FAILED:
    {
        NRF_LOG_INFO("Failed to secure connection. Disconnecting.\r\n");
        m_conn_handle = BLE_CONN_HANDLE_INVALID;
        err_code = sd_ble_gap_disconnect(m_conn_handle,
                                         BLE_HCI_REMOTE_USER_TERMINATED_CONNECTION);
        APP_ERROR_CHECK(err_code);
    } break;

handle should be set to invalid after disconnecting the central. With the fix below, handle of wrong passkey works fine :

    case PM_EVT_CONN_SEC_FAILED:
    {
        NRF_LOG_INFO("Failed to secure connection. Disconnecting.\r\n");
        err_code = sd_ble_gap_disconnect(m_conn_handle,
                                         BLE_HCI_REMOTE_USER_TERMINATED_CONNECTION);
        m_conn_handle = BLE_CONN_HANDLE_INVALID;
        APP_ERROR_CHECK(err_code);
    } break;

This bug also seems to exist in SDK_3.0.0

Best regards, Joris

Related