nRF SDK14 - NRF_DFU_HW_VERSION broken define

[parco]

The following does not allow me to define NRF_DFU_HW_VERSION in my makefile, I get redefine errors due to this broken if else in def_req_handling.c:

#if defined (NRF51) && !defined(NRF_DFU_HW_VERSION)
    #define NRF_DFU_HW_VERSION (51)
#elif defined(NRF52_SERIES)
    #define NRF_DFU_HW_VERSION (52)
#else
    #error No target set for HW version.
#endif

One solution is to wrap in an ultimate #ifndef:

#ifndef NRF_DFU_HW_VERSION
	#if defined (NRF51) && !defined(NRF_DFU_HW_VERSION)
	    #define NRF_DFU_HW_VERSION (51)
	#elif defined(NRF52_SERIES)
	    #define NRF_DFU_HW_VERSION (52)
	#else
	    #error No target set for HW version.
	#endif
#endif

[Petter Myhre]

Seems like a bug.

Thank you for the fix.

[Susheel Nuguru]

I think the define should go something like below

#ifndef NRF_DFU_HW_VERSION
    #if defined (NRF51)
        #define NRF_DFU_HW_VERSION (51)
    #elif defined(NRF52_SERIES)
        #define NRF_DFU_HW_VERSION (52)
    #else
        #error No target set for HW version.
    #endif
#endif