Adding another SPI device to app overlay

[sleeper]

Hi,

below is my app overlay, this works and is used for SPI NOR Flash.

What i need to do is add another device to this SPI bus.

Its an accelerometer LIS2DH from STM. How do it change the app overlay to accommodate this new device on the same bus, but with different CS pin.

&spi0 {

    compatible = "nordic,nrf-spim";

    status = "okay";

    pinctrl-0 = <&spi0_sleep>;

    pinctrl-1 = <&spi0_default>;

    cs-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;

    spi_flash0:spi_flash0@0 {

        compatible = "jedec,spi-nor";

        reg = <0>;

//      irq-gpios = <&gpio0 21 0>;

        spi-max-frequency = <1000000>;

        label = "W25Q64JV";

        jedec-id = [EF 40 17];

        size = <0x4000000>;

    };

};

&pinctrl {

    spi0_sleep: spi0_sleep {

        group1 {

            psels = <NRF_PSEL(SPIM_SCK, 1, 4)>,

           <NRF_PSEL(SPIM_MOSI, 1, 3)>,

           <NRF_PSEL(SPIM_MISO, 1, 6)>;

   

//          low-power-enable;

        };

    };

   

    spi0_default: spi0_default {

        group1 {

            psels = <NRF_PSEL(SPIM_SCK, 1, 4)>,

           <NRF_PSEL(SPIM_MOSI, 1, 3)>,

           <NRF_PSEL(SPIM_MISO, 1, 6)>;

        };  

    };  

};

[sleeper]

Also why do i get this warning ?

'label' is marked as deprecated in 'properties:' in C:/ncs/v2.4.0/zephyr/dts/bindings\mtd\jedec,spi-nor.yaml for node /soc/spi@40003000/spi_flash0@0.

[Sigurd Hellesvik]

From nordic,nrf-spi:

sleeper said:

'label' is marked as deprecated in 'properties:' in C:/ncs/v2.4.0/zephyr/dts/bindings\mtd\jedec,spi-nor.yaml for node /soc/spi@40003000/spi_flash0@0.

The "label" dts property have been deprecated.
Use DT_NODELLABEL instead to get references to DTS nodes.
For example how this is done here: https://github.com/nrfconnect/sdk-nrf/blob/99d94faedc3db9cd640aac12ea3f8849c8ac9651/samples/cellular/lwm2m_client/src/sensors/light_sensor.c#L18

Regards,
Sigurd Hellesvik

[sleeper]

no sure what you mean....???

this is how i get device reference

static const struct device *flash =

    DEVICE_DT_GET(DT_NODELABEL(spi_flash0));

 

this is what the build reports in red

-- Found devicetree overlay: c:/Users/IMS_DEV/Documents/vscode/cdc_acm_composite/app.overlay
'label' is marked as deprecated in 'properties:' in C:/ncs/v2.4.0/zephyr/dts/bindings\mtd\jedec,spi-nor.yaml for node /soc/spi@40003000/spi_flash0@0.

[Sigurd Hellesvik]

That is becasue your DTS node still has the "label" property:

  spi_flash0:spi_flash0@0 {

        compatible = "jedec,spi-nor";

        reg = <0>;

//      irq-gpios = <&gpio0 21 0>;

        spi-max-frequency = <1000000>;

        label = "W25Q64JV";

        jedec-id = [EF 40 17];

        size = <0x4000000>;

    };

[sleeper]

ok that sorted

should i worry about this build warning ? 

CMake Warning at C:/ncs/v2.4.0/zephyr/CMakeLists.txt:838 (message):
No SOURCES given to Zephyr library: lib__libc__common

Excluding target from build.

[Sigurd Hellesvik]

sleeper said:

should i worry about this build warning ? 

CMake Warning at C:/ncs/v2.4.0/zephyr/CMakeLists.txt:838 (message):
No SOURCES given to Zephyr library: lib__libc__common

I do not think you need to worry.

It will be fixed in upcoming releases of the nRF Connect SDK.

See  build/mcuboot/child_image_preload.cmake is created with backslash '\' instead of forward slash '/' on line 7 for more info

[sleeper]

mmmmm ok so i patched with this 

https://github.com/zephyrproject-rtos/zephyr/commit/c03e1900ae7faf2d64b9275735f59c585a028937

and it still creates the warning.....???

-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: C:/ncs/toolchains/31f4403e35/opt/zephyr-sdk/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc.exe
CMake Warning at C:/ncs/v2.4.0/zephyr/CMakeLists.txt:838 (message):
No SOURCES given to Zephyr library: lib__libc__common

Excluding target from build.

[Sigurd Hellesvik]

Maybe you need the other commit, mentioned in  Peripheral LBS example: Policy CMP0010 is not set and No SOURCES given to Zephyr library: lib__libc__common as well?

https://github.com/zephyrproject-rtos/zephyr/pull/56309/commits/2094e19a3c58297125c1289ea0ddec89db317f96