Memfault SDK integration missing user memfault_platform_config

[Konstantin Klitenik]

Hello,

This PR (https://github.com/nrfconnect/sdk-nrf/pull/10938) moved memfault_platform_config.h from an nrf91 sample project into memfault-firmware-sdk/config directory. This directory gets included if the user wants extra NCS metrics. However, since this directory gets included before the user's memfault config, the user's memfault_platform_config.h never gets included. This leaves the user unable to control things like the Memfault heartbeat period (MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS).

Right now, the only solution is to ensure that CONFIG_MEMFAULT_METRICS_EXTRA_DEFS_FILE is set to n. Not sure if this was the intent. 

Please suggest a workaround or provide a fix to the SDK integration.

Thanks,

Konstantin

[Susheel Nuguru]

Konstantine, it seems that PR caused the side effect you mentioned. I will ask the dev team to comment on the intent.

[Susheel Nuguru]

Konstantine, 

The dev team have acknowledged that this is something they need to look into. An internal tracking ticketCIA-1061) has been created.

I will inform you when there is some new information to share.

[Susheel Nuguru]

We heard back from the Memfault team with regards to how to solve this issue where both the NCS integration and the user need to be able to configure the platform. Here’s their response:

We looked at the report today and plan to expose a kconfig option so a user & ncs can have platform configuration files. (Similar to what we did for heartbeat configuration with the MEMFAULT_METRICS_EXTRA_DEFS_FILE option). We'll aim to get that in our next SDK release end of week

After Memfault gets this feature into their SDK, we’ll pull in the updated SDK and implement the required changes.

[Konstantin Klitenik]

Thanks for following up on this.

[Susheel Nuguru]

no problem, just doing my job :) 

Can I mark this thread as verified? We can reopen this in an unlikely event of not seeing this change in the next release.