Nrfconnect 2.4.0 + added qspi for when using spi nor for mcuboot breaking build

[edmcnicholas]

I have been using an nrf52833 with spi nor for mcuboot.  I recently updated the code to 2.4.2 and when I do that nrf_qspi_nor.c gets added and breaks the compile after I add the new bootloader config "CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU=y"  This seems very odd given that this chip does not have qpsi and now the project is looking for the qspi node.  Below is the pi node that has been working until now

&spi3 {

    compatible = "nordic,nrf-spim";

    status = "okay";

    cs-gpios = <&gpio0 15 GPIO_ACTIVE_LOW>; /* D10 */

    pinctrl-0 = <&spi3_default>;

    pinctrl-1 = <&spi3_sleep>;

    pinctrl-names = "default", "sleep";

    MX25U8035F: MX25U8035F@0 {

        compatible = "jedec,spi-nor";

        label = "MX25U8035F";

        reg = <0>;

        spi-max-frequency = <16000000>;

        //wp-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;

        //hold-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;

        size = <0x0800000>;

        has-dpd;

        t-enter-dpd = <10000>;

        t-exit-dpd = <35000>;

        jedec-id = [c2 25 34];

//      has-be32k;

    };

};

[khelmutlord]

The Kconfig you are using is defined in this file here:

https://github.com/nrfconnect/sdk-nrf/blob/7e80dfb9f9b96f0b6ec039e6559c906167764ba0/samples/common/mcumgr_bt_ota_dfu/Kconfig#L25

It is intended to be used with specific samples. You could, instead, add the Kconfigs it selects to your project instead of using CONFIG_NCS_SAMPLE_MCUMGR_BT_OTA_DFU. It seems that the Kconfig is used with samples/boards that use have QSPI flash available.

Specifically, these Kconfigs:
CONFIG_MCUMGR=y

CONFIG_NET_BUF=y

CONFIG_ZCBOR=y

CONFIG_CRC=y

CONFIG_MCUMGR_TRANSPORT_BT=y

[edmcnicholas]

Thanks for the update but please consider changing the qspi line to be excluded if spi nor is included especially since the nrf7002 dk uses spi nor.

imply NORDIC_QSPI_NOR if $(dt_chosen_enabled,$(DT_CHOSEN_EXT_FLASH))

[edmcnicholas]

Those commands by themselves do not work for spi nor.  Using the kconfig link excluding qspi worked for units without nor but not for spi nor.  I am still trying to find a working config.

[edmcnicholas]

I get these failures with spi nor

[00:00:12.072,662] <inf> bleRecovery: Connected
[00:00:13.059,326] <inf> mcuboot_util: Swap type: test
[00:00:13.059,600] <inf> mcuboot_util: Swap type: test
[00:00:13.059,600] <err> mcumgr_img_grp: Image upload inspect failed: 5
[00:00:13.159,790] <inf> mcuboot_util: Swap type: test
[00:00:13.160,064] <inf> mcuboot_util: Swap type: test
[00:00:13.160,095] <err> mcumgr_img_grp: Image upload inspect failed: 5
[00:00:13.259,796] <inf> mcuboot_util: Swap type: test
[00:00:13.260,070] <inf> mcuboot_util: Swap type: test
[00:00:13.260,101] <err> mcumgr_img_grp: Image upload inspect failed: 5
[00:00:13.359,802] <inf> mcuboot_util: Swap type: test
[00:00:13.360,076] <inf> mcuboot_util: Swap type: test
[00:00:13.360,107] <err> mcumgr_img_grp: Image upload inspect failed: 5
[00:00:13.459,838] <inf> mcuboot_util: Swap type: test
[00:00:13.460,113] <inf> mcuboot_util: Swap type: test
[00:00:13.460,144] <err> mcumgr_img_grp: Image upload inspect failed: 5

[edmcnicholas]

The dfu skips dfu and goes right to validating as well