CAF button wakeup does sometimes not happen in ncs 2.5.0, if pressed again while powering down

[tellg]

In ncs 2.4.0, this code was executed in power_manager.c when button pressed while powering down:

            LOG_INF("Wake up when going into sleep - rebooting");

            sys_reboot(SYS_REBOOT_WARM);

In ncs 2.5.0, this does not happen, leading to no more wakeup from that button if pressed again during power down

Note: Still works OK if button not pressed again until after power down is completed

Using custom board with nRF52840

[Hieu]

Hi tellg,

I have gotten feedback from our team. The issue is indeed with the change to use sys_poweroff(), like you have pointed out.

sys_poweroff() will put the system int power-off right in place. Therefore, additional events, such as the button presses, were not processed.

The developers have registered the issue and will work on an alternative approach. I cannot comment on when that will be available though.

Is this issue critical for you now? If yes, is there any change in NCS 2.5.0 that you need, compared to 2.4.2?

[tellg]

It is not critical, since we have 2 buttons configured for wakeup. The chance of a user pressing both buttons during shutdown in minimal. We have also speeded up our shutdown tasks, so that there is less chance for the issue to happen on our device.

But a later fix will of course be welcomed :-)

[Hieu]

That's good to know. I will keep the ticket open and inform here when a fix is released.

Thank you for the report.

[tellg]

Thank you for your help so far.

[tellg]

I guess this is the pull request that fixes this: https://github.com/nrfconnect/sdk-nrf/pull/13133 

Do you think it can be included in ncs 2.5.1?

[Hieu]

You are right. That is the pull request that should fix the issue. Sorry I didn't inform you about earlier.

Since it is already merged, I can say that it's almost certain will be included in the next NCS release. However, I cannot comment on what that release would be, and when it would be. For that, you have to talk with your local sales manager contact.

Do you think you can cherry-pick that pull request and see if it helps?

[tellg]

I tried that pull request and it worked fine for us.

Thank you for all help.