malformed line in Kconfig

[BvdP4Celsius]

I want to use a switch in the overlay file, like:

#if defined(CONDIG_USE_UART_MODBUS)
	&uart1 {
		compatible = "nordic,nrf-uarte";
		status = "okay";
		current-speed = <9600>;
		pinctrl-0 = <&uart1_mod_default>;
		pinctrl-1 = <&uart1_mod_sleep>;
		pinctrl-names = "default", "sleep";
	
		modbus0 {
			compatible = "zephyr,modbus-serial";
			status = "okay";
			de-gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>;
		};
	};
	/* End of The MODBUS handling stuff.*/
#endif

To do so, I try to add a config statement in a custom KConfig file. (mp_Kconfig.conf):

config USE_UART_MODBUS
   bool
   default y

Adding the file to the build configuration under "Extra KConfig Fragments".
I can see that the file is merged, but it keeps complaining about malformed lines.
I tried spaced instead of tab, removed newline characters at the end, but no result.
We are working under Windows
Any hints how to solve this?

Bob

[nordicator_prim3]

This wasn't the error you got exactly but may be what's up. Does it work if you add a prompt to the bool, like:

config USE_UART_MODBUS
   bool "y if using uart modbus"
   default y

According to the Linux docs on Kconfig:

Every menu entry can have at most one prompt, which is used to display to the user. Optionally dependencies only for this prompt can be added with “if”. If a prompt is not present, the config option is a non-visible symbol, meaning its value cannot be directly changed by the user (such as altering the value in .config) and the option will not appear in any config menus. Its value can only be set via “default” and “select” (see below).

So at least not giving it a prompt lets it not show in menuconfig and makes that config not user-definable. That may be bubbling up into the error you're getting because it otherwise seems like it should be fine IMO.

[Sigurd]

Hi!

but it keeps complaining about malformed lines.

Could you post the error code?

[BvdP4Celsius]

Hi, hope this helps.
Adding a prompt does not make any difference.

regards,

Bob

[Sigurd]

Hi!

This definition should not be in the <name>.conf but in a file "Kconfig" instead. Then you can use the "CONFIG_USE_UART_MODBUS" in any <name>.conf file which you adds to the project as a extra Kconfig fragments. 

So you should rename the file mp_Kconfig.conf to Kconfig, then the default setting will be picked up. So no need to add to the build configuration then. If you want to change the default setting you need to add it in a .conf file to change it. 

[BvdP4Celsius]

Hi Sigurd,

renaming the file mp_Kconfig.conf to Kconfig will result in multiple errors due to the fact that de original Kconfig will not be used ( I guess..). Do I need to include the original file in my file now?

Bob