app_fifo bug

[Paolo D]

There is a minor issue with the app_fifo library included with nRF5_SDK_11.0.0-2.alpha_bc3f6a0. If the app_fifo_write function is called with the parameter p_size set to 0, then it will write 1 byte into the FIFO instead of doing nothing.

[Susheel Nuguru]

Agreed... documentation does not say that size cannot be zero, so this should be allowed.

Seems like a bug inside app_fifo_write at the lines below

do
{
    fifo_put(p_fifo, p_byte_array[index++]);
} while (index < write_size);

change this to

while (index < write_size)
{
    fifo_put(p_fifo, p_byte_array[index++]);
};

[Susheel Nuguru]

This also exists in SDK10, so i am going to add it here in the list.

I will not make this list for SDK_11_aplha, because it is "alpha" :). I have created an internal ticket for the team

[Susheel Nuguru]

seems like there is some activity in the ticket I made, so hopefully it will be fixed in next SDK11 release.

[Susheel Nuguru]

This seems to be fixed in sdk12.0, the internal ticket is closed.